Skip to content

fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrisBraun merged 1 commit into from
Jun 24, 2026
Merged

fix(email-classifier): stop promo mail triggering OTP/confirm CTAs #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions libs/email-classifier/src/extract-cta.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
});
});

describe("extractCta — promotional false positives", () => {
// Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
// that the old detector mis-read as an OTP because a 4-8 digit number sat near
// the bare word "code". A genuine one-time code is transactional and direct —
// never a bulk mailing-list blast — so reach=list / promotion must suppress it.
it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
expect(extractCta(signals({
fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
subject: "Hydrojugs are 50% OFF!! 💥",
bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
}))).toBeNull();
});
it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
expect(extractCta(signals({
fromAddress: "deals@modlily.com", fromName: "Modlily",
gmailCategories: ["CATEGORY_PROMOTIONS"],
subject: "Fresh Dress Arrivals Just For You 🎁",
bodyText: "Shop now with code 4070 for free shipping.",
}))).toBeNull();
});
it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
expect(extractCta(signals({
fromAddress: "hello@store.com", fromName: "Store",
subject: "20% off everything",
bodyText: "Enter promo code 5678 for 20% off your order.",
}))).toBeNull();
});
it("does NOT treat an all-same-digit placeholder as an OTP", () => {
expect(extractCta(signals({
fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
subject: "Ends Tonight: 40% Off",
bodyText: "Your code: 000000. Shop the sale now!",
}))).toBeNull();
});
it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
expect(extractCta(signals({
fromAddress: "news@shop.com", fromName: "Shop",
listUnsubscribe: "<https://shop.com/u>",
subject: "Confirm you still want our deals",
authResults: dmarcPass,
links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
}))).toBeNull();
});
it("STILL extracts a genuine OTP from a direct transactional mail", () => {
const cta = extractCta(signals({
fromAddress: "no-reply@acme.com", fromName: "Acme",
subject: "Your verification code",
bodyText: "Your verification code is 482913. It expires in 10 minutes.",
}));
expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
});
});

describe("extractCta — none", () => {
it("returns null for ordinary mail", () => {
expect(extractCta(signals({
Expand Down
20 changes: 19 additions & 1 deletion libs/email-classifier/src/extract-cta.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
if (!m) continue;
const tok = m[1];
if (looksLikeYear(tok)) continue;
if (looksLikePlaceholder(tok)) continue;
return tok;
}
return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
* sender's domain, an http(s) scheme, and the link host on the verified
* registrable domain. Returns null unless a high-confidence detection is made
* (bias to false-negative).
*
* Bulk/promotional mail is suppressed up front: a genuine one-time code or
* account-confirmation link is transactional and directly addressed — never a
* mailing-list blast. Gating on reach=list / format=promotion eliminates the
* dominant false-positive class (a 4-8 digit discount code, price, or SKU
* sitting near the word "code" in a marketing email) that otherwise fires an
* immediate, gate-bypassing OTP push for every promo the user receives.
*/
export function extractCta(s: EmailSignals): Cta | null {
const { reach, format } = classifyEmail(s);
if (reach === "list" || format === "promotion") return null;

const service = serviceName(s);
const code = extractOtp(s);
if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs by KrisBraun · Pull Request #221 · plotday/plot · GitHub
Skip to content
fix(email-classifier): stop promo mail triggering OTP/confirm CTAs#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 1 commit into

from

Jun 24, 2026
 Merged


fix(email-classifier): stop promo mail triggering OTP/confirm CTAs
#221
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


55 changes: 55 additions & 0 deletions
libs/email-classifier/src/extract-cta.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,61 @@ describe("extractCta — confirm link", () => {
 });
});

describe("extractCta — promotional false positives", () => {
 // Real samples mined from prod (martha.braun@gmail.com): bulk marketing mail
 // that the old detector mis-read as an OTP because a 4-8 digit number sat near
 // the bare word "code". A genuine one-time code is transactional and direct —
 // never a bulk mailing-list blast — so reach=list / promotion must suppress it.
 it("does NOT treat a bulk-list promo with a 'code' number as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "sale@l904gw.fi86.fdske.com", fromName: "Ashley Rose Reeves",
 listUnsubscribe: "<https://l904gw.fi86.fdske.com/u>",
 subject: "Hydrojugs are 50% OFF!! 💥",
 bodyText: "Summer blowout! Use code 8558 at checkout for an extra discount.",
 }))).toBeNull();
 });
 it("does NOT treat a Gmail CATEGORY_PROMOTIONS mail (reach=direct) as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "deals@modlily.com", fromName: "Modlily",
 gmailCategories: ["CATEGORY_PROMOTIONS"],
 subject: "Fresh Dress Arrivals Just For You 🎁",
 bodyText: "Shop now with code 4070 for free shipping.",
 }))).toBeNull();
 });
 it("does NOT treat a promo-context 'promo code' line as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "hello@store.com", fromName: "Store",
 subject: "20% off everything",
 bodyText: "Enter promo code 5678 for 20% off your order.",
 }))).toBeNull();
 });
 it("does NOT treat an all-same-digit placeholder as an OTP", () => {
 expect(extractCta(signals({
 fromAddress: "no-reply@penningtons.com", fromName: "Penningtons",
 subject: "Ends Tonight: 40% Off",
 bodyText: "Your code: 000000. Shop the sale now!",
 }))).toBeNull();
 });
 it("does NOT extract a confirm CTA from a bulk-list mailing", () => {
 const dmarcPass = "spf=pass; dkim=pass; dmarc=pass header.from=shop.com";
 expect(extractCta(signals({
 fromAddress: "news@shop.com", fromName: "Shop",
 listUnsubscribe: "<https://shop.com/u>",
 subject: "Confirm you still want our deals",
 authResults: dmarcPass,
 links: [{ text: "Confirm preferences", href: "https://shop.com/confirm" }],
 }))).toBeNull();
 });
 it("STILL extracts a genuine OTP from a direct transactional mail", () => {
 const cta = extractCta(signals({
 fromAddress: "no-reply@acme.com", fromName: "Acme",
 subject: "Your verification code",
 bodyText: "Your verification code is 482913. It expires in 10 minutes.",
 }));
 expect(cta).toEqual({ kind: "otp", service: "Acme", code: "482913", url: null });
 });
});

describe("extractCta — none", () => {
 it("returns null for ordinary mail", () => {
 expect(extractCta(signals({
Expand Down

20 changes: 19 additions & 1 deletion
libs/email-classifier/src/extract-cta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import type { Cta } from "@plotday/twister/facets";
import type { EmailSignals } from "./classify-email";
import { classifyEmail, type EmailSignals } from "./classify-email";

// ---- domains ---------------------------------------------------------------
// Minimal multi-label public suffixes for registrable-domain comparison.
Expand DownExpand Up@@ -56,6 +56,13 @@ function looksLikeYear(t: string): boolean {
 return /^\d{4}$/.test(t) && Number(t) >= 1900 && Number(t) <= 2100;
}

// All-same-digit numeric tokens (0000, 9999, 000000, …) are promo placeholders,
// never real one-time codes. Cheap, high-precision FP filter for marketing mail
// that survives the reach/promotion gate (e.g. a direct "Your code: 000000").
function looksLikePlaceholder(t: string): boolean {
 return /^(\d)\1{3,}$/.test(t);
}

function extractOtp(s: EmailSignals): string | null {
 const hay = `${s.subject ?? ""}\n${s.bodyText ?? ""}`;
 if (!hay.trim()) return null;
Expand All@@ -67,6 +74,7 @@ function extractOtp(s: EmailSignals): string | null {
 if (!m) continue;
 const tok = m[1];
 if (looksLikeYear(tok)) continue;
 if (looksLikePlaceholder(tok)) continue;
 return tok;
 }
 return null;
Expand DownExpand Up@@ -136,8 +144,18 @@ function extractConfirmUrl(s: EmailSignals): string | null {
 * sender's domain, an http(s) scheme, and the link host on the verified
 * registrable domain. Returns null unless a high-confidence detection is made
 * (bias to false-negative).
 *
 * Bulk/promotional mail is suppressed up front: a genuine one-time code or
 * account-confirmation link is transactional and directly addressed — never a
 * mailing-list blast. Gating on reach=list / format=promotion eliminates the
 * dominant false-positive class (a 4-8 digit discount code, price, or SKU
 * sitting near the word "code" in a marketing email) that otherwise fires an
 * immediate, gate-bypassing OTP push for every promo the user receives.
 */
export function extractCta(s: EmailSignals): Cta | null {
 const { reach, format } = classifyEmail(s);
 if (reach === "list" || format === "promotion") return null;

 const service = serviceName(s);
 const code = extractOtp(s);
 if (code) return { kind: "otp", service, code, url: extractConfirmUrl(s) };
Expand Down
Loading