Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(twister): per-product sourceName for aggregate connectors by KrisBraun · Pull Request #226 · plotday/plot · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/aggregate-connector-source-name.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `LinkTypeConfig.sourceName` — a per-link-type product name that overrides the connector's display name when building "{source} {type}" copy. Lets aggregate connectors (e.g. the Google connector, display name "Gmail & Calendar") show the right per-product brand: "Google Calendar event", "Gmail thread", "Google Tasks task".
4 changes: 4 additions & 0 deletions connectors/gmail/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const GMAIL_LINK_TYPES: LinkTypeConfig[] = [
{
type: "email",
label: "Thread",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Gmail falls back to its
// own display name anyway.
sourceName: "Gmail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send a Gmail email",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-calendar/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,6 +41,10 @@ export const CALENDAR_LINK_TYPES: LinkTypeConfig[] = [
{
type: "event",
label: "Event",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Calendar falls
// back to its own display name anyway.
sourceName: "Google Calendar",
sharingModel: "thread" as const,
includesSchedules: true,
logo: "https://api.iconify.design/logos/google-calendar.svg",
Expand Down
4 changes: 4 additions & 0 deletions connectors/google-tasks/src/channels.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,10 @@ export const TASKS_LINK_TYPES: LinkTypeConfig[] = [
{
type: "task",
label: "Task",
// Per-product brand for aggregate connectors (the Google connector's
// display name is "Gmail & Calendar"); standalone Google Tasks falls back
// to its own display name anyway.
sourceName: "Google Tasks",
sharingModel: "none" as const,
// Logo: full-color SVG from static assets (iconify has no logos/google-tasks)
// logoMono: monochrome version from simple-icons (works fine on iconify)
Expand Down
32 changes: 32 additions & 0 deletions connectors/google/test/products.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -214,3 +214,35 @@ describe("PRODUCTS_BY_KEY", () => {
expect(PRODUCTS_BY_KEY.contacts).toBe(contactsProduct);
});
});

// ---------------------------------------------------------------------------
// Per-product source names
//
// The Google connector's display name is "Gmail & Calendar". Each product's
// link types must carry a `sourceName` so the Plot app shows the right
// per-product brand in "{source} {type}" copy (thread type name, compose
// picker) instead of the aggregate connector name.
// ---------------------------------------------------------------------------

describe("product source names", () => {
it("every mail link type declares sourceName 'Gmail'", () => {
expect(mailProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of mailProduct.linkTypes) {
expect(lt.sourceName).toBe("Gmail");
}
});

it("every calendar link type declares sourceName 'Google Calendar'", () => {
expect(PRODUCTS_BY_KEY.calendar.linkTypes.length).toBeGreaterThan(0);
for (const lt of PRODUCTS_BY_KEY.calendar.linkTypes) {
expect(lt.sourceName).toBe("Google Calendar");
}
});

it("every task link type declares sourceName 'Google Tasks'", () => {
expect(tasksProduct.linkTypes.length).toBeGreaterThan(0);
for (const lt of tasksProduct.linkTypes) {
expect(lt.sourceName).toBe("Google Tasks");
}
});
});
2 changes: 1 addition & 1 deletion connectors/outlook-calendar/src/outlook-calendar.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ export class OutlookCalendar extends Connector<OutlookCalendar> {
"Reads your events to add them to your agenda",
"Writes your event RSVPs",
];
readonly linkTypes = [{ type: "event", label: "Event", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];
readonly linkTypes = [{ type: "event", label: "Event", sourceName: "Outlook Calendar", sharingModel: "thread" as const, includesSchedules: true, logo: "https://api.iconify.design/logos/microsoft-icon.svg", logoDark: "https://api.iconify.design/simple-icons/microsoftoutlook.svg?color=%230078D4", logoMono: "https://api.iconify.design/simple-icons/microsoftoutlook.svg" }];

build(build: ToolBuilder) {
return {
Expand Down
3 changes: 3 additions & 0 deletions connectors/outlook-mail/src/outlook-mail.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -249,6 +249,9 @@ export class OutlookMail extends Connector<OutlookMail> {
{
type: "email",
label: "Thread",
// Per-product brand for the aggregate Outlook connector (display name
// "Outlook"); standalone Outlook Mail falls back to its own display name.
sourceName: "Outlook Mail",
noteLabel: "Reply",
sharingModel: "message" as const,
composePlaceholder: "Send an Outlook email",
Expand Down
13 changes: 13 additions & 0 deletions twister/src/tools/integrations.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,19 @@ export type LinkTypeConfig = {
type: string;
/** Human-readable label (e.g., "Issue", "Pull Request") */
label: string;
/**
* Display name of the specific product/source this link type belongs to.
* Used in place of the connector's display name when building
* "{source} {label}" copy (the thread type name, the "Create new …" picker
* entry, compose chips). Only needed for **aggregate** connectors that bundle
* several products under one display name: the Google connector's display
* name is "Gmail & Calendar", but its `event` link type should read
* "Google Calendar event", its `email` link type "Gmail thread", and its
* `task` link type "Google Tasks task". Set it to the standalone product
* name (e.g. "Gmail", "Google Calendar", "Google Tasks"). Single-product
* connectors can omit it — Plot falls back to the connector display name.
*/
sourceName?: string;
/**
* Connector's word for a note on a linked item of this type — used by the
* Flutter app to adapt note/composer copy ("Add a comment" on Linear,
Expand Down
Loading