Skip to content

fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrisBraun merged 2 commits into from
Jun 25, 2026
Merged

fix(google-tasks): handle deleted task list (404) instead of throwing #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
860d10b
fix(google-tasks): handle deleted task list (404) instead of throwing
KrisBraun Jun 25, 2026
6e8f031
chore(google-tasks): update pnpm-lock.yaml for vitest devDependency
KrisBraun Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions connectors/google-tasks/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
"build": "tsc",
"clean": "rm -rf dist",
"deploy": "plot deploy",
"lint": "plot lint"
"lint": "plot lint",
"test": "vitest run",
"test:watch": "vitest"
},
"dependencies": {
"@plotday/twister": "workspace:^"
},
"devDependencies": {
"typescript": "^5.9.3"
"typescript": "^5.9.3",
"vitest": "^2.1.8"
},
"repository": {
"type": "git",
Expand Down
32 changes: 29 additions & 3 deletions connectors/google-tasks/src/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
* Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
* callers can distinguish a permanent "resource gone" (404) — e.g. the user
* deleted a task list while its Plot channel was still enabled — from
* transient 5xx/429 failures worth retrying.
*
* The message format is preserved verbatim (`Google Tasks API error
* <status>: <body>`) for backwards compatibility with existing logs/grouping.
*/
export class GoogleTasksApiError extends Error {
readonly status: number;

constructor(status: number, body: string) {
super(`Google Tasks API error ${status}: ${body}`);
this.name = "GoogleTasksApiError";
this.status = status;
}
}

/**
* True when the error indicates the target task list (or task) no longer
* exists on Google's side. A 404 from a list-scoped endpoint is permanent:
* retrying or reporting it to error tracking is pure noise.
*/
export function isNotFoundError(error: unknown): boolean {
return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
id: string;
title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
});
if (!response.ok) {
const text = await response.text();
throw new Error(
`Google Tasks API error ${response.status}: ${text}`
);
throw new GoogleTasksApiError(response.status, text);
}
return response.json() as Promise<T>;
}
Expand Down
63 changes: 49 additions & 14 deletions connectors/google-tasks/src/sync.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
createTask,
isNotFoundError,
listTasks,
updateTask,
type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
const authActorId = await host.get<ActorId>("auth_actor_id");

// Fetch batch of tasks
const result = await listTasks(token, listId, {
showCompleted: false,
pageToken: state.pageToken ?? undefined,
maxResults: 50,
updatedMin: state.syncHistoryMin ?? undefined,
});
let result;
try {
result = await listTasks(token, listId, {
showCompleted: false,
pageToken: state.pageToken ?? undefined,
maxResults: 50,
updatedMin: state.syncHistoryMin ?? undefined,
});
} catch (error) {
if (isNotFoundError(error)) {
// The task list was deleted on Google's side while still enabled in
// Plot. A 404 here is permanent, so tear the channel down exactly like a
// disable (cancel the poll, clear state, archive its links) instead of
// throwing — otherwise every retry pages error tracking and the message
// eventually dead-letters.
await onChannelDisabledFn(host, listId);
return { done: true };
}
throw error;
}

await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
const token = await getTokenFn(host, listId);
const authActorId = await host.get<ActorId>("auth_actor_id");

const result = await listTasks(token, listId, {
updatedMin: lastSync ?? undefined,
pageToken: state.pageToken ?? undefined,
maxResults: 50,
});
let result;
try {
result = await listTasks(token, listId, {
updatedMin: lastSync ?? undefined,
pageToken: state.pageToken ?? undefined,
maxResults: 50,
});
} catch (error) {
if (isNotFoundError(error)) {
// List deleted on Google's side — stop polling it for good. Tearing down
// here (cancel poll, clear state, archive links) matches the disable path
// and prevents the hourly poll from re-throwing the same 404 forever.
await onChannelDisabledFn(host, listId);
return { done: true };
}
throw error;
}

await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
const token = await getTokenFn(host, listId);
const isDone = link.status === "done";

await updateTask(token, listId, taskId, {
status: isDone ? "completed" : "needsAction",
});
try {
await updateTask(token, listId, taskId, {
status: isDone ? "completed" : "needsAction",
});
} catch (error) {
// The task or its list was deleted on Google's side — there is nothing to
// write back. A 404 is permanent, so swallow it rather than throwing
// (which would retry on the queue and eventually page / dead-letter).
if (isNotFoundError(error)) return;
throw error;
}
}
177 changes: 177 additions & 0 deletions connectors/google-tasks/test/sync.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
const actual = await importOriginal<typeof import("../src/api")>();
return {
...actual,
listTasks: vi.fn(),
updateTask: vi.fn(),
createTask: vi.fn(),
};
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
syncBatchFn,
periodicSyncBatchFn,
onLinkUpdatedFn,
type SyncState,
type PeriodicSyncState,
type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
error: {
code: 404,
message: "Task list not found.",
errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
},
});

type HostHarness = {
host: TasksSyncHost;
store: Map<string, unknown>;
archiveLinks: ReturnType<typeof vi.fn>;
cancelScheduledTask: ReturnType<typeof vi.fn>;
saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
const store = new Map<string, unknown>();
const archiveLinks = vi.fn(async () => {});
const cancelScheduledTask = vi.fn(async () => {});
const saveLink = vi.fn(async () => "thread-id");

const host: TasksSyncHost = {
id: "twist-instance-1",
set: async (key, value) => {
store.set(key, value);
},
// eslint-disable-next-line @typescript-eslint/no-explicit-any
get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
clear: async (key) => {
store.delete(key);
},
tools: {
integrations: {
get: async () => ({ token: "tok", scopes: [] }),
saveLink,
channelSyncCompleted: vi.fn(async () => {}),
archiveLinks,
},
},
scheduler: {
queueSyncBatch: vi.fn(async () => {}),
queuePeriodicSyncBatch: vi.fn(async () => {}),
schedulePeriodicSync: vi.fn(async () => {}),
cancelScheduledTask,
},
};

return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
it("tears the channel down instead of throwing", async () => {
const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
store.set(`sync_enabled_${LIST_ID}`, true);
store.set(`sync_state_${LIST_ID}`, {
pageToken: null,
batchNumber: 1,
tasksProcessed: 0,
initialSync: true,
} satisfies SyncState);

vi.mocked(api.listTasks).mockRejectedValue(
new GoogleTasksApiError(404, NOT_FOUND_BODY)
);

const result = await syncBatchFn(host, LIST_ID);

expect(result).toEqual({ done: true });
// Poll cancelled, links archived, per-channel state cleared.
expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
});

it("still throws on a non-404 (genuine) failure", async () => {
const { host, store } = makeHost();
store.set(`sync_state_${LIST_ID}`, {
pageToken: null,
batchNumber: 1,
tasksProcessed: 0,
initialSync: true,
} satisfies SyncState);

vi.mocked(api.listTasks).mockRejectedValue(
new GoogleTasksApiError(500, "Internal Server Error")
);

await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
});
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
it("tears the channel down instead of throwing", async () => {
const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
store.set(`sync_enabled_${LIST_ID}`, true);
store.set(`periodic_sync_state_${LIST_ID}`, {
pageToken: null,
cycleStart: "2026-06-25T00:00:00.000Z",
} satisfies PeriodicSyncState);

vi.mocked(api.listTasks).mockRejectedValue(
new GoogleTasksApiError(404, NOT_FOUND_BODY)
);

const result = await periodicSyncBatchFn(host, LIST_ID);

expect(result).toEqual({ done: true });
expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
});
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
it("swallows the 404 instead of throwing", async () => {
const { host } = makeHost();
vi.mocked(api.updateTask).mockRejectedValue(
new GoogleTasksApiError(404, NOT_FOUND_BODY)
);

await expect(
onLinkUpdatedFn(host, {
status: "done",
meta: { taskId: "t1", listId: LIST_ID },
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} as any)
).resolves.toBeUndefined();
});

it("still throws on a non-404 failure", async () => {
const { host } = makeHost();
vi.mocked(api.updateTask).mockRejectedValue(
new GoogleTasksApiError(500, "Internal Server Error")
);

await expect(
onLinkUpdatedFn(host, {
status: "done",
meta: { taskId: "t1", listId: LIST_ID },
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} as any)
).rejects.toThrow(/500/);
});
});
10 changes: 10 additions & 0 deletions connectors/google-tasks/vitest.config.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
resolve: {
// Resolve workspace connector packages from their TypeScript source
// using the @plotday/connector export condition (same as the build path).
conditions: ["@plotday/connector", "default"],
},
test: {},
});
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(google-tasks): handle deleted task list (404) instead of throwing by KrisBraun · Pull Request #230 · plotday/plot · GitHub
Skip to content
fix(google-tasks): handle deleted task list (404) instead of throwing#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KrisBraun
merged 2 commits into

from

Jun 25, 2026
 Merged


fix(google-tasks): handle deleted task list (404) instead of throwing
#230
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
860d10b

fix(google-tasks): handle deleted task list (404) instead of throwing


KrisBraun Jun 25, 2026
6e8f031

chore(google-tasks): update pnpm-lock.yaml for vitest devDependency


KrisBraun Jun 25, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
connectors/google-tasks/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,13 +29,16 @@
 "build": "tsc",
 "clean": "rm -rf dist",
 "deploy": "plot deploy",
 "lint": "plot lint"
 "lint": "plot lint",
 "test": "vitest run",
 "test:watch": "vitest"
 },
 "dependencies": {
 "@plotday/twister": "workspace:^"
 },
 "devDependencies": {
 "typescript": "^5.9.3"
 "typescript": "^5.9.3",
 "vitest": "^2.1.8"
 },
 "repository": {
 "type": "git",
Expand Down

32 changes: 29 additions & 3 deletions
connectors/google-tasks/src/api.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,34 @@

const BASE_URL = "https://tasks.googleapis.com/tasks/v1";

/**
 * Error thrown by the Google Tasks REST client. Carries the HTTP `status` so
 * callers can distinguish a permanent "resource gone" (404) — e.g. the user
 * deleted a task list while its Plot channel was still enabled — from
 * transient 5xx/429 failures worth retrying.
 *
 * The message format is preserved verbatim (`Google Tasks API error
 * <status>: <body>`) for backwards compatibility with existing logs/grouping.
 */
export class GoogleTasksApiError extends Error {
 readonly status: number;

 constructor(status: number, body: string) {
 super(`Google Tasks API error ${status}: ${body}`);
 this.name = "GoogleTasksApiError";
 this.status = status;
 }
}

/**
 * True when the error indicates the target task list (or task) no longer
 * exists on Google's side. A 404 from a list-scoped endpoint is permanent:
 * retrying or reporting it to error tracking is pure noise.
 */
export function isNotFoundError(error: unknown): boolean {
 return error instanceof GoogleTasksApiError && error.status === 404;
}

export type GoogleTaskList = {
 id: string;
 title: string;
Expand DownExpand Up@@ -54,9 +82,7 @@ async function request<T>(
 });
 if (!response.ok) {
 const text = await response.text();
 throw new Error(
 `Google Tasks API error ${response.status}: ${text}`
 );
 throw new GoogleTasksApiError(response.status, text);
 }
 return response.json() as Promise<T>;
}
Expand Down

63 changes: 49 additions & 14 deletions
connectors/google-tasks/src/sync.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import type { CreateLinkDraft } from "@plotday/twister/connector";

import {
 createTask,
 isNotFoundError,
 listTasks,
 updateTask,
 type GoogleTask,
Expand DownExpand Up@@ -257,12 +258,26 @@ export async function syncBatchFn(
 const authActorId = await host.get<ActorId>("auth_actor_id");

 // Fetch batch of tasks
 const result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 showCompleted: false,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 updatedMin: state.syncHistoryMin ?? undefined,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // The task list was deleted on Google's side while still enabled in
 // Plot. A 404 here is permanent, so tear the channel down exactly like a
 // disable (cancel the poll, clear state, archive its links) instead of
 // throwing — otherwise every retry pages error tracking and the message
 // eventually dead-letters.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, state.initialSync, authActorId);

Expand DownExpand Up@@ -341,11 +356,23 @@ export async function periodicSyncBatchFn(
 const token = await getTokenFn(host, listId);
 const authActorId = await host.get<ActorId>("auth_actor_id");

 const result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 let result;
 try {
 result = await listTasks(token, listId, {
 updatedMin: lastSync ?? undefined,
 pageToken: state.pageToken ?? undefined,
 maxResults: 50,
 });
 } catch (error) {
 if (isNotFoundError(error)) {
 // List deleted on Google's side — stop polling it for good. Tearing down
 // here (cancel poll, clear state, archive links) matches the disable path
 // and prevents the hourly poll from re-throwing the same 404 forever.
 await onChannelDisabledFn(host, listId);
 return { done: true };
 }
 throw error;
 }

 await saveTaskPageFn(host, result.tasks, listId, false, authActorId);

Expand DownExpand Up@@ -575,7 +602,15 @@ export async function onLinkUpdatedFn(
 const token = await getTokenFn(host, listId);
 const isDone = link.status === "done";

 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 try {
 await updateTask(token, listId, taskId, {
 status: isDone ? "completed" : "needsAction",
 });
 } catch (error) {
 // The task or its list was deleted on Google's side — there is nothing to
 // write back. A 404 is permanent, so swallow it rather than throwing
 // (which would retry on the queue and eventually page / dead-letter).
 if (isNotFoundError(error)) return;
 throw error;
 }
}

177 changes: 177 additions & 0 deletions
connectors/google-tasks/test/sync.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,177 @@
import { describe, it, expect, vi, beforeEach } from "vitest";

// Mock the Google Tasks REST client so listTasks / updateTask can be driven to
// throw a deleted-list 404 without any network I/O. The real GoogleTasksApiError
// class is kept (partial mock) so the production not-found check matches.
vi.mock("../src/api", async (importOriginal) => {
 const actual = await importOriginal<typeof import("../src/api")>();
 return {
 ...actual,
 listTasks: vi.fn(),
 updateTask: vi.fn(),
 createTask: vi.fn(),
 };
});

import { GoogleTasksApiError } from "../src/api";
import * as api from "../src/api";
import {
 syncBatchFn,
 periodicSyncBatchFn,
 onLinkUpdatedFn,
 type SyncState,
 type PeriodicSyncState,
 type TasksSyncHost,
} from "../src/sync";

const LIST_ID = "deleted-list-123";

const NOT_FOUND_BODY = JSON.stringify({
 error: {
 code: 404,
 message: "Task list not found.",
 errors: [{ message: "Task list not found.", domain: "global", reason: "notFound" }],
 },
});

type HostHarness = {
 host: TasksSyncHost;
 store: Map<string, unknown>;
 archiveLinks: ReturnType<typeof vi.fn>;
 cancelScheduledTask: ReturnType<typeof vi.fn>;
 saveLink: ReturnType<typeof vi.fn>;
};

function makeHost(): HostHarness {
 const store = new Map<string, unknown>();
 const archiveLinks = vi.fn(async () => {});
 const cancelScheduledTask = vi.fn(async () => {});
 const saveLink = vi.fn(async () => "thread-id");

 const host: TasksSyncHost = {
 id: "twist-instance-1",
 set: async (key, value) => {
 store.set(key, value);
 },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 get: async <T>(key: string) => (store.has(key) ? (store.get(key) as T) : null),
 clear: async (key) => {
 store.delete(key);
 },
 tools: {
 integrations: {
 get: async () => ({ token: "tok", scopes: [] }),
 saveLink,
 channelSyncCompleted: vi.fn(async () => {}),
 archiveLinks,
 },
 },
 scheduler: {
 queueSyncBatch: vi.fn(async () => {}),
 queuePeriodicSyncBatch: vi.fn(async () => {}),
 schedulePeriodicSync: vi.fn(async () => {}),
 cancelScheduledTask,
 },
 };

 return { host, store, archiveLinks, cancelScheduledTask, saveLink };
}

beforeEach(() => {
 vi.clearAllMocks();
});

describe("syncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await syncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 // Poll cancelled, links archived, per-channel state cleared.
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 expect(store.has(`sync_state_${LIST_ID}`)).toBe(false);
 expect(store.has(`sync_enabled_${LIST_ID}`)).toBe(false);
 });

 it("still throws on a non-404 (genuine) failure", async () => {
 const { host, store } = makeHost();
 store.set(`sync_state_${LIST_ID}`, {
 pageToken: null,
 batchNumber: 1,
 tasksProcessed: 0,
 initialSync: true,
 } satisfies SyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(syncBatchFn(host, LIST_ID)).rejects.toThrow(/500/);
 });
});

describe("periodicSyncBatchFn — deleted task list (404)", () => {
 it("tears the channel down instead of throwing", async () => {
 const { host, store, archiveLinks, cancelScheduledTask } = makeHost();
 store.set(`sync_enabled_${LIST_ID}`, true);
 store.set(`periodic_sync_state_${LIST_ID}`, {
 pageToken: null,
 cycleStart: "2026-06-25T00:00:00.000Z",
 } satisfies PeriodicSyncState);

 vi.mocked(api.listTasks).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 const result = await periodicSyncBatchFn(host, LIST_ID);

 expect(result).toEqual({ done: true });
 expect(cancelScheduledTask).toHaveBeenCalledWith(`poll:${LIST_ID}`);
 expect(archiveLinks).toHaveBeenCalledWith({ channelId: LIST_ID });
 });
});

describe("onLinkUpdatedFn — deleted task/list (404)", () => {
 it("swallows the 404 instead of throwing", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(404, NOT_FOUND_BODY)
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).resolves.toBeUndefined();
 });

 it("still throws on a non-404 failure", async () => {
 const { host } = makeHost();
 vi.mocked(api.updateTask).mockRejectedValue(
 new GoogleTasksApiError(500, "Internal Server Error")
 );

 await expect(
 onLinkUpdatedFn(host, {
 status: "done",
 meta: { taskId: "t1", listId: LIST_ID },
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 } as any)
 ).rejects.toThrow(/500/);
 });
});

10 changes: 10 additions & 0 deletions
connectors/google-tasks/vitest.config.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({
 resolve: {
 // Resolve workspace connector packages from their TypeScript source
 // using the @plotday/connector export condition (same as the build path).
 conditions: ["@plotday/connector", "default"],
 },
 test: {},
});

3 changes: 3 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading