fix(gmail): don't JSON-parse empty 204 bodies in GmailApi.call

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code

[KrisBraun]

Problem

PostHog 019eff7f — SyntaxError: Unexpected end of JSON input, surfaced as an unhandled twist exception during the Google composite connector's mailEnsureWebhook.

Root cause is in the shared Gmail API client GmailApi.call():

returnawaitresponse.json();// unconditional

Gmail's users.stop endpoint (POST /stop, called by stopWatch()) returns 204 No Content with an empty body. response.json() on an empty body throws this exact error.

It escaped to error tracking because setupWatch()'s recovery path calls this.stopWatch()unguarded (taken when the first /watch returns 400 "Only one user push notification client allowed"), unlike setupMailboxWebhookFn's best-effort cleanup stopWatch() which is wrapped in try/catch. The parse error then propagated up through mailEnsureWebhook → handleTwistOperation.

Affects both the Gmail connector and the Google composite connector (twist 6e9e441f…), which reuses this client via @plotday/connector-gmail.

Fix

Fix at the source — read the body as text and parse only when non-empty, so any empty-body response (204 or empty 200) returns undefined instead of throwing:

consttext=awaitresponse.text();returntext ? JSON.parse(text) : undefined;

Behavior is unchanged for normal JSON responses; no caller consumes a stopWatch/modifyThread return (both are Promise<void>).

Tests

• New failing-then-passing test reproducing the crash via stopWatch() on a 204, plus a JSON regression test.
• Full gmail suite 55/55 pass; tsc --noEmit clean for gmail and the google composite connector; plot lint clean.

🤖 Generated with Claude Code