test(google): mock response.text() in mailProduct fetch doubles by KrisBraun · Pull Request #234 · plotday/plot

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun · 2026-06-25T22:52:04Z

Problem

Two mailProduct tests in connectors/google/test/products.test.ts fail on main:

TypeError: response.text is not a function
❯ GmailApi.call gmail/src/gmail-api.ts:134 (await response.text())

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it. The two mail tests stubbed fetch with a response double exposing only json(), so the new text() read threw and both tests failed. The tasks/contacts tests were unaffected — they go through a different API client (or no network) that doesn't hit the changed text() path.

This is a test-mock gap, not a runtime bug: a real Gmail Response has .text().

Fix

Make the mocked fetch responses faithful to a real Response by adding text() alongside json() in both mail tests. Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text.

Verification

pnpm exec vitest run test/products.test.ts → 22 passed (was 2 failed | 20 passed)
Full google-connector suite → 62 passed (6 files)

🤖 Generated with Claude Code

Commit 302349f ("don't JSON-parse empty 204 bodies in GmailApi.call") switched GmailApi.call from response.json() to reading await response.text() then JSON.parse-ing it (gmail/src/gmail-api.ts:134). The two mailProduct tests in connectors/google/test/products.test.ts stubbed fetch with a response double exposing only json(), so the new text() read threw "TypeError: response.text is not a function" and both tests failed. (The tasks tests were unaffected — they go through a different API client that still uses json().) Make the mocked fetch responses faithful to a real Response by adding text() alongside json(). Extracted a fakeLabels const in the compose test to avoid duplicating the labels literal across json/text. All 62 google-connector tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

KrisBraun merged commit c82fc47 into mainJun 25, 2026
1 check passed

KrisBraun deleted the fix/google-products-test-text-mock branch June 25, 2026 22:52