') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(twister): resolve exemplar package self-imports in lint and editors by KrisBraun · Pull Request #279 · plotday/plot · GitHub
Skip to content

fix(twister): resolve exemplar package self-imports in lint and editors#279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrisBraun merged 1 commit into from
Jul 9, 2026
Merged

fix(twister): resolve exemplar package self-imports in lint and editors #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twister-exemplar-lint-resolution.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": patch
---

Fixed: package lint and editor type resolution for the exemplar sources' package self-imports (bundler moduleResolution now applies package-wide; the CommonJS CLI build uses its own standalone config).
13 changes: 1 addition & 12 deletions twister/tsconfig.build.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,18 +8,7 @@
"declarationMap": true,
"sourceMap": true,
"noEmit": false,
"composite": false,
// src/exemplars/*.ts import "@plotday/twister" by package name (so the
// embedded LLM-facing examples show real import paths, not relative
// ones). Resolving that self-reference requires the same
// moduleResolution + custom condition tsconfig.base.json already grants
// downstream twist/connector projects for the reverse case (resolving
// @plotday/twister straight to this package's src/*). Scoped to this
// build-only config (not tsconfig.json / tsconfig.cli.json) since
// "bundler" resolution is incompatible with tsconfig.cli.json's
// CommonJS output (TS5095).
"moduleResolution": "bundler",
"customConditions": ["@plotday/connector"]
"composite": false
},
"include": ["src/**/*.ts"],
"exclude": [
Expand Down
10 changes: 9 additions & 1 deletion twister/tsconfig.cli.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,23 @@
{
"$schema": "https://json.schemastore.org/tsconfig",
"extends": "./tsconfig.json",
// Standalone (does not extend tsconfig.json): the base config uses
// "bundler" moduleResolution + customConditions so the exemplars'
// package self-imports resolve, and both options are incompatible with
// this config's CommonJS output (TS5095/TS5098).
"compilerOptions": {
"module": "CommonJS",
"moduleResolution": "node",
"target": "ES2020",
"lib": ["ES2020"],
"outDir": "./bin",
"rootDir": "./cli",
"resolveJsonModule": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"forceConsistentCasingInFileNames": true,
"skipLibCheck": true,
"strict": true,
"sourceMap": true,
"noEmit": false
},
"include": ["cli/**/*.ts"]
Expand Down
9 changes: 8 additions & 1 deletion twister/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,14 @@
"target": "ESNext",
"lib": ["ES2021", "ES2022.error", "WebWorker"],
"module": "ESNext",
"moduleResolution": "node",
// src/exemplars/*.ts import "@plotday/twister" by package name (so the
// embedded LLM-facing examples show real import paths). Resolving that
// self-reference needs bundler resolution + the custom condition that
// downstream twist/connector projects already use for the reverse case.
// tsconfig.cli.json overrides moduleResolution back to "node" for its
// CommonJS output ("bundler" is incompatible with CommonJS, TS5095).
"moduleResolution": "bundler",
"customConditions": ["@plotday/connector"],
"resolveJsonModule": true,
"allowJs": true,
"checkJs": false,
Expand Down
Loading