Uh oh!
There was an error while loading. Please reload this page.
fix(google-calendar): one Join button per meeting; render plaintext descriptions cleanly - #327
Merged
Merged
Conversation
…scriptions correctly Google Calendar events with a Microsoft Teams (or similar) meeting could surface several "Join" buttons and a garbled description note. - extractConferencingLinks scraped every provider-matching URL out of the event description, including pages that are not click-to-join links: the Teams /meetingOptions organizer settings page, Webex's /msteams device-gateway page, and dial-in local-number pages. It now filters those out and keeps a single join link per provider, collapsing the two Teams join forms (/meet/ and /l/meetup-join/) into one button. - containsHtml treated any `<...>` as an HTML tag, so plain-text invites containing angle-bracket autolinks (`Label<https://url>`, `<tel:...>`) were routed through the HTML-to-Markdown converter, which flattened newlines and left walls of escaped underscores. It now matches only real HTML tags, so plaintext descriptions take the plaintext path and render cleanly.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Google Calendar event carrying a pasted Microsoft Teams meeting invite could surface several "Join" videoconferencing buttons and a garbled description note (a run-on line of escaped-underscore separators plus dial-in/compliance boilerplate).
Fixes
One join link per meeting —
extractConferencingLinksscraped every provider-matching URL out of the event description as a join link, including pages that are not click-to-join:/meetingOptionsorganizer-settings page,/msteams"join on a video device / more info" gateway,dialin.*hosts).It now filters those out (
isConferencingJoinUrl) and keeps a single join link per provider, collapsing the two Teams join forms (/meet/and/l/meetup-join/) into one button.Plaintext descriptions render cleanly —
containsHtmlmatched any<...>as an HTML tag, so plain-text invites containing angle-bracket autolinks (Label<https://url>,<tel:...>) were routed through the HTML→Markdown converter, which flattened newlines and left walls of escaped underscores. It now recognises only real HTML tags (a tag name followed by whitespace,/, or>), so plaintext descriptions take the plaintext path — which already normalizes separator bars, convertsLabel<url>links, and preserves paragraphs.Tests
Added unit tests for
containsHtml(autolinks are not HTML; real tags are) andextractConferencingLinks(non-join URLs dropped; one link per provider; structuredconferenceDatapreferred). Full connector suite green (265 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_015EA4XqgTRwyWjKMVx8Lgr5