Uh oh!
There was an error while loading. Please reload this page.
Move email classification out of the connector SDK repository - #364
Merged
Conversation
Connectors extracting mail signals no longer need a separate package dependency for sender-identity detection.
Its classification logic now lives with the platform that runs it. Connectors emit raw signals rather than classifying, so nothing in this repository consumes it; the sender-identity helper they did use is now part of the SDK.
The doc comment referenced "the email classifier", which no longer exists as a concept in this package now that isNoReplySender lives directly in the signals entry point. Update the reference so connector authors reading the SDK types land on the right helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isNoReplySenderto the@plotday/twistersignals entry point (@plotday/twister/signals), so connectors can detect automated/no-reply sender addresses without depending on a separate classification package.@plotday/email-classifierpackage entirely. It hasn't been consumed by any connector's runtime classification logic since connectors moved to emitting raw mail signals for the platform to classify; the one helper connectors still needed (isNoReplySender) is now part of the SDK.isNoReplySenderfrom its new location, and drops the now-unused dependency on@plotday/email-classifierfrom the Google, Outlook, and Apple connector packages.For connector authors
If you were depending on
@plotday/email-classifierforisNoReplySender, import it from@plotday/twister/signalsinstead. No other connector in this repository used anything else from that package, so this should be a drop-in change wherever it applies.Test plan
pnpm validate-changesetsgoogle,outlook,appleconnectors: build + full test suite +tsc --noEmit, all passingtwisterpackage builds cleanly🤖 Generated with Claude Code