Uh oh!
There was an error while loading. Please reload this page.
feat(twister)!: remove cta from the note type - #365
Merged
Conversation
The ephemeral one-time-code prompt it fed has been retired and the value is no longer stored. Detection of one-time-code and confirmation mail during classification is unchanged.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctafield from the note type (NewNote.cta) — the ephemeral one-time-code / confirmation prompt it fed has been retired and the value is no longer stored.Cta/CtaKindtypes (re-documented for their actual purpose): one-time-code and confirmation mail is still detected during classification, and connectors that read that detection are unaffected.@plotday/twister(NewNote.ctaremoved).Test plan
pnpm validate-changesetspassespnpm --filter @plotday/twister lintpassestwisterbuilds cleanlyemail-classifier(the package whoseextractCtastill returns aCta) builds and its full test suite passes (65/65), proving the type removal didn't break its consumer🤖 Generated with Claude Code