Uh oh!
There was an error while loading. Please reload this page.
Slack: emit classifier facets on direct-conversation links - #381
Merged
Conversation
Channel threads have carried classifier facets since facet extraction
landed, but the direct-conversation path assembles its links in
assembleSlackDmLink, which never set link.facets — so the conversations
this connector chiefly syncs (DMs, group DMs) reached the platform with
no facets at all.
Direct and group conversations now carry
{format: chat, automation, reach: direct}. Automation judges the batch
as a whole and is "automated" only when EVERY message is bot-shaped
(bot_id, bot_message subtype, or no user): a single human-shaped message
makes the conversation "human", because a classifier hiding a real
person's message is strictly worse than showing an automated one.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FHoQc2TdA62Wp4BwUxvR6P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack direct and group conversations now carry classifier facets. Channel threads have emitted facets since facet extraction landed, but the direct-conversation path assembles its links in
assembleSlackDmLink, which never setlink.facets— so the conversations this connector chiefly syncs (DMs, group DMs, saved messages) reached the platform with no facets at all, leaving facet-driven classification unable to see them as direct human conversations.Behavior
Every direct or group conversation link now carries
{format: "chat", automation, reach: "direct"}:reachisdirectby construction — a DM addresses the user.formatischat— the conversation link represents an ongoing chat regardless of any one message's length.automationjudges the synced batch as a whole and isautomatedonly when every message is bot-shaped (bot_id,bot_messagesubtype, or nouser). A single human-shaped message makes the conversationhuman: a classifier hiding a real person's message is strictly worse than showing an automated one, so the verdict fails open towardhuman.The channel-thread path is unchanged (it already emits per-message facets via
slackFacets).Testing
slack-dm.test.ts); written failing-first against the unfixed assembler.tsc --noEmitandplot lintclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01FHoQc2TdA62Wp4BwUxvR6P