Add update_title config option

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃

[etpinard]

fixes#101

• add update_title String field to DashConfig struct
• use `"Updating..." as default
• inject its value into the frontend, to make it available to the dash renderer

TODO:

• should we allow update_title=nothing inputs?
• add tests

[etpinard]

mostly copied from

https://github.com/plotly/dash/blob/edce37426470b900a0081969af30364e43c9a888/dash/dash.py#L243-L247

except for the None part.

[alexcjohnson]

Only supporting '' is fine by me.

[alexcjohnson]

re: tests - dynamic behavior is covered by the tests in plotly/dash#1315, here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

[etpinard]

here it would be fine to just assert dashjl.driver.execute_script("return store.getState().config.update_title") == expected for the default and one non-default case.

My attempt in -> 4b07cab

Thanks for tips!

[alexcjohnson]

LGTM! I've enabled forks in CircleCI, didn't realize we hadn't done that yet. Would you push an empty commit to see if the tests will run?

[alexcjohnson]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

[waralex]

@waralex This step fails for forks:

Dash.jl/test/ci_prepare.jl

Line 7 in cb64b94

Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"]))

But we already have the appropriate version of the code in a local directory, can't we just use that?

Yes, we can use Pkg.develop instead of Pkg.add

 Pkg.develop(pkg::Union{String, Vector{String}}; io::IO=DEFAULT_IO[])
Pkg.develop(pkgs::Union{Packagespec, Vector{Packagespec}}; io::IO=DEFAULT_IO[])
Make a package available for development by tracking it by path. If pkg is given with only a name or by a URL, the package will be downloaded to the location specified by the environment variable JULIA_PKG_DEVDIR, with .julia/dev as the default.
If pkg is given as a local path, the package at that path will be tracked.
Examples
≡≡≡≡≡≡≡≡≡≡
# By name
Pkg.develop("Example")
# By url
Pkg.develop(url="https://github.com/JuliaLang/Compat.jl")
# By path
Pkg.develop(path="MyJuliaPackages/Package.jl")
See also PackageSpec

[waralex]

@alexcjohnson, @etpinard In fact, there is another problem - the components are placed by direct reference to git, and not through the package repository. Apparently I wrote this file when the components were not registered yet. I fixed it in this PR #104. In that #104 unit tests pass, let's check in current one. Perhaps you should just copy the changes from #104 to this PR and merge them within current PR

[alexcjohnson]

Great - Thanks @etpinard ! 💃