Skip to content

Delay import of plotly until transform method to avoid possibility of circular import#25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonmmease merged 1 commit into from
Jul 28, 2020
+1 −1
Merged

Delay import of plotly until transform method to avoid possibility of circular import #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repos/kaleido/py/kaleido/scopes/plotly.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
from __future__ import absolute_import
from kaleido.scopes.base import BaseScope
from _plotly_utils.utils import PlotlyJSONEncoder
from plotly.graph_objects import Figure
import base64


Expand DownExpand Up@@ -66,6 +65,7 @@ def transform(self, figure, format=None, width=None, height=None, scale=None):
:return: image bytes
"""
# TODO: validate args
from plotly.graph_objects import Figure
if isinstance(figure, Figure):
figure = figure.to_dict()

Expand Down