Uh oh!
There was an error while loading. Please reload this page.
ensures that padded space is not larger than figure - #3
Conversation
I added the built files to commit 6f19390 to enable easy inclusion in plotly.js' |
| var L = max(nodesByBreadth, function(nodes) { | ||
| return nodes.length; | ||
| }); | ||
| var maxNodePadding = 2/3 * size[1] / (L - 1); |
There was a problem hiding this comment.
I like the 2/3 - looks good. Lets define it up top though by the properties block:
Lines 7 to 11 in 6f19390
not that I think we need to make it a property now, though we may want to do that later. For now I just want it to be easier to find, in case someone's wondering why they get our warning (or why the padding refuses to get bigger)
There was a problem hiding this comment.
Thank you for pointing this out! It should now be resolved in commit 1a79abb!
alexcjohnson
commented
Oct 24, 2018
💃 Very nice and clean! |
In order to fix this issue plotly/plotly.js#3140, we override
nodePaddingif it's too large.