Skip to content

React 16.13#494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marc-Andre-Rivet merged 12 commits into from
Mar 10, 2020
Merged

React 16.13 #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a947e5d
react 16.12, UNSAFE, build artifacts
Mar 4, 2020
4133406
Merge branch 'master' into exp-react-16.12
Marc-Andre-Rivet Mar 4, 2020
2cefaa5
pylint ignore
Mar 5, 2020
3899822
Merge branch 'exp-react-16.12' of github.com:plotly/dash-bio into exp…
Mar 5, 2020
d24d9f9
react 16.13
Mar 6, 2020
776fbaa
redundant deps?
Mar 6, 2020
a47358b
remove additional pylint exclusions
Mar 6, 2020
6dab284
add back pylint ignored rules
Mar 6, 2020
5199127
Merge branch 'master' into exp-react-16.12
Marc-Andre-Rivet Mar 10, 2020
e9287e9
Dash dev branch
Mar 10, 2020
0a0cc67
Merge branch 'exp-react-16.12' of github.com:plotly/dash-bio into exp…
Mar 10, 2020
9f4cafa
Always install Dash dev branch
Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,7 +59,7 @@ jobs:
- run: echo $PYVERSION > ver.txt

- restore_cache:
key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}
key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}-{{ checksum ".circleci/config.yml" }}

- run:
name: Create virtualenv
Expand All@@ -71,13 +71,20 @@ jobs:
command: |
. venv/bin/activate
pip install --progress-bar off -r tests/requirements.txt --quiet
pip install --progress-bar off dash[testing]

- save_cache:
key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}
key: deps1-{{ .Branch }}-{{ checksum "requirements.txt" }}-{{ checksum "tests/requirements.txt" }}-{{ checksum "ver.txt" }}-{{ checksum ".circleci/config.yml" }}

@shammamah-zzshammamah-zzMar 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

paths:
- venv

- run:
name: Install Dash
command: |
. venv/bin/activate
git clone --depth 1 https://github.com/plotly/dash.git dash-main
cd dash-main && pip install -e .[dev,testing]
cd dash-renderer && npm run build && pip install -e . && cd ../..

- run:
name: Run pylint
command: |
Expand Down
2 changes: 2 additions & 0 deletions .pylintrc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,6 +151,8 @@ disable=print-statement,
too-many-lines,
too-many-instance-attributes,
too-few-public-methods,
unsubscriptable-object,

@shammamah-zzshammamah-zzMar 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where were we getting these errors?

@Marc-Andre-RivetMarc-Andre-RivetMar 6, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://circleci.com/gh/plotly/dash-bio/5997?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@Marc-Andre-RivetMarc-Andre-RivetMar 6, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back the rule as https://circleci.com/gh/plotly/dash-bio/6024 demonstrates that this passed on master because it wasn't running the expect version of pylint (2.3.0 instead of 1.9.4) which has different defaults.

unsupported-assignment-operation,

# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
## [Unreleased]
### Changed
* [#489](https://github.com/plotly/dash-bio/pull/489) Renamed async modules with hyphen `-` instead of tilde `~`
- [#494](https://github.com/plotly/dash-bio/pull/494) Update from React 16.8.6 to 16.13.0

## [0.4.7] - 2020-02-21
### Added
Expand Down
2 changes: 1 addition & 1 deletion dash_bio/async-needle.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_bio/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 20 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,9 +39,9 @@
"molecule-3d-for-react": "git://github.com/plotly/molecule-3d-for-react.git",
"plotly.js": "^1.52.2",
"ramda": "^0.26.0",
"react": "16.8.6",
"react": "16.13.0",
"react-alignment-viewer": "^0.5.5",
"react-dom": "16.8.6",
"react-dom": "16.13.0",
"react-oncoprint": "^1.2.3",
"react-plotly.js": "^2.4.0",
"react-sequence-viewer": "git://github.com/plotly/react-sequence-viewer.git",
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
# pip install -r requirements.txt

cython>=0.19
dash>=1.6.1
dash-bio-utils==0.0.4
dash-daq==0.2.2
gunicorn==19.9.0
Expand Down
2 changes: 1 addition & 1 deletion src/lib/fragments/NeedlePlot.react.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ export default class NeedlePlot extends Component {
this.handleChange = this.handleChange.bind(this);
}

componentWillMount() {
UNSAFE_componentWillMount() {
// For default argument of taken from defaultProps deeply nested
this.props = mergeDeepRight(NeedlePlot.defaultProps, this.props);
}
Expand Down
3 changes: 0 additions & 3 deletions tests/requirements.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
-r ../requirements.txt

# Additional packages needed to run the tests.
chromedriver-binary==2.45.0
flake8==3.6.0
ipdb==0.11
pylint==2.3.0