Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Update requirements to support React 16 by mjclawar · Pull Request #165 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CONTRIBUTING.md → .github/CONTRIBUTING.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,3 +17,11 @@ like this:
```
export TOX_PYTHON_27=~/.pyenv/versions/2.7.14/bin/python
```

## Making a pull request
In order to update the PyPI and npm packages correctly, the following pieces need to be in sync:

- `dash_core_components/version.py` should updated to, e.g., `__version__ = '1.0.0'` if the version should be bumped to `v1.0.0`
- `package.json` has been versioned using `npm version <major | minor | patch>`. See the [npm docs](https://docs.npmjs.com/cli/version) for more on versioning
- `CHANGELOG.md` has a detailed new entry for the new version or changes to the code
- `MANIFEST.in` has been updated if non-Python files were updated in `dash_core_components/` (note that this is much rarer, typically for changes involving included css or js)
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
<!--- Thanks for starting to open an issue for dash-core-components! We appreciate you being a part of the community. -->
<!--- Note that for general help questions, https://community.plot.ly/c/dash is probably your best bet! --->
<!--- You can help make the development process better by taking some time to write a complete description of the bug or feature request. -->
<!--- Below, provide a general summary of your changes in the Title above -->

<!--- Please fill out a description, even if you are reporting a simple issue. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- A clear and concise description of what the issue is about. Include things like expected/desired behavior, actual behavior, motivation or rationale for a new feature, what files it concerns, etc. -->

## Sub-tasks
<!--- If you suspect that this issue has multiple steps to get the job done, list them out as markdown checkboxes. -->
<!--- If not, feel free to delete this section. -->
- [ ] Task 1
- [ ] Task 2
- [ ] Task 3
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
<!--- Provide a general summary of your changes in the Title above -->

<!--- Fill out a description and motivation. If it is something truly simple, it is okay to keep it short and sweet. -->
## Description
<!--- Describe your changes in detail and link to the issue that is driving this pull request (if any). The description here should describe what features were added, or addressing a bug and describing what was fixed.-->

<!--- Did you run the test suite locally? Did you add any tests for new behavior? -->
- [ ] `dash_core_components/version.py` has been updated if necessary
- [ ] `package.json` has been versioned if necessary
- [ ] `CHANGELOG.md` has a detailed new entry if necessary
- [ ] `MANIFEST.in` has been updated if non-Python files were updated in dash_core_components
- [ ] [Tests pass](https://github.com/plotly/dash-core-components/blob/master/.github/CONTRIBUTING.md#running-the-tests) on my local machine

## What does this address?
<!--- What bug does this fix? What issues does this close? -->
Closes #
26 changes: 25 additions & 1 deletion CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,31 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [1.0.0] - 2018-04-01
### Changed
**BREAKING**
- Update versions for:
- `react-dates` to `"16.3.2"`
- `react-dropzone` to `"4.2.8"`
- `react-markdown` to `"3.2.1"`
- `react-select` to `"1.2.1"`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping major versions in these libraries, I bet that this will introduce some breaking changes in the component's CSS. In case any users are overriding this CSS, then their overrides won't work anymore. So, I think we should make a breaking change version bump to 1.0.0 (according to semver)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's leave a note in the changelog that mentions that CSS stylesheets may be different

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually looked into whether or not the CSS or markup has changed in these versions, I'm just guessing that it has.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will update to 1.0.0.

- `react-select-fast-filter-options` to `"0.2.3"`
- `react-syntax-highlighter` to `"7.0.0"`
- `react-virtualized-select` to `"3.1.3"`
- `react` and `react-dom` as peerDependencies `"^15.4.0 || ^16.0.0"`

Note that these changes may involve changes to the stylesheets for the dependencies.
External CSS overrides (e.g., from user stylesheets) may no longer work as intended.

- Change import location from `react-syntax-highlighter` to:
```js
import {arduinoLight, monokai} from 'react-syntax-highlighter/styles/hljs';
```
- Change import location from `react-virtualized-select` to:
```js
import ReactDropdown from 'react-virtualized-select/dist/umd/react-virtualized-select';
```

## [0.22.0] - 2018-04-03
### Added
- Previously, if a user named their app file `dash.py`, an unhelpful error
Expand DownExpand Up@@ -113,7 +138,6 @@ See https://github.com/plotly/plotly.js/releases/tag/v1.34.0 for the official no
- Fix handling of double negative translate transform values [https://github.com/plotly/plotly.js/pull/2339]
- Fix compare `hovermode` fallback for non-cartesian subplot types [https://github.com/plotly/plotly.js/pull/2339]


## [0.19.0] - 2018-02-11
### Changed
- `PropTypes` now uses `prop-types` package instead of `React` to support move to React 16+
Expand Down
10 changes: 5 additions & 5 deletions MANIFEST.in
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
include dash_core_components/bundle.js
include dash_core_components/bundle.js.map
include dash_core_components/metadata.json
include dash_core_components/rc-slider@6.1.2.css
include dash_core_components/react-select@1.0.0-rc.3.min.css
include dash_core_components/rc-slider@8.6.0.css
include dash_core_components/react-select@1.2.1.min.css
include dash_core_components/plotly-1.35.2.min.js
include dash_core_components/react-virtualized-select@3.1.0.css
include dash_core_components/react-virtualized@9.9.0.css
include dash_core_components/react-dates@12.3.0.css
include dash_core_components/react-virtualized-select@3.1.3.css
include dash_core_components/react-virtualized@9.18.5.css
include dash_core_components/react-dates_datepicker@16.3.2.min.css
include README.md
include LICENSE.md
2 changes: 1 addition & 1 deletion config/webpack/partials/babel.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ module.exports = function (config) {
return partial(config, {
module: {
loaders: [
{test: /\.json$/, loader: 'json-loader'},
{test: /\.json$/, loader: 'json-loader'},
{
test: /\.js/,
include: [SRC],
Expand Down
21 changes: 11 additions & 10 deletions dash_core_components/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -40,18 +40,19 @@
_css_dist = [
{
'relative_package_path': [
'rc-slider@6.1.2.css',
'react-select@1.0.0-rc.3.min.css',
'react-virtualized@9.9.0.css',
'react-virtualized-select@3.1.0.css',
'react-dates@12.3.0.css'
'rc-slider@8.6.0.css',
'react-select@1.2.1.min.css',
'react-virtualized@9.18.5.css',
'react-virtualized-select@3.1.3.css',
'react-dates_datepicker@16.3.2.min.css'
],
'external_url': [
'https://unpkg.com/react-select@1.0.0-rc.3/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.9.0/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.0/styles.css',
'https://unpkg.com/rc-slider@6.1.2/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/react-dates@12.3.0.css'.format(__version__)
'https://unpkg.com/react-select@1.2.1/dist/react-select.min.css',
'https://unpkg.com/react-virtualized@9.18.5/styles.css',
'https://unpkg.com/react-virtualized-select@3.1.3/styles.css',
'https://unpkg.com/rc-slider@8.6.0/assets/index.css',
'https://unpkg.com/dash-core-components@{}/dash_core_components/'
'react-dates_datepicker@16.3.2.min.css'.format(__version__)
],
'namespace': 'dash_core_components'
}
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
padding: 5px 0;
width: 100%;
border-radius: 6px;
-ms-touch-action: none;
touch-action: none;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very nice - we have the diffs in here

box-sizing: border-box;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
}
Expand All@@ -16,6 +18,7 @@
width: 100%;
background-color: #e9e9e9;
height: 4px;
border-radius: 6px;
}
.rc-slider-track {
position: absolute;
Expand All@@ -31,16 +34,27 @@
width: 14px;
height: 14px;
cursor: pointer;
cursor: -webkit-grab;
cursor: grab;
border-radius: 50%;
border: solid 2px #96dbfa;
background-color: #fff;
-ms-touch-action: pan-x;
touch-action: pan-x;
}
.rc-slider-handle:hover {
border-color: #57c5f7;
}
.rc-slider-handle-active:active {
.rc-slider-handle:active {
border-color: #57c5f7;
box-shadow: 0 0 5px #57c5f7;
cursor: -webkit-grabbing;
cursor: grabbing;
}
.rc-slider-handle:focus {
border-color: #57c5f7;
box-shadow: 0 0 0 5px #96dbfa;
outline: none;
}
.rc-slider-mark {
position: absolute;
Expand DownExpand Up@@ -78,12 +92,6 @@
border-radius: 50%;
vertical-align: middle;
}
.rc-slider-dot:first-child {
margin-left: -4px;
}
.rc-slider-dot:last-child {
margin-left: -4px;
}
.rc-slider-dot-active {
border-color: #96dbfa;
}
Expand All@@ -96,6 +104,7 @@
.rc-slider-disabled .rc-slider-handle,
.rc-slider-disabled .rc-slider-dot {
border-color: #ccc;
box-shadow: none;
background-color: #fff;
cursor: not-allowed;
}
Expand All@@ -120,6 +129,8 @@
.rc-slider-vertical .rc-slider-handle {
margin-left: -5px;
margin-bottom: -7px;
-ms-touch-action: pan-y;
touch-action: pan-y;
}
.rc-slider-vertical .rc-slider-mark {
top: 0;
Expand Down
Loading