Uh oh!
There was an error while loading. Please reload this page.
Check if figure has 'data' member set - #224
Conversation
chriddyp
commented
Jul 2, 2018
💃 |
valentijnnieman
commented
Jul 2, 2018
The tests keep failing on CircleCI (but work locally) and I'm having no luck debugging it! |
valentijnnieman
commented
Jul 9, 2018
@T4rk1n Do you have any idea why these tests are failing on CircleCI? You mentioned something about tests last friday, so I thought maybe you know what's going on here :-) |
Looks good to me apart from the failing test. @valentijnnieman The test work locally. I think the |
T4rk1n
commented
Jul 9, 2018
There's something strange with the test, I tried to change the find element method and add more delay, but it can never find it. |
@T4rk1n Yeah, I couldn't figure it out either. Thanks for trying though! |
| ## [0.23.1] | ||
| ### Fixed | ||
| - Fixed bug where Graph wouldn't render if figure.data wasn't set (#223) |
There was a problem hiding this comment.
Similarly here - let's use the full link to the issue #223
| self.startServer(app=app) | ||
| graph_rendered = WebDriverWait(self.driver, 10).until( |
There was a problem hiding this comment.
Have you tried bumping this up to like, 20?
There was a problem hiding this comment.
Yes, didn't change, should put a percy snapshot before the wait so we can see if the graph is actually there.
chriddyp
commented
Jul 24, 2018
Maybe lets try rebasing and seeing if the circle issue is fixed? |
valentijnnieman
commented
Sep 6, 2018
This was fixed in #285, closing this. |
This fixes the bug described in #223