Update circle.

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃

[T4rk1n]

Update the config of circleci to version 2

• Removed tox
• Build with Builder was failing, added the configs of dash-component-boilerplate.
• There is nothing but the tests to pylint, and they fail with really low score, so Pylint is out for now.

The test_link_scroll

dash-core-components/test/test_integration.py

Lines 604 to 616 in a727cde

	defdisplay_page(pathname):
	call_count.value=call_count.value+1
	return'You are on page {}'.format(pathname)
	self.startServer(app=app)
	time.sleep(2)
	#callback is called twice when defined
	self.assertEqual(
	call_count.value,
	2
	)

is somewhat brittle and sometimes fails.

[valentijnnieman]

@Marc-Andre-Rivet Could you perhaps review this if you have time? I think you know this stuff pretty well!

[Marc-Andre-Rivet]

Not aware of this syntax '&test-template', you use it to refer to this job configuration for python36 and 37 so you can just override what you need?

[T4rk1n]

Yes, I took that from plotly/dash#222.

[Marc-Andre-Rivet]

Not important, but you can do 'npm test' instead

[Marc-Andre-Rivet]

I find it weird that test is used to fix linting errors. Should probably be a script of its own like 'fixlint', 'lint.fix' or something along those lines.
You should be able to call 'eslint --fix src' directly instead too, same for builder above.

I would expect eslint to be in the list of dependencies if we are calling it in our scripts. We should not trust babel-eslint to pull it along.

[Marc-Andre-Rivet]

Do we have a shrinkwrap or package-lock file for this project? If we do not we should, as it makes the version of the dependencies downloaded by our users more predictable and saves us from weird compatibility issues that may arise from various technically-compatible but not identical versions.

[valentijnnieman]

What's the reason for this new webpack.config.js file? The webpack config stuff for the components is in ./config/webpack/, won't it be confusing to have 2 config files for webpack?

[T4rk1n]

The old configs were for webpack 3, this is for webpack 4.

[valentijnnieman]

@T4rk1n Maybe it's a good idea to update the .eslintrc file too while we're at it? In #274 I've used the settings taken from plotly/streambed, maybe we can do that here too? What do you think?

[T4rk1n]

@valentijnnieman Yes we should add the prettier here, Its in the list plotly/dash#328

[valentijnnieman]

@T4rk1nCool! You could try merging in the #274 branch if you want! something went wrong with that branch, I pulled from it in another branch, deleted it, and merged that branch which caused #274 to be merged as well. My mistake!

[T4rk1n]

@valentijnnieman I have added prettier and fixed the errors it was reporting, for the tabs file I put a eslint-disable at the top because it was reporting a bunch of prop types error for the EnhancedTab. Please review.

[valentijnnieman]

@T4rk1n Oh yeah <EnhancedTab/> isn't using propTypes. I'll fix that later. Nice work! 💃

[chriddyp]

💃