This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333

Merged
T4rk1n merged 6 commits into from
Oct 17, 2018
Merged

Fix nested data for the Store component. #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4c3435
Recursive data check for arrays and objects.
T4rk1n Oct 16, 2018
e0d6af9
Fix store test indent.
T4rk1n Oct 16, 2018
9a63cf4
Add store nested data test.
T4rk1n Oct 16, 2018
141a94c
pin urllib3 to <=1.22
T4rk1n Oct 16, 2018
455d1b0
Fix tests for python 3, plotly/dash#396
T4rk1n Oct 16, 2018
5d81fb7
Update version, changelog and bundles.
T4rk1n Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down
2 changes: 1 addition & 1 deletion dash_core_components/dash_core_components.dev.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_core_components/dash_core_components.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dash_core_components/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-core-components",
"version": "0.33.0",
"version": "0.33.1",
"description": "Core component suite for Dash",
"repository": {
"type": "git",
Expand All@@ -19,7 +19,7 @@
"uninstall-local": "pip uninstall dash-core-components -y",
"build:js": "webpack --mode production",
"build:js-dev": "webpack --mode development",
"build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
"build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
"build:all": "npm run build:js && npm run build:py",
"build:all-dev": "npm run build:js-dev && npm run build:py",
"build:watch": "watch 'npm run build:all' src"
Expand Down
2 changes: 1 addition & 1 deletion dash_core_components/version.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-core-components",
"version": "0.33.0",
"version": "0.33.1",
"description": "Core component suite for Dash",
"repository": {
"type": "git",
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down
4 changes: 2 additions & 2 deletions src/components/Store.react.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
return true;
}
for (let i = 0; i < data.length; i++) {
if (data[i] !== old[i]) {
if (dataCheck(data[i], old[i])) {
return true;
}
}
} else if (R.contains(type, ['String', 'Number'])) {
return old !== data;
} else if (type === 'Object') {
return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
}
return false;
}
Expand Down
57 changes: 52 additions & 5 deletions test/test_integration.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

app.layout = html.Div([
dcc.Store(id='storage',
storage_type='local'),
storage_type='local'),
html.Button('click me', id='btn'),
html.Button('clear', id='clear-btn'),
html.Button('set-init-storage',
id='set-init-storage'),
dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
storage_type='session',
data=dummy_data),
dcc.Store(id='memory',
storage_type='memory'),
storage_type='memory'),
html.Div(id='memory-output'),
dcc.Store(id='initial-storage',
storage_type='session'),
storage_type='session'),
html.Div(id='init-output')
])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
self.assertEqual('initialized', init.get('data'))

def test_store_nested_data(self):
app = dash.Dash(__name__)

nested = {'nested': {'nest': 'much'}}
nested_list = dict(my_list=[1, 2, 3])

app.layout = html.Div([
dcc.Store(id='store', storage_type='local'),
html.Button('set object as key', id='obj-btn'),
html.Button('set list as key', id='list-btn'),
html.Output(id='output')
])

@app.callback(Output('store', 'data'),
[Input('obj-btn', 'n_clicks_timestamp'),
Input('list-btn', 'n_clicks_timestamp')])
def on_obj_click(obj_ts, list_ts):
if obj_ts is None and list_ts is None:
raise PreventUpdate

# python 3 got the default props bug. plotly/dash#396
if (obj_ts and not list_ts) or obj_ts > list_ts:
return nested
else:
return nested_list

@app.callback(Output('output', 'children'),
[Input('store', 'modified_timestamp')],
[State('store', 'data')])
def on_ts(ts, data):
if ts is None:
raise PreventUpdate
return json.dumps(data)

self.startServer(app)

obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
list_btn = self.wait_for_element_by_css_selector('#list-btn')

obj_btn.click()
time.sleep(3)
self.wait_for_text_to_equal('#output', json.dumps(nested))
# it would of crashed the app before adding the recursive check.

list_btn.click()
time.sleep(3)
self.wait_for_text_to_equal('#output', json.dumps(nested_list))
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix nested data for the Store component.#333
 Merged

T4rk1n
merged 6 commits into

from

Oct 17, 2018
 Merged


Fix nested data for the Store component.
#333
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
d4c3435

Recursive data check for arrays and objects.


T4rk1n Oct 16, 2018
e0d6af9

Fix store test indent.


T4rk1n Oct 16, 2018
9a63cf4

Add store nested data test.


T4rk1n Oct 16, 2018
141a94c

pin urllib3 to <=1.22


T4rk1n Oct 16, 2018
455d1b0

Fix tests for python 3, plotly/dash#396


T4rk1n Oct 16, 2018
5d81fb7

Update version, changelog and bundles.


T4rk1n Oct 17, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
# Change Log for dash-core-components
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.33.1] -- 2018-10-17
### Fixed
- Fix Store component nested data [#333](https://github.com/plotly/dash-core-components/pull/333)

## [0.33.0] -- 2018-10-04
### Added

Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.dev.js

View file


Open in desktop


Large diffs are not rendered by default.


2 changes: 1 addition & 1 deletion
dash_core_components/dash_core_components.min.js

View file


Open in desktop


Large diffs are not rendered by default.


4 changes: 2 additions & 2 deletions
dash_core_components/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand All@@ -19,7 +19,7 @@
 "uninstall-local": "pip uninstall dash-core-components -y",
 "build:js": "webpack --mode production",
 "build:js-dev": "webpack --mode development",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && cp package.json dash_core_components && npm run generate-python-classes",
 "build:py": "node ./extract-meta src/components > dash_core_components/metadata.json && copyfiles package.json dash_core_components && npm run generate-python-classes",
 "build:all": "npm run build:js && npm run build:py",
 "build:all-dev": "npm run build:js-dev && npm run build:py",
 "build:watch": "watch 'npm run build:all' src"
Expand Down

2 changes: 1 addition & 1 deletion
dash_core_components/version.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.33.0'
__version__ = '0.33.1'

2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "dash-core-components",
 "version": "0.33.0",
 "version": "0.33.1",
 "description": "Core component suite for Dash",
 "repository": {
 "type": "git",
Expand Down

1 change: 1 addition & 0 deletions
requirements-dev.txt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,6 +8,7 @@ tox
tox-pyenv
six
plotly>=2.0.8
urllib3<=1.22
requests[security]
ipdb
dash-table-experiments
Expand Down

4 changes: 2 additions & 2 deletions
src/components/Store.react.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,14 +13,14 @@ function dataCheck(data, old) {
 return true;
 }
 for (let i = 0; i < data.length; i++) {
 if (data[i] !== old[i]) {
 if (dataCheck(data[i], old[i])) {
 return true;
 }
 }
 } else if (R.contains(type, ['String', 'Number'])) {
 return old !== data;
 } else if (type === 'Object') {
 return R.any(([k, v]) => old[k] !== v)(Object.entries(data));
 return R.any(([k, v]) => dataCheck(v, old[k]))(Object.entries(data));
 }
 return false;
}
Expand Down

57 changes: 52 additions & 5 deletions
test/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1173,19 +1173,19 @@ def test_storage_component(self):

 app.layout = html.Div([
 dcc.Store(id='storage',
storage_type='local'),
 storage_type='local'),
 html.Button('click me', id='btn'),
 html.Button('clear', id='clear-btn'),
 html.Button('set-init-storage',
 id='set-init-storage'),
 dcc.Store(id='dummy',
storage_type='session',
data=dummy_data),
 storage_type='session',
 data=dummy_data),
 dcc.Store(id='memory',
storage_type='memory'),
 storage_type='memory'),
 html.Div(id='memory-output'),
 dcc.Store(id='initial-storage',
storage_type='session'),
 storage_type='session'),
 html.Div(id='init-output')
 ])

Expand DownExpand Up@@ -1269,3 +1269,50 @@ def init_output(ts, data):
 self.assertAlmostEqual(ts, init.get('ts'), delta=1000)
 self.assertEqual('initialized', init.get('data'))

 def test_store_nested_data(self):
 app = dash.Dash(__name__)

 nested = {'nested': {'nest': 'much'}}
 nested_list = dict(my_list=[1, 2, 3])

 app.layout = html.Div([
 dcc.Store(id='store', storage_type='local'),
 html.Button('set object as key', id='obj-btn'),
 html.Button('set list as key', id='list-btn'),
 html.Output(id='output')
 ])

 @app.callback(Output('store', 'data'),
 [Input('obj-btn', 'n_clicks_timestamp'),
 Input('list-btn', 'n_clicks_timestamp')])
 def on_obj_click(obj_ts, list_ts):
 if obj_ts is None and list_ts is None:
 raise PreventUpdate

 # python 3 got the default props bug. plotly/dash#396
 if (obj_ts and not list_ts) or obj_ts > list_ts:
 return nested
 else:
 return nested_list

 @app.callback(Output('output', 'children'),
 [Input('store', 'modified_timestamp')],
 [State('store', 'data')])
 def on_ts(ts, data):
 if ts is None:
 raise PreventUpdate
 return json.dumps(data)

 self.startServer(app)

 obj_btn = self.wait_for_element_by_css_selector('#obj-btn')
 list_btn = self.wait_for_element_by_css_selector('#list-btn')

 obj_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested))
 # it would of crashed the app before adding the recursive check.

 list_btn.click()
 time.sleep(3)
 self.wait_for_text_to_equal('#output', json.dumps(nested_list))