Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 140
Issue 404 - Add source map to package#410
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "dash-core-components", | ||
| "version": "0.40.2", | ||
| "version": "0.40.3", | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bump version | ||
| "description": "Core component suite for Dash", | ||
| "repository": { | ||
| "type": "git", | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = '0.40.2' | ||
| __version__ = '0.40.3' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -32,9 +32,7 @@ module.exports = (env, argv) => { | ||
| const entry = overrides.entry || {main: './src/index.js'}; | ||
| const devtool = overrides.devtool || ( | ||
| mode === 'development' ? "eval-source-map" : 'none' | ||
| ); | ||
| const devtool = overrides.devtool || 'source-map'; | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default to source-map now -- this causes the dev bundle to increase dramatically in number of lines, even if it is smaller now -- same issue as with plotly/dash-renderer#105 (comment) | ||
| const externals = ('externals' in overrides) ? overrides.externals : ({ | ||
| react: 'React', | ||
| @@ -51,6 +49,7 @@ module.exports = (env, argv) => { | ||
| library: dashLibraryName, | ||
| libraryTarget: 'window', | ||
| }, | ||
| devtool, | ||
| externals, | ||
| module: { | ||
| rules: [ | ||
| @@ -76,7 +75,6 @@ module.exports = (env, argv) => { | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| devtool | ||
| } | ||
| } | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose the map files, make them dynamic