Update R dashCoreComponents package to 0.43.0 by rpkyle · Pull Request #439 · plotly/dash-core-components

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

rpkyle · 2019-01-18T22:59:56Z

The JSON >> R 'transpiler' has been rewritten in Python, and was used to generate an installable R package for version 0.43.0 of dash-core-components. This PR closes#357.

@alexcjohnson @nicolaskruchten @T4rk1n @Marc-Andre-Rivet

alexcjohnson · 2019-01-19T00:10:48Z

 args = {k: _locals[k] for k in _explicit_args if k != 'children'}

- for k in ['id']:
+ for k in [u'id']:


Where did this u (and in Store below) come from? Is this intentional, or a result of running the build script in py2 instead of py3?

I just re-ran the component generation in a virtualenv with Python 3, and it seems probable; the output is as before (rather than [u'id']).

Just to wrap this up, the crux of the difference is that Python 3 does away with unicode and str is essentially unicode by default; in Python 2, importing via json.load will return Unicode strings. There are workarounds, and the one I've chosen to use is Mark Amery's byteify function.

T4rk1n

Found a few minor issues with the new generation formatting, can open an issue for that and fix later.

T4rk1n · 2019-01-25T19:50:07Z

- "Upload"
+ "Tabs",
+ "Slider"
 ]


Generated without newline.

T4rk1n · 2019-01-25T19:51:11Z

- },
- {
- "name": "handleInterval",
-


Regenerated without indentation.

T4rk1n · 2019-01-25T19:54:36Z

+ component$props <- filter_null(component$props)
+
+ structure(component, class = c('dash_component', 'list')) 
+}


Generated without newline at end of file.

The newline isn't required for R scripts.

I don't think newline is required for any language we use, yet in some cases we actually set our linters to force it. Why?
It's sometimes useful on the command line (otherwise if you cat a file for some reason you'll find your next prompt at the end of the last line of the file, rather than on a new line)
In some editors, the last line may get intermittently covered up by a horizontal scroll bar
Github adds 🚫in diffs and nobody wants to annoy Github!
I don't see this as a big deal (unless you have anything to add to this list @T4rk1n), but it's mildly nice and - unless there's a good reason not to - probably easier to just add the newline than to argue about it 😅

No, it's not really important, just a pet peeves.

Good points, easy to modify the transpiler to add in the newlines next time around!

T4rk1n

The props order of python component shouldn't change.

rpkyle · 2019-01-28T17:26:30Z

Building dashCoreComponents for R failed using the latest version of dash (0.36.0) with the following error:

Error with path src/components/Textarea.react.jsTypeError: Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at checkWarn (dash/dash/extract-meta.js:45:15)
at Object.entries.forEach (dash/dash/extract-meta.js:54:24)
at Array.forEach (<anonymous>)
at docstringWarning (dash/dash/extract-meta.js:53:31)
at parseFile (dash/dash/extract-meta.js:70:9)
at dirs.forEach.filename (dash/dash/extract-meta.js:92:17)
at Array.forEach (<anonymous>)
at collectMetadataRecursively (dash/dash/extract-meta.js:87:14)
at componentPaths.forEach.componentPath (dash/dash/extract-meta.js:21:5)
at Array.forEach (<anonymous>)

The inclusion of debounce in the TextArea component appears to be some 🍝. I have 🔪 it, and the TypeError no longer occurs.

The issue was apparent in the generation of the Python class for this component, as there was no property corresponding to this argument.

rpkyle · 2019-01-29T10:31:32Z

The props order for python component shouldn't change.

@T4rk1n If you could look over the recent commit, that'd be great. Hopefully we're nearing 💃.

T4rk1n

💃

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

updated R package after applying fixes
87c3e70

rpkyle requested review from Marc-Andre-Rivet, alexcjohnson and rmarren1 January 18, 2019 22:59

rpkyle self-assigned this Jan 18, 2019

This was referenced Jan 18, 2019
Update R dashCoreComponents package to 0.42.1 #411
Closed
R version of Core components #357
Closed

alexcjohnson reviewed Jan 19, 2019
View reviewed changes

updated package and rebuilt
86d1b70

T4rk1n reviewed Jan 25, 2019
View reviewed changes

Ryan Patrick Kyle added 2 commits January 26, 2019 04:12

Merge branch 'master' into 0.42.2-issue34
6ee8b2c

updated R components and online help
750be9f

T4rk1n suggested changes Jan 28, 2019
View reviewed changes

Ryan Patrick Kyle added 8 commits January 28, 2019 12:28

removed apparent debounce 🍝
458e886

modified build:py syntax to use dash-generate-components
1bd0a3e

🔪 generate-python-classes
3887ff4

✨ added build:r option to package.json
e788601

added 🪲 URL and homepage URL to package.json
23abedd

⬆️ updated plotly JS
033ab0f

📚 added overall package documentation for dHC + dCC
0dd6e5b

📦 for R updated
76e0d47

rpkyle changed the title ~~Update R dashCoreComponents package to 0.42.2~~Update R dashCoreComponents package to 0.43.1Jan 29, 2019

rpkyle mentioned this pull request Jan 29, 2019
Fixes to address unintended props reshuffling behaviour plotly/dash#545
Merged

T4rk1n approved these changes Jan 29, 2019
View reviewed changes

rpkyle changed the title ~~Update R dashCoreComponents package to 0.43.1~~Update R dashCoreComponents package to 0.43.0Jan 29, 2019

Merge branch 'master' into 0.42.2-issue34
5ca9fb9

rpkyle merged commit 51ab115 into masterJan 29, 2019

alexcjohnson deleted the 0.42.2-issue34 branch January 29, 2019 19:46

Uh oh!

Uh oh!

Conversation

rpkyle commented Jan 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

T4rk1n left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

T4rk1n left a comment

Choose a reason for hiding this comment

Uh oh!

rpkyle commented Jan 28, 2019

Uh oh!

rpkyle commented Jan 29, 2019

Uh oh!

T4rk1n left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

rpkyle commented Jan 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

T4rk1n left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

T4rk1n left a comment

Choose a reason for hiding this comment

Uh oh!

rpkyle commented Jan 28, 2019

rpkyle commented Jan 18, 2019•
edited
Loading

rpkyle commented Jan 18, 2019•
edited
Loading

rpkyle commented Jan 18, 2019•
edited
Loading