Uh oh!
There was an error while loading. Please reload this page.
Rework dash-renderer setProps - #478
Conversation
…0rc1 # Conflicts: # dev-requirements.txt
…0rc1 # Conflicts: # dash_core_components/package.json # dash_core_components/version.py # dev-requirements.txt # package.json
| "prettier": "^1.14.2", | ||
| "react": "^16.6.1", | ||
| "react-dom": "^16.6.1", | ||
| "react-dot-fragment": "^0.2.8", |
There was a problem hiding this comment.
React 16 <Fragment /> polyfill -- gets rid of the wrapper <div /> and allows the same behavior as before -- the extra div could break existing styles or make styling more difficult
| if (setProps) { | ||
| setProps(update); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Like before, inserting onClick prop for the real child to use
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| test('Tab can be clicked and will display its content', () => { | ||
| tabs.find('[value="tab-2"]').simulate('click'); | ||
| const renderedContent = tabs.find('.tab-content > div').html(); | ||
| const renderedContent = tabs.find(Tab).html(); |
There was a problem hiding this comment.
Checking for the Tab component instead of some arbitrary selector
| test('Tab without value will still be clickable', () => { | ||
| tabs.find('[value="tab-2"]').simulate('click'); | ||
| const renderedContent = tabs.find('.tab-content > div').html(); | ||
| const renderedContent = tabs.find(Tab).html(); |
There was a problem hiding this comment.
This test makes no sense. It's the exact copy of the one above with a different name. It's clearly not testing that case.. removing.
| }); | ||
| test('Tab without value will still be clickable', () => { | ||
| tabs.find('[value="tab-2"]').simulate('click'); | ||
| const renderedContent = tabs.find('.tab-content > div').html(); |
There was a problem hiding this comment.
This test is an exact copy of the test above. Looks like copy-paste that was never modified. Removing.
No description provided.