') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Issue 691 - Update plotlyjs by Marc-Andre-Rivet · Pull Request #693 · plotly/dash-core-components · GitHub
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 691 - Update plotlyjs - #693

Merged
Marc-Andre-Rivet merged 4 commits into
devfrom
691-plotlyjs
Nov 4, 2019
Merged

Issue 691 - Update plotlyjs#693
Marc-Andre-Rivet merged 4 commits into
devfrom
691-plotlyjs

Conversation

@Marc-Andre-Rivet

@Marc-Andre-RivetMarc-Andre-Rivet commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Fixes#691

Marc-Andre-Rivet
Marc-Andre-Rivet commented Nov 4, 2019
View reviewed changes
Comment threadtests/integration/calendar/test_date_picker_single.py
amnesiaed = dash_dcc.select_date_single(
"dps-none", day="1", outside_month=True
)
amnesiaed = dash_dcc.select_date_single("dps-none", day="11")

@Marc-Andre-RivetMarc-Andre-RivetNov 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting month rollover bug in this test. November 2019 ends on a Saturday, there is no 1st day of next month in this calendar! This is the only instance where we are checking for "out-of-month" days in dcc tests. Out-of-month is not important here as we are really just testing persistence.

image

@Marc-Andre-RivetMarc-Andre-RivetNov 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny enough, https://github.com/plotly/dash-core-components/pull/692/commits was not affected even with the last commit happening in November b/c the test does -timedelta(days=1)

@Marc-Andre-Rivet
Marc-Andre-Rivet marked this pull request as ready for review November 4, 2019 18:02
@Marc-Andre-RivetMarc-Andre-Rivet mentioned this pull request Nov 4, 2019
Merged
2 tasks
Marc-Andre-Rivet
Marc-Andre-Rivet commented Nov 4, 2019
View reviewed changes
Comment threadCHANGELOG.md
alexcjohnson
alexcjohnson approved these changes Nov 4, 2019
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@Marc-Andre-Rivet@alexcjohnson
Update CHANGELOG.md
7dd46e6
Co-Authored-By: alexcjohnson <johnson.alex.c@gmail.com>
@Marc-Andre-Rivet
Marc-Andre-Rivet merged commit 10aa10e into devNov 4, 2019
@Marc-Andre-Rivet
Marc-Andre-Rivet deleted the 691-plotlyjs branch November 4, 2019 19:13
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@byronzbyronzAwaiting requested review from byronz
1 more reviewer
@alexcjohnsonalexcjohnsonalexcjohnson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade plotly.js to 1.51.1

2 participants

@Marc-Andre-Rivet@alexcjohnson