This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d1505e8
First stab at adding drag_value to Slider
almarklein Nov 17, 2020
704a844
Make an initial fire of drag_value with the value of 'value'
almarklein Dec 1, 2020
e74b519
update updatemode docs
almarklein Dec 1, 2020
cbd7d22
Implement drag_value for RangeSlider
almarklein Dec 2, 2020
04dfd98
lint
almarklein Dec 2, 2020
c7adc18
Update src/components/Slider.react.js
almarklein Dec 3, 2020
f67f75c
add tests for slider
almarklein Dec 10, 2020
fa6379f
Merge branch 'drag_value2' of github.com:almarklein/dash-core-compone…
almarklein Dec 10, 2020
4763f78
lint and add missing import
almarklein Dec 10, 2020
966f227
black?
almarklein Dec 10, 2020
4d0a3e2
fix test, hopefully
almarklein Dec 10, 2020
a0740c2
fix test
almarklein Dec 10, 2020
7ddd835
fix test
almarklein Dec 10, 2020
b9c72c4
fix test?
almarklein Dec 10, 2020
0799af5
fix?
almarklein Dec 10, 2020
1be148f
use exact same code as other example. Im running out of ideas
almarklein Dec 10, 2020
b3ccc08
bring test down to minimum
almarklein Dec 10, 2020
24600cf
also include output for value
almarklein Dec 10, 2020
82c8763
refactor slicer implementation a bit
almarklein Dec 11, 2020
4c19122
change test and tweak code
almarklein Dec 11, 2020
773c881
maybe only the initialization fails?
almarklein Dec 11, 2020
65a1ba0
Merge branch 'dev' into drag_value2
Marc-Andre-Rivet Dec 11, 2020
1322548
update rangeslider and add a test for it
almarklein Dec 11, 2020
6c9bcda
verify that `value` only changes on mouseup while `drag_value` change…
alexcjohnson Dec 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/components/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,11 @@ RangeSlider.propTypes = {
*/
value: PropTypes.arrayOf(PropTypes.number),

/**
* The value of the input during a drag
*/
drag_value: PropTypes.arrayOf(PropTypes.number),

/**
* allowCross could be set as true to allow those handles to cross.
*/
Expand DownExpand Up@@ -145,18 +150,18 @@ RangeSlider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* Note that for the latter case, the `drag_value`
* property could be used instead.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
22 changes: 14 additions & 8 deletions src/components/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,11 @@ Slider.propTypes = {
*/
value: PropTypes.number,

/**
* The value of the input during a drag
*/
drag_value: PropTypes.number,

/**
* Additional CSS class for the root DOM node
*/
Expand DownExpand Up@@ -125,18 +130,19 @@ Slider.propTypes = {
verticalHeight: PropTypes.number,

/**
* Determines when the component should update
* its value. If `mouseup`, then the slider
* will only trigger its value when the user has
* finished dragging the slider. If `drag`, then
* the slider will update its value continuously
* as it is being dragged.
* Only use `drag` if your updates are fast.
* Determines when the component should update its `value`
* property. If `mouseup` (the default) then the slider
* will only trigger its value when the user has finished
* dragging the slider. If `drag`, then the slider will
* update its value continuously as it is being dragged.
* If you want different actions during and after drag,
* leave `updatemode` as `mouseup` and use `drag_value`
* for the continuously updating value.
*/
updatemode: PropTypes.oneOf(['mouseup', 'drag']),

/**
* Dash-assigned callback that gets fired when the value changes.
* Dash-assigned callback that gets fired when the value or drag_value changes.
*/
setProps: PropTypes.func,

Expand Down
27 changes: 13 additions & 14 deletions src/fragments/RangeSlider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,20 +10,11 @@ import {propTypes, defaultProps} from '../components/RangeSlider.react';
export default class RangeSlider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(Range)
: Range;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -32,11 +23,17 @@ export default class RangeSlider extends Component {
? createSliderWithTooltip(Range)
: Range;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -84,9 +81,10 @@ export default class RangeSlider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -101,6 +99,7 @@ export default class RangeSlider extends Component {
[
'className',
'value',
'drag_value',
'setProps',
'marks',
'updatemode',
Expand Down
27 changes: 13 additions & 14 deletions src/fragments/Slider.react.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,20 +13,11 @@ import {propTypes, defaultProps} from '../components/Slider.react';
export default class Slider extends Component {
constructor(props) {
super(props);
this.propsToState = this.propsToState.bind(this);
this.DashSlider = props.tooltip
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
this._computeStyle = computeSliderStyle();
this.state = {
value: props.value,
};
}

propsToState(newProps) {
if (newProps.value !== this.props.value) {
this.setState({value: newProps.value});
}
this.state = {value: props.value};
}

UNSAFE_componentWillReceiveProps(newProps) {
Expand All@@ -35,11 +26,17 @@ export default class Slider extends Component {
? createSliderWithTooltip(ReactSlider)
: ReactSlider;
}
this.propsToState(newProps);
if (newProps.value !== this.props.value) {
this.props.setProps({drag_value: newProps.value});
this.setState({value: newProps.value});
}
}

UNSAFE_componentWillMount() {
this.propsToState(this.props);
if (this.props.value !== null) {
this.props.setProps({drag_value: this.props.value});
this.setState({value: this.props.value});
}
}

render() {
Expand DownExpand Up@@ -87,9 +84,10 @@ export default class Slider extends Component {
<this.DashSlider
onChange={value => {
if (updatemode === 'drag') {
setProps({value});
setProps({value: value, drag_value: value});
} else {
this.setState({value});
this.setState({value: value});
setProps({drag_value: value});
}
}}
onAfterChange={value => {
Expand All@@ -114,6 +112,7 @@ export default class Slider extends Component {
'setProps',
'updatemode',
'value',
'drag_value',
'marks',
'verticalHeight',
],
Expand Down
18 changes: 18 additions & 0 deletions tests/dash_core_components_page.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.common.action_chains import ActionChains

logger = logging.getLogger(__name__)

Expand DownExpand Up@@ -100,3 +101,20 @@ def _wait_until_day_is_clickable(self, timeout=1):
@property
def date_picker_day_locator(self):
return 'div[data-visible="true"] td.CalendarDay'

def click_and_hold_at_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).click_and_hold().perform()

def move_to_coord_fractions(self, elem_or_selector, fx, fy):
elem = self._get_element(elem_or_selector)

ActionChains(self.driver).move_to_element_with_offset(
elem, elem.size["width"] * fx, elem.size["height"] * fy
).perform()

def release(self):
ActionChains(self.driver).release().perform()
81 changes: 81 additions & 0 deletions tests/integration/sliders/test_sliders.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -160,3 +160,84 @@ def test_slsl005_slider_tooltip(dash_dcc):
dash_dcc.percy_snapshot(
"slider-make sure tooltips are only visible if parent slider is visible"
)


def test_slsl006_drag_value_slider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.Slider(
id="slider",
min=0,
max=20,
step=1,
value=5,
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
return "You have dragged {}".format(value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}".format(value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.75, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 15")
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10")


def test_slsl007_drag_value_rangeslider(dash_dcc):
app = dash.Dash(__name__)
app.layout = html.Div(
[
dcc.RangeSlider(
id="slider",
min=0,
max=20,
step=1,
value=(5, 15),
tooltip={"always_visible": True},
),
html.Div(id="out-value"),
html.Div(id="out-drag-value"),
]
)

@app.callback(Output("out-drag-value", "children"), [Input("slider", "drag_value")])
def update_output(value):
value = value or (None, None)
return "You have dragged {}-{}".format(*value)

@app.callback(Output("out-value", "children"), [Input("slider", "value")])
def update_output(value):
return "You have selected {}-{}".format(*value)

dash_dcc.start_server(app)
slider = dash_dcc.find_element("#slider")

dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5-15")

dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)
dash_dcc.move_to_coord_fractions(slider, 0.5, 0.25)
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 10-15")
Comment thread
alexcjohnson marked this conversation as resolved.
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5-15")
dash_dcc.release()
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 10-15")