Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 140
Update toolchain#939
Uh oh!
There was an error while loading. Please reload this page.
Update toolchain #939
Changes from all commits
727a2abf9473df0a996efe8d45f105c55312f8253eb9e1e5b39b10211a7f98aca2388b670c60afd06f7755269716c37bef8b96292aa995478a8a94686c5a05e9c50167e520596609e7c3442c2e94ada70cc49e550da9efa119928ea808884e1d6d6617cbc6d964da7768fecefade97e2904acca40b33ec1d72c0269a5431db3772675fb21855a486c420e08cfbcae14ad29d46377d3a157946881babbce14a0e1e8469d131ea6e86d69b3ca0a5f054a1dbbe49a84e8ff15988df4c77e044aac1e59f56c55178392609024e55021763a535bdeb7d677df5ac657a519bf3af946f98d617eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -9,15 +9,15 @@ jobs: | ||
| steps: | ||
| - run: percy finalize --all | ||
| lint-unit-37: &lint-unit | ||
| lint-unit-39: &lint-unit | ||
| working_directory: ~/project | ||
| docker: | ||
| - image: circleci/python:3.7.9-stretch-node-browsers | ||
| - image: circleci/python:3.9.2-buster-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| environment: | ||
| PYTHON_VERSION: py37 | ||
| PYTHON_VERSION: py39 | ||
| steps: | ||
| - checkout | ||
| - run: echo $PYTHON_VERSION > ver.txt | ||
| @@ -28,7 +28,7 @@ jobs: | ||
| command: | | ||
| sudo pip install virtualenv --upgrade | ||
| python -m venv venv || virtualenv venv && . venv/bin/activate | ||
| pip install --progress-bar off -e git+https://github.com/plotly/dash.git@dev#egg=dash[dev,testing] | ||
| pip install --progress-bar off -e git+https://github.com/plotly/dash.git@deps-update-20210628#egg=dash[dev,testing] | ||
| pip install --progress-bar off --no-cache-dir -r dev-requirements.txt | ||
| - save_cache: | ||
| key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "dev-requirements.txt" }} | ||
| @@ -41,16 +41,11 @@ jobs: | ||
| set -eo pipefail | ||
| npm ci | ||
| npm run lint | ||
| - run: | ||
| name: 🔎 Unit Tests | ||
| command: | | ||
| set -eo pipefail | ||
| npm run test-unit | ||
| lint-unit-36: | ||
| <<: *lint-unit | ||
| docker: | ||
| - image: circleci/python:3.6.12-stretch-node-browsers | ||
| - image: circleci/python:3.6.13-stretch-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| @@ -67,15 +62,15 @@ jobs: | ||
| environment: | ||
| PYTHON_VERSION: py27 | ||
| build-dash-37: &build-dash | ||
| build-dash-39: &build-dash | ||
| working_directory: ~/project | ||
| docker: | ||
| - image: circleci/python:3.7.9-stretch-node-browsers | ||
| - image: circleci/python:3.9.2-buster-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| environment: | ||
| PYTHON_VERSION: py37 | ||
| PYTHON_VERSION: py39 | ||
| steps: | ||
| - checkout | ||
| - run: echo $PYTHON_VERSION > ver.txt | ||
| @@ -115,7 +110,7 @@ jobs: | ||
| build-dash-36: | ||
| <<: *build-dash | ||
| docker: | ||
| - image: circleci/python:3.6.12-stretch-node-browsers | ||
| - image: circleci/python:3.6.13-stretch-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| @@ -132,16 +127,17 @@ jobs: | ||
| environment: | ||
| PYTHON_VERSION: py27 | ||
| test-37: &test | ||
| test-39: &test | ||
| working_directory: ~/project | ||
| docker: | ||
| - image: circleci/python:3.7.9-stretch-node-browsers | ||
| - image: circleci/python:3.9.2-buster-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| environment: | ||
| PYTHON_VERSION: py37 | ||
| PYTHON_VERSION: py39 | ||
| PERCY_PARALLEL_TOTAL: -1 | ||
| PERCY_ENABLE: 1 | ||
| parallelism: 3 | ||
| steps: | ||
| - checkout | ||
| @@ -159,6 +155,7 @@ jobs: | ||
| find . -name "dash_*.gz" | xargs pip install -I --progress-bar off --no-cache-dir | ||
| pip install --no-cache-dir --progress-bar off main.tar.gz[dev,testing] | ||
| pip list | grep dash | xargs pip show && cd .. | ||
| echo $(python -V 2>&1) | grep 3. && python -m unittest tests/test_dash_import.py | ||
| TESTFILES=$(circleci tests glob "tests/integration/**/test_*.py" | circleci tests split --split-by=timings) | ||
| pytest --headless --nopercyfinalize --junitxml=test-reports/junit_intg.xml ${TESTFILES} | ||
| - store_artifacts: | ||
| @@ -171,7 +168,7 @@ jobs: | ||
| test-36: | ||
| <<: *test | ||
| docker: | ||
| - image: circleci/python:3.6.12-stretch-node-browsers | ||
| - image: circleci/python:3.6.13-stretch-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| @@ -190,80 +187,18 @@ jobs: | ||
| PYTHON_VERSION: py27 | ||
| PERCY_ENABLE: 0 | ||
| test-legacy-37: &test-legacy | ||
| working_directory: ~/project | ||
| docker: | ||
| - image: circleci/python:3.7.9-stretch-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| environment: | ||
| PYTHON_VERSION: py37 | ||
| PERCY_PARALLEL_TOTAL: -1 | ||
| parallelism: 2 | ||
| steps: | ||
| - checkout | ||
| - run: echo $PYTHON_VERSION > ver.txt | ||
| - restore_cache: | ||
| key: dep-{{ checksum ".circleci/config.yml" }}-{{ checksum "ver.txt" }}-{{ checksum "dev-requirements.txt" }} | ||
| - attach_workspace: | ||
| at: ~/project | ||
| - run: | ||
| name: 🧪 Run Legacy Integration Tests | ||
| command: | | ||
| . venv/bin/activate && rm -rf dash_core_components && ls -la | ||
| set -eo pipefail | ||
| cd packages && mv dash-*.tar.gz main.tar.gz && ls -la | ||
| find . -name "dash_*.gz" | xargs pip install -I --progress-bar off --no-cache-dir | ||
| pip install --no-cache-dir --progress-bar off main.tar.gz[dev,testing] | ||
| pip list | grep dash | xargs pip show && cd .. | ||
| echo $(python -V 2>&1) | grep 3. && python -m unittest tests/test_dash_import.py | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only test_dash_import remains and is moved here https://github.com/plotly/dash-core-components/pull/939/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R158 | ||
| TESTFILES=$(circleci tests glob "tests/test_integration_*.py" | circleci tests split --split-by=timings) | ||
| pytest --durations=10 --junitxml=test-reports/junit_legacy.xml ${TESTFILES} | ||
| - store_artifacts: | ||
| path: test-reports | ||
| - store_test_results: | ||
| path: test-reports | ||
| - store_artifacts: | ||
| path: /tmp/dash_artifacts | ||
| test-legacy-36: | ||
| <<: *test-legacy | ||
| docker: | ||
| - image: circleci/python:3.6.12-stretch-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| environment: | ||
| PYTHON_VERSION: py36 | ||
| PERCY_ENABLE: 0 | ||
| test-legacy-27: | ||
| <<: *test-legacy | ||
| docker: | ||
| - image: circleci/python:2.7.18-stretch-node-browsers | ||
| auth: | ||
| username: dashautomation | ||
| password: $DASH_PAT_DOCKERHUB | ||
| environment: | ||
| PYTHON_VERSION: py27 | ||
| PERCY_ENABLE: 0 | ||
| workflows: | ||
| version: 2 | ||
| python3.7: | ||
| python3.9: | ||
| jobs: | ||
| - lint-unit-37 | ||
| - build-dash-37 | ||
| - test-37: | ||
| requires: | ||
| - build-dash-37 | ||
| - test-legacy-37: | ||
| - lint-unit-39 | ||
| - build-dash-39 | ||
| - test-39: | ||
| requires: | ||
| - build-dash-37 | ||
| - build-dash-39 | ||
| - percy-finalize: | ||
| requires: | ||
| - test-37 | ||
| - test-legacy-37 | ||
| - test-39 | ||
| python3.6: | ||
| jobs: | ||
| @@ -272,9 +207,6 @@ workflows: | ||
| - test-36: | ||
| requires: | ||
| - build-dash-36 | ||
| - test-legacy-36: | ||
| requires: | ||
| - build-dash-36 | ||
| python2.7: | ||
| jobs: | ||
| @@ -283,6 +215,3 @@ workflows: | ||
| - test-27: | ||
| requires: | ||
| - build-dash-27 | ||
| - test-legacy-27: | ||
| requires: | ||
| - build-dash-27 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [flake8] | ||
| ignore = C901, E203, E266, E501, E731, W503 | ||
| ignore = C901, E203, E231, E266, E501, E731, W503 | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Black/flake8 disagreement about spaces after trailing comma. Black wins over Flake8, same as in the dash-table. | ||
| select = B,C,E,F,W,T4 | ||
| per-file-ignores = | ||
| tests/*: E722, F811 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -24,5 +24,6 @@ dash_core_components_base/plotly.min.js | ||
| /man | ||
| /R | ||
| /src/*.jl | ||
| /src/jl/ | ||
| DESCRIPTION | ||
| NAMESPACE | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npm run lint |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "arrowParens": "avoid", | ||
| "tabWidth": 4, | ||
| "singleQuote": true, | ||
| "bracketSpacing": false, | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,7 @@ | ||
| include dash_core_components/dash_core_components.min.js | ||
| include dash_core_components/dash_core_components.min.js.map | ||
| include dash_core_components/dash_core_components-shared.js | ||
| include dash_core_components/dash_core_components-shared.js.map | ||
| include dash_core_components/async-*.js | ||
| include dash_core_components/async-*.js.map | ||
| include dash_core_components/*.js | ||
| include dash_core_components/*.js.map | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is consistent with what is being done in other repos and how these deps are published in the npm package. | ||
| include dash_core_components/metadata.json | ||
| include dash_core_components/package-info.json | ||
| include dash_core_components/plotly.min.js | ||
| include README.md | ||
| include LICENSE.txt | ||
| include package.json | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.