Uh oh!
There was an error while loading. Please reload this page.
Make thermometer measurement surface flatter. - #68
Open
shammamah-zz wants to merge 3 commits into
Open
Conversation
alexcjohnson
commented
Oct 16, 2019
Collaborator
Can I see some before/after screenshots? |
shammamah-zz
commented
Oct 16, 2019
ContributorAuthor
@alexcjohnson Just added them to the original comment! |
alexcjohnson
commented
Oct 16, 2019
Collaborator
Thanks! Definitely a big improvement, I just wonder if it needs any radius at all. If it were completely square does it look bad or compromise it in some way? |
shammamah-zz
commented
Oct 16, 2019
ContributorAuthor
Nope, we can make it totally flat. I'll do that right now! |
shammamah-zz
commented
Oct 16, 2019
ContributorAuthor
@alexcjohnson Looks like if you make it totally flat (or with a different border radius), it no longer fits in the thermometer container:
|
Marc-Andre-Rivet
commented
Jan 22, 2020
Contributor
@shammamah Might just need to tweak the container's style so that overflow is hidden. |
Marc-Andre-Rivet
self-requested a review
January 22, 2020 15:10
| ## [Unreleased] | ||
| ### Changed | ||
| * Changed thermometer indicator border radius from 40px to 5px. |
Contributor
There was a problem hiding this comment.
We should start adhering to the convention we use elsewhere: including the PR or issue that introduced the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#64.