Update R package metadata YAML file for 1.0.2

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!

[rpkyle]

The YAML data used for populating title/description/examples should be up to date in the dev branch. This PR will backcommit the updates.

[rpkyle]

@Marc-Andre-Rivet Could we merge this if there are no objections?

[alexcjohnson]

htmlAcronym (and htmlAbbr above) should have their props reversed - children is the short text that's always shown, title is the longer explanation of it. https://www.w3docs.com/learn-html/html-acronym-tag.html

[rpkyle]

Good point, will fix this.

[rpkyle]

fixed in b4e683f

[alexcjohnson]

intended to go in a <table>https://www.w3docs.com/learn-html/html-caption-tag.html

[rpkyle]

fixed in f462bce

[alexcjohnson]

use the htmlSummary example here

[rpkyle]

fixed in 03fabd8

[alexcjohnson]

use the htmlDt example here

[rpkyle]

fixed in 344fbfa

[alexcjohnson]

use the htmlDt example here too

[rpkyle]

fixed in db36bfd

[alexcjohnson]

really? I'd think htmlFrameset should just show a deprecation comment like htmlFrame

[rpkyle]

Sounds good, will fix.

[rpkyle]

fixed in 19551a7

[alexcjohnson]

a little confusing this is a heading (<h1>) inside a header (<header>)

[rpkyle]

Literally taken straight from the MDN example 😆:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header

Will remove the heading tag.

[alexcjohnson]

It's common to put headings in headers, just the way it's shown it makes it look like you're saying the <h1> is the header. Anyway yeah, cleaner for an example to just do htmlHeader("This is a header")

[rpkyle]

fixed in 64a6b68

[alexcjohnson]

should have a deprecation comment

[rpkyle]

fixed in 3ed2ec5

[alexcjohnson]

is this the only one that has a different name from its HTML counterpart (<map>)? we should add a comment about this (and to any others if there are any) so users can find regular HTML documentation about it.

[rpkyle]

fixed in 5caaeda

[alexcjohnson]

then take out the code below, which doesn't use htmlNextid at all?

[rpkyle]

fixed in 5555dff

[alexcjohnson]

I doubt it... probably just wouldn't show up at all. Anyway since it would need js in order to create it, the only reasonable option is to put <noscript> in the index template.

[rpkyle]

I didn't write this example, so I'm not sure. But that makes sense to me.

[rpkyle]

fixed in 46a624c

[alexcjohnson]

ah this one also has a mutated name...

[rpkyle]

fixed in 989ac96

[alexcjohnson]

can we not wrap the strings in htmlP, just "longstring", htmlWbr(), "secondpart"? I don't think it does anything as is.

[rpkyle]

This alternative:

app$layout(
htmlDiv(list(
"In a long string, it might be a good idea to add an htmlWbr to specify word breaks",
"Thisverylongstringwithnowhitespaceswon'tlookverygood",
htmlWbr(),
"butatleastyoucanspecifya'natural'placeforthestringtobebrokenup"
)
)
)

yields

In a long string, it might be a good idea to add an htmlWbr to specify word breaksThisverylongstringwithnowhitespaceswon'tlookverygoodbutatleastyoucanspecifya'natural'placeforthestringtobebrokenup

while the original snippet appears to produce

In a long string, it might be a good idea to add an htmlWbr to specify word breaks
Thisverylongstringwithnowhitespaceswon'tlookverygood
butatleastyoucanspecifya'natural'placeforthestringtobebrokenup

[alexcjohnson]

hmm not worth spending a lot of time on, but if you're already breaking the words into different <p> then what does it matter if you <wbr>? Seems like then it just acts as a <br>. But if I try it in Python using just strings or strings in <span>s:

html.Div([
"a"*100,
"b"*100,
html.Wbr(),
"c"*100,
html.Wbr(),
html.Span("d"*100),
html.Span("e"*100)
])

I get what I expected:

[rpkyle]

Interesting, will merge this now but revisit this example later.

[alexcjohnson]

you need library(dashCoreComponents) for this example

[rpkyle]

fixed in 209a10d

[alexcjohnson]

ideally though I suppose we don't want library(dashCoreComponents) where it's not used... that happens a lot.

[rpkyle]

I agree, and I'm guilty of the same. It was sloppy to not purge those entries from the examples. We can't always live in the ideal world, but it's better to lead by (good) example.

fixed in 137542f

[alexcjohnson]

As discussed on slack, I gave this a more thorough review largely so we can at some point use these code snippets automatically in the dashr.plot.ly docs for the html components.

[alexcjohnson]

💃 thanks for the tweaks!