This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179

Merged
alexcjohnson merged 5 commits into from
Feb 11, 2021
Merged

Add allow prop to html.Iframe #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c49ffe
Add `allow` prop to html.Iframe
ann-marie-ward Feb 6, 2021
116944c
Add `referrerPolicy` prop and update tests
ann-marie-ward Feb 9, 2021
abb2c91
Add `referrerPolicy` prop and update tests
ann-marie-ward Feb 9, 2021
9121acb
Updated changelog Fixes #77
ann-marie-ward Feb 11, 2021
2264cd4
Update CHANGELOG.md
alexcjohnson Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down
6 changes: 3 additions & 3 deletions scripts/extract-attributes.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required',
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down
91 changes: 50 additions & 41 deletions tests/test_integration.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
call_count = Value('i', 0)
call_count = Value("i", 0)

app = dash.Dash(__name__)
app.layout = html.Div([
html.Div(id='container'),
html.Button('Click', id='button', n_clicks=0)
])

@app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
app.layout = html.Div(
[
html.Div(id="container"),
html.Button("Click", id="button", n_clicks=0),
html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
]
)

@app.callback(Output("container", "children"), Input("button", "n_clicks"))
def update_output(n_clicks):
call_count.value += 1
return 'clicked {} times'.format(n_clicks)
return "clicked {} times".format(n_clicks)

dash_duo.start_server(app)

dash_duo.find_element('#container')
dash_duo.find_element("#container")

dash_duo.wait_for_text_to_equal(
'#container', 'clicked 0 times')
dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
assert call_count.value == 1
dash_duo.percy_snapshot('button initialization')
dash_duo.percy_snapshot("button initialization")

dash_duo.find_element('#button').click()
dash_duo.find_element("#button").click()

dash_duo.wait_for_text_to_equal(
'#container', 'clicked 1 times')
dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
assert call_count.value == 2
dash_duo.percy_snapshot('button click')
dash_duo.percy_snapshot("button click")

assert not dash_duo.get_logs()

assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
call_count = Value('i', 0)
timestamp_1 = Value('d', -5)
timestamp_2 = Value('d', -5)
call_count = Value("i", 0)
timestamp_1 = Value("d", -5)
timestamp_2 = Value("d", -5)

app = dash.Dash(__name__)
app.layout = html.Div([
html.Div(id='container'),
html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
])
app.layout = html.Div(
[
html.Div(id="container"),
html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
]
)

@app.callback(
Output('container', 'children'),
[Input('button-1', 'n_clicks'),
Input('button-1', 'n_clicks_timestamp'),
Input('button-2', 'n_clicks'),
Input('button-2', 'n_clicks_timestamp')])
Output("container", "children"),
[
Input("button-1", "n_clicks"),
Input("button-1", "n_clicks_timestamp"),
Input("button-2", "n_clicks"),
Input("button-2", "n_clicks_timestamp"),
],
)
def update_output(*args):
print(args)
call_count.value += 1
timestamp_1.value = args[1]
timestamp_2.value = args[3]
return '{}, {}'.format(args[0], args[2])
return "{}, {}".format(args[0], args[2])

dash_duo.start_server(app)

dash_duo.wait_for_text_to_equal('#container', '0, 0')
dash_duo.wait_for_text_to_equal("#container", "0, 0")
assert timestamp_1.value == -1
assert timestamp_2.value == -1
assert call_count.value == 1
dash_duo.percy_snapshot('button initialization 1')
dash_duo.percy_snapshot("button initialization 1")

dash_duo.find_element('#button-1').click()
dash_duo.wait_for_text_to_equal('#container', '1, 0')
dash_duo.find_element("#button-1").click()
dash_duo.wait_for_text_to_equal("#container", "1, 0")
assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
assert timestamp_2.value == -1
assert call_count.value == 2
dash_duo.percy_snapshot('button-1 click')
dash_duo.percy_snapshot("button-1 click")
prev_timestamp_1 = timestamp_1.value

dash_duo.find_element('#button-2').click()
dash_duo.wait_for_text_to_equal('#container', '1, 1')
dash_duo.find_element("#button-2").click()
dash_duo.wait_for_text_to_equal("#container", "1, 1")
assert timestamp_1.value == prev_timestamp_1
assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
assert call_count.value == 3
dash_duo.percy_snapshot('button-2 click')
dash_duo.percy_snapshot("button-2 click")
prev_timestamp_2 = timestamp_2.value

dash_duo.find_element('#button-2').click()
dash_duo.wait_for_text_to_equal('#container', '1, 2')
dash_duo.find_element("#button-2").click()
dash_duo.wait_for_text_to_equal("#container", "1, 2")
assert timestamp_1.value == prev_timestamp_1
assert timestamp_2.value > prev_timestamp_2
assert timestamp_2.value > timestamp_1.value
assert call_count.value == 4
dash_duo.percy_snapshot('button-2 click again')
dash_duo.percy_snapshot("button-2 click again")

assert not dash_duo.get_logs()
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add allow prop to html.Iframe#179
 Merged

alexcjohnson
merged 5 commits into

from

Feb 11, 2021
 Merged


Add allow prop to html.Iframe
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
0c49ffe

Add `allow` prop to html.Iframe


ann-marie-ward Feb 6, 2021
116944c

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
abb2c91

Add `referrerPolicy` prop and update tests


ann-marie-ward Feb 9, 2021
9121acb

Updated changelog Fixes #77


ann-marie-ward Feb 11, 2021
2264cd4

Update CHANGELOG.md


alexcjohnson Feb 11, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## UNRELEASED
### Fixed
- [#179](https://github.com/plotly/dash-html-components/pull/178) - Fixes [#77](https://github.com/plotly/dash-html-components/issues/77) Added `allow` and `referrerPolicy` properties to `html.Iframe`

- [#178](https://github.com/plotly/dash-html-components/pull/178) - Fix [#161](https://github.com/plotly/dash-html-components/issues/161) <object> `data` property, and fix [#129](https://github.com/plotly/dash-html-components/issues/129) obsolete, deprecated, and discouraged elements. No elements were removed, but comments were added to the documentation about these elements detailing their limitations.

## [1.1.2] - 2021-01-19
Expand Down

6 changes: 3 additions & 3 deletions
scripts/extract-attributes.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ const htmlPath = './data/attributes.html';
// From https://facebook.github.io/react/docs/tags-and-attributes.html#supported-attributes
// less the special `className` and `htmlFor` props,
// and `httpEquiv` + `acceptCharset` which are already correctly camelCased.
const supportedAttributes = ['accept', 'accessKey', 'action',
const supportedAttributes = ['accept', 'accessKey', 'action', 'allow',
'allowFullScreen', 'allowTransparency', 'alt', 'async', 'autoComplete',
'autoFocus', 'autoPlay', 'capture', 'cellPadding', 'cellSpacing', 'challenge',
'charSet', 'checked', 'cite', 'classID', 'colSpan', 'cols', 'content',
Expand All@@ -25,8 +25,8 @@ const supportedAttributes = ['accept', 'accessKey', 'action',
'manifest', 'marginHeight', 'marginWidth', 'max', 'maxLength', 'media',
'mediaGroup', 'method', 'min', 'minLength', 'multiple', 'muted', 'name',
'noValidate', 'nonce', 'open', 'optimum', 'pattern', 'placeholder', 'poster',
'preload', 'profile', 'radioGroup', 'readOnly', 'rel', 'required', 'reversed',
'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'preload', 'profile', 'radioGroup', 'readOnly', 'referrerPolicy', 'rel', 'required', 
'reversed', 'role', 'rowSpan', 'rows', 'sandbox', 'scope', 'scoped', 'scrolling',
'seamless', 'selected', 'shape', 'size', 'sizes', 'span', 'spellCheck', 'src',
'srcDoc', 'srcLang', 'srcSet', 'start', 'step', 'style', 'summary', 'tabIndex',
'target', 'title', 'type', 'useMap', 'value', 'width', 'wmode', 'wrap'];
Expand Down

91 changes: 50 additions & 41 deletions
tests/test_integration.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,93 +7,102 @@


def test_click_simple(dash_duo):
 call_count = Value('i', 0)
 call_count = Value("i", 0)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button', n_clicks=0)
 ])

 @app.callback(Output('container', 'children'), Input('button', 'n_clicks'))
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button", n_clicks=0),
 html.Iframe(id="video", allow="fullscreen", referrerPolicy="origin"),
 ]
 )

 @app.callback(Output("container", "children"), Input("button", "n_clicks"))
 def update_output(n_clicks):
 call_count.value += 1
 return 'clicked {} times'.format(n_clicks)
 return "clicked {} times".format(n_clicks)

 dash_duo.start_server(app)

 dash_duo.find_element('#container')
 dash_duo.find_element("#container")

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 0 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 0 times")
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization')
 dash_duo.percy_snapshot("button initialization")

 dash_duo.find_element('#button').click()
 dash_duo.find_element("#button").click()

 dash_duo.wait_for_text_to_equal(
 '#container', 'clicked 1 times')
 dash_duo.wait_for_text_to_equal("#container", "clicked 1 times")
 assert call_count.value == 2
 dash_duo.percy_snapshot('button click')
 dash_duo.percy_snapshot("button click")

 assert not dash_duo.get_logs()

 assert dash_duo.find_element("#video").get_attribute("allow") == "fullscreen"
 assert dash_duo.find_element("#video").get_attribute("referrerpolicy") == "origin"


def test_click_prev(dash_duo):
 call_count = Value('i', 0)
 timestamp_1 = Value('d', -5)
 timestamp_2 = Value('d', -5)
 call_count = Value("i", 0)
 timestamp_1 = Value("d", -5)
 timestamp_2 = Value("d", -5)

 app = dash.Dash(__name__)
 app.layout = html.Div([
 html.Div(id='container'),
 html.Button('Click', id='button-1', n_clicks=0, n_clicks_timestamp=-1),
 html.Button('Click', id='button-2', n_clicks=0, n_clicks_timestamp=-1)
 ])
 app.layout = html.Div(
 [
 html.Div(id="container"),
 html.Button("Click", id="button-1", n_clicks=0, n_clicks_timestamp=-1),
 html.Button("Click", id="button-2", n_clicks=0, n_clicks_timestamp=-1),
 ]
 )

 @app.callback(
 Output('container', 'children'),
 [Input('button-1', 'n_clicks'),
 Input('button-1', 'n_clicks_timestamp'),
 Input('button-2', 'n_clicks'),
 Input('button-2', 'n_clicks_timestamp')])
 Output("container", "children"),
 [
 Input("button-1", "n_clicks"),
 Input("button-1", "n_clicks_timestamp"),
 Input("button-2", "n_clicks"),
 Input("button-2", "n_clicks_timestamp"),
 ],
 )
 def update_output(*args):
 print(args)
 call_count.value += 1
 timestamp_1.value = args[1]
 timestamp_2.value = args[3]
 return '{}, {}'.format(args[0], args[2])
 return "{}, {}".format(args[0], args[2])

 dash_duo.start_server(app)

 dash_duo.wait_for_text_to_equal('#container', '0, 0')
 dash_duo.wait_for_text_to_equal("#container", "0, 0")
 assert timestamp_1.value == -1
 assert timestamp_2.value == -1
 assert call_count.value == 1
 dash_duo.percy_snapshot('button initialization 1')
 dash_duo.percy_snapshot("button initialization 1")

 dash_duo.find_element('#button-1').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 0')
 dash_duo.find_element("#button-1").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 0")
 assert timestamp_1.value > ((time.time() - (24 * 60 * 60)) * 1000)
 assert timestamp_2.value == -1
 assert call_count.value == 2
 dash_duo.percy_snapshot('button-1 click')
 dash_duo.percy_snapshot("button-1 click")
 prev_timestamp_1 = timestamp_1.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 1')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 1")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > ((time.time() - 24 * 60 * 60) * 1000)
 assert call_count.value == 3
 dash_duo.percy_snapshot('button-2 click')
 dash_duo.percy_snapshot("button-2 click")
 prev_timestamp_2 = timestamp_2.value

 dash_duo.find_element('#button-2').click()
 dash_duo.wait_for_text_to_equal('#container', '1, 2')
 dash_duo.find_element("#button-2").click()
 dash_duo.wait_for_text_to_equal("#container", "1, 2")
 assert timestamp_1.value == prev_timestamp_1
 assert timestamp_2.value > prev_timestamp_2
 assert timestamp_2.value > timestamp_1.value
 assert call_count.value == 4
 dash_duo.percy_snapshot('button-2 click again')
 dash_duo.percy_snapshot("button-2 click again")

 assert not dash_duo.get_logs()