Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79

Merged
rmarren1 merged 17 commits into
masterfrom
update-tooling
Dec 12, 2018
Merged

Update tooling#79
rmarren1 merged 17 commits into
masterfrom
update-tooling

Conversation

@rmarren1

@rmarren1rmarren1 commented Nov 6, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Update tooling like in plotly/dash-core-components#299

Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439

@rmarren1

rmarren1 commented Nov 6, 2018

Copy link
Copy Markdown
ContributorAuthor

Should there be a demo for this repo?
npm run start does not work.

webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.

T4rk1n
T4rk1n approved these changes Nov 6, 2018
View reviewed changes

@T4rk1nT4rk1n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.

Comment thread.circleci/config.yml Outdated
- "node_modules"

- run:
name: prettier --list-different

@T4rk1nT4rk1nNov 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.

@rmarren1rmarren1Nov 6, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it

Comment threadscripts/publish.js Outdated
throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
} else {
execSh([
'npm publish --otp',

@T4rk1nT4rk1nNov 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.

@rmarren1rmarren1Nov 6, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.

@rmarren1

rmarren1 commented Dec 1, 2018

Copy link
Copy Markdown
ContributorAuthor

@T4rk1n care to take another look?

The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?

T4rk1n
T4rk1n reviewed Dec 3, 2018
View reviewed changes
Comment threadpackage.json Outdated
"start": "webpack-serve ./webpack.serve.config.js --open",
"test": "eslint --fix src",
"uninstall-local": "pip uninstall dash-html-components -y",
"prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",

@T4rk1nT4rk1nDec 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?

@rmarren1

rmarren1 commented Dec 7, 2018

Copy link
Copy Markdown
ContributorAuthor

@T4rk1n

  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed

@rmarren1

rmarren1 commented Dec 11, 2018

Copy link
Copy Markdown
ContributorAuthor

@T4rk1n (reminder)

T4rk1n
T4rk1n reviewed Dec 12, 2018
View reviewed changes
Comment threadpackage.json
"clean-src": "rm -rf src/* && mkdir -p src/components",
"clean": "npm run clean-lib && npm run clean-src",
"copy-lib": "cp lib/* dash_html_components",
"clean": "rm -rf src/* && mkdir -p src/components",

@T4rk1nT4rk1nDec 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.

T4rk1n
T4rk1n approved these changes Dec 12, 2018
View reviewed changes

@T4rk1nT4rk1n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.

@rmarren1

rmarren1 commented Dec 12, 2018

Copy link
Copy Markdown
ContributorAuthor

publish script is same as in DCC, so that problem will exist there too.

@rmarren1

rmarren1 commented Dec 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Not sure the best way to solve this, some options I can think of:

  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously

T4rk1n
T4rk1n reviewed Dec 12, 2018
View reviewed changes
Comment threadpackage.json
"test": "eslint --fix src",
"install-local": "python setup.py install",
"uninstall-local": "pip uninstall dash-html-components -y",
"prepublish": "npm run clean && npm run generate-components && npm run build:all",

@T4rk1nT4rk1nDec 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.

@T4rk1n

T4rk1n commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.

Windows dev can just run the commands to publish separately, that's what I do.

@rmarren1
rmarren1 merged commit fec4272 into masterDec 12, 2018
@rmarren1

rmarren1 commented Dec 12, 2018

Copy link
Copy Markdown
ContributorAuthor

👍

@rmarren1
rmarren1 deleted the update-tooling branch December 12, 2018 02:18
@rmarren1rmarren1 mentioned this pull request Dec 12, 2018
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman
1 more reviewer
@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Update tooling by rmarren1 · Pull Request #79 · plotly/dash-html-components · GitHub
Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Update tooling - #79
Merged
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Dec 12, 2018
Merged
Update tooling#79
rmarren1 merged 17 commits into
masterfrom 
update-tooling
Conversation
@rmarren1
@rmarren1rmarren1
commented
Nov 6, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Update tooling like in plotly/dash-core-components#299
Also, this moved requirements.txt -> .circleci/dev/dev-requirements.txt and makes that file minimal, like in this PR: plotly/dash#439
@rmarren1
rmarren1
commented
Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Should there be a demo for this repo?
npm run start does not work.
webpack.server.config.js points to ./src/demo/index.js, but that file does not exist.
T4rk1n
T4rk1n
approved these changes
Nov 6, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Just not sure about the benefits of adding prettier to auto generated code.
Comment thread.circleci/config.yml
Outdated

 - "node_modules"

 - run:
 name: prettier --list-different
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why prettier ? It's auto generated code.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this would probably just get annoying. I'll remove it
Comment threadscripts/publish.js
Outdated

 throw new Error('\nIt looks like there are uncommitted changes! Aborting until these changes have been resolved.\n');
 } else {
 execSh([
 'npm publish --otp',
@T4rk1nT4rk1nNov 6, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can remove the --otp, it will asks if need be.
@rmarren1rmarren1Nov 6, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, wasn't sure what that did, I just use npm publish then allow it to 401 and ask for the OTP. This was copied from the dash-core-components repo, so this happens there as well.
@rmarren1
rmarren1
commented
Dec 1, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n care to take another look?
The CI error in python3.7 is a E104 so it should fix itself with another run; however, it doesn't look like I have permissions to re-trigger builds for this repo (I do for other ones though). @chriddyp can I get permissions to do that in the future?
T4rk1n
T4rk1n
reviewed
Dec 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "start": "webpack-serve ./webpack.serve.config.js --open",
 "test": "eslint --fix src",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm test && npm run build:js && npm run build:js-dev && npm run build:py",
@T4rk1nT4rk1nDec 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we condense this scripts by using build:all ?
@rmarren1
rmarren1
commented
Dec 7, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n
  • Made that simplification to prepublish
  • Removed some more scripts that are now obselete (after removing archetype)
  • Updated README with more up to data instructions
  • Re-built the whole thing -- for some reason this created a bunch of diffs, but I am not sure what changed. It looks like that issue with ^M, but I thought that was fixed
@rmarren1
rmarren1
commented
Dec 11, 2018

Copy link


Copy Markdown

ContributorAuthor
@T4rk1n (reminder)
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "clean-src": "rm -rf src/* && mkdir -p src/components",
 "clean": "npm run clean-lib && npm run clean-src",
 "copy-lib": "cp lib/* dash_html_components",
 "clean": "rm -rf src/* && mkdir -p src/components",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work on windows natively.
T4rk1n
T4rk1n
approved these changes
Dec 12, 2018
View reviewed changes
@T4rk1nT4rk1n
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the clean command and publish script doesn't work on windows.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
publish script is same as in DCC, so that problem will exist there too.
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
Not sure the best way to solve this, some options I can think of:
  • Write out own script in a higher level language (e.g. python) that takes care of compatibility
  • have a clean and clean:windows command simultaneously
T4rk1n
T4rk1n
reviewed
Dec 12, 2018
View reviewed changes
Comment threadpackage.json
 "test": "eslint --fix src",
 "install-local": "python setup.py install",
 "uninstall-local": "pip uninstall dash-html-components -y",
 "prepublish": "npm run clean && npm run generate-components && npm run build:all",
@T4rk1nT4rk1nDec 12, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove prepublish entirely and use the new npm methods it warns about instead. This will throw when you install on windows.
@T4rk1n
T4rk1n
commented
Dec 12, 2018

Copy link


Copy Markdown

Contributor
Let's not fix those platform issues for now, clean/generate will run under cygwin/gitbash.
Windows dev can just run the commands to publish separately, that's what I do.
@rmarren1
rmarren1
merged commit fec4272
into
masterDec 12, 2018
@rmarren1
rmarren1
commented
Dec 12, 2018

Copy link


Copy Markdown

ContributorAuthor
👍
@rmarren1
rmarren1
deleted the

update-tooling

branch
December 12, 2018 02:18
@rmarren1rmarren1
mentioned this pull request
Dec 12, 2018

Closed

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@valentijnniemanvalentijnniemanAwaiting requested review from valentijnnieman

1 more reviewer

@T4rk1nT4rk1nT4rk1n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rmarren1@T4rk1n