This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dash_renderer/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,8 +8,9 @@
# `dash_html_components.__init__: module references __file__`
# TODO - Understand this better
# from .version import __version__
__version__ = '0.11.1'
__file__
from .version import __version__
NPM_VERSION = '0.13.0-rc2'

# Dash renderer's dependencies get loaded in a special order by the server:
# React bundles first, the renderer bundle at the very end.
Expand All@@ -33,7 +34,7 @@
"external_url": (
'https://unpkg.com/dash-renderer@{}'
'/dash_renderer/bundle.js'
).format(__version__),
).format(NPM_VERSION),
'namespace': 'dash_renderer'
}
]
2 changes: 1 addition & 1 deletion dash_renderer/version.py
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
__version__ = '0.11.1'
__version__ = '0.13.0rc2'
5 changes: 2 additions & 3 deletions dev-requirements.txt
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
dash_core_components==0.12.0
dash_html_components==0.7.0
dash==0.18.3
dash-core-components==0.16.0rc1
dash-html-components==0.9.0rc1
percy
selenium
mock
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "dash-renderer",
"version": "0.11.1",
"version": "0.13.0-rc2",
"description": "render dash components in react",
"main": "src/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions src/APIController.react.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import {connect} from 'react-redux'
import {contains, isEmpty, isNil} from 'ramda'
import React, {Component, PropTypes} from 'react';
import TreeContainer from './TreeContainer';
import Render from './Render';
import {
computeGraphs,
computePaths,
Expand DownExpand Up@@ -97,7 +97,7 @@ class UnconnectedContainer extends Component {
else if (appLifecycle === APP_STATES('HYDRATED')) {
return (
<div id="_dash-app-content">
<TreeContainer layout={layout}/>
<Render {...layout}/>
</div>
);
}
Expand Down
89 changes: 64 additions & 25 deletions src/components/core/NotifyObservers.react.js → src/Render.js
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,27 @@
import {connect} from 'react-redux';
import {isEmpty} from 'ramda';
import {notifyObservers, updateProps} from '../../actions';
import * as R from 'ramda';
import React, {PropTypes} from 'react';
import {connect} from 'react-redux';
import {notifyObservers, updateProps} from './actions';
import Registry from './registry';

function render(componentJson) {
if (R.type(componentJson) === 'Object' &&
R.has('type', componentJson) &&
R.has('namespace', componentJson) &&
R.has('props', componentJson)
) {
return <NotifyObservers {...componentJson}/>;
} else if (R.type(componentJson) === 'Array') {
return componentJson.map(render);
} else {
// number, boolean, string, null, array, undefined,
// or an Object that doesn't have the component keys
// (assumed to be a react object)
return componentJson;
}
}



/*
* NotifyObservers passes a connected `setProps` handler down to
Expand All@@ -21,43 +41,47 @@ function mapDispatchToProps (dispatch) {

function mergeProps(stateProps, dispatchProps, ownProps) {
const {dispatch} = dispatchProps;
const id = R.view(R.lensPath(['props', 'id']), ownProps);
return {
id: ownProps.id,
children: ownProps.children,
id: id,
dependencies: stateProps.dependencies,
paths: stateProps.paths,

fireEvent: function fireEvent({event}) {
// Update this component's observers with the updated props
dispatch(notifyObservers({event, id: ownProps.id}));
dispatch(notifyObservers({event, id: id}));
},

setProps: function setProps(newProps) {
const payload = {
props: newProps,
id: ownProps.id,
itempath: stateProps.paths[ownProps.id]
id: id,
itempath: stateProps.paths[id]
};

// Update this component's props
dispatch(updateProps(payload));

// Update output components that depend on this input
dispatch(notifyObservers({id: ownProps.id, props: newProps}));
}
dispatch(notifyObservers({id: id, props: newProps}));
},

componentJson: ownProps
}

}

function NotifyObserversComponent ({
children,

function NotifyObserversComponent({
id,
paths,

paths,
dependencies,

fireEvent,
setProps
setProps,

componentJson
}) {
const thisComponentTriggersEvents = (
dependencies && dependencies.find(dependency => (
Expand DownExpand Up@@ -85,7 +109,7 @@ function NotifyObserversComponent ({
* component author can check for something like `subscribed_events`
* or `subscribed_properties` instead of `fireEvent` and `setProps`.
*/
const extraProps = {};
const extraProps = {render};
if (thisComponentSharesState &&

// there is a bug with graphs right now where
Expand All@@ -100,22 +124,37 @@ function NotifyObserversComponent ({
if (thisComponentTriggersEvents && paths[id]) {
extraProps.fireEvent = fireEvent;
}
extraProps.render = render;

if (!isEmpty(extraProps)) {
return React.cloneElement(children, extraProps);
} else {
return children;
}
const allProps = R.merge(componentJson.props, extraProps);

const element = Registry.resolve(
componentJson.type, componentJson.namespace);

return React.createElement(
element,
allProps
);
}


NotifyObserversComponent.propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node.isRequired,
path: PropTypes.array.isRequired
};
id: PropTypes.string,

export default connect(
paths: PropTypes.object,
dependencies: PropTypes.object,

fireEvent: PropTypes.func,
setProps: PropTypes.func,

componentJson: PropTypes.object // oneOf?
}


const NotifyObservers = connect(
mapStateToProps,
mapDispatchToProps,
mergeProps
)(NotifyObserversComponent);

export default NotifyObservers;
86 changes: 0 additions & 86 deletions src/TreeContainer.js

This file was deleted.

33 changes: 12 additions & 21 deletions src/reducers/utils.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,25 +10,16 @@ export const crawlLayout = (object, func, path=[]) => {
* object may be a string, a number, or null
* R.has will return false for both of those types
*/
if (R.type(object) === 'Object' &&
R.has('props', object) &&
R.has('children', object.props)
) {
const newPath = extend(path, ['props', 'children']);
if (Array.isArray(object.props.children)) {
object.props.children.forEach((child, i) => {
crawlLayout(
child,
func,
R.append(i, newPath));
});
} else {
if (R.type(object) === 'Object') {
R.keys(object).forEach(key => {
const newPath = extend(path, [key]);

crawlLayout(
object.props.children,
object[key],
func,
newPath
);
}
newPath);

});
} else if (R.type(object) === 'Array') {

/*
Expand All@@ -49,10 +40,10 @@ export const crawlLayout = (object, func, path=[]) => {
}
}

export function hasId(child) {
export function hasId(element) {
return (
R.type(child) === 'Object' &&
R.has('props', child) &&
R.has('id', child.props)
R.type(element) === 'Object' &&
R.has('props', element) &&
R.has('id', element.props)
);
}
14 changes: 10 additions & 4 deletions tests/test_render.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,15 +517,21 @@ def update_input(value):
wait_for(
lambda: (
self.driver.find_element_by_id('output')
.get_attribute('innerHTML') == '''
<div>
<input id="sub-input-1" value="sub input initial value">
.get_attribute('innerHTML') in [
'''<div>
<input {}>
<div id="sub-output-1">
sub input initial value
</div>
</div>'''.replace('\n', '').replace(' ', '')
</div>'''.replace('\n', '').replace(' ', '').format(attr)
for attr in [
# can't guarentee the order of these attributes
'id="sub-input-1" value="sub input initial value"',
'value="sub input initial value" id="sub-input-1"'
]]
)
)

self.percy_snapshot(name='callback-generating-function-1')

# the paths should include these new output IDs
Expand Down