Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Canvas annotation app by ycaokris · Pull Request #407 · plotly/dash-sample-apps · GitHub
Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Canvas annotation app by ycaokris · Pull Request #407 · plotly/dash-sample-apps · GitHub
Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Canvas annotation app by ycaokris · Pull Request #407 · plotly/dash-sample-apps · GitHub
Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Canvas annotation app by ycaokris · Pull Request #407 · plotly/dash-sample-apps · GitHub
Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Canvas annotation app by ycaokris · Pull Request #407 · plotly/dash-sample-apps · GitHub
Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Canvas annotation app by ycaokris · Pull Request #407 · plotly/dash-sample-apps · GitHub
Skip to content

Canvas annotation app - #407

Merged
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text
Mar 19, 2020
Merged

Canvas annotation app#407
AirballClaytonCalvin merged 25 commits into
masterfrom
oss-canvas-text

Conversation

@ycaokris

@ycaokrisycaokris commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Issue for app: #https://github.com/plotly/dash-customer-success/issues/255

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.=
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)]
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

@ycaokrisycaokris changed the title iniital app commit (wip)Canvas annotation appFeb 12, 2020
@ycaokris
ycaokris marked this pull request as ready for review February 12, 2020 22:42

@christopherjeonchristopherjeon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

@ycaokris

Copy link
Copy Markdown
ContributorAuthor

Is it okay if the layout doesn't resize properly when the window size decreases?

Screen Shot 2020-02-28 at 5 45 48 PM

Apart from that minor issue, 💃

Good catch. I'll need a release of dash Canvas for implementing responsiveness. Once this PR is merged plotly/dash-canvas#39

@lundstrj

Copy link
Copy Markdown
Contributor

@sstripps1 you worked on this, right? Looks like. this got stuck in code review.
What is your take, should this get merged as is or should we dive in and examine this app more closely? My understanding is that this was more of a tech demo we did for a specific occasion, is that correct?

@sstripps1

Copy link
Copy Markdown
Contributor

@lundstrj this app is good to go other than a mobile responsiveness bug, which will be resolved once plotly/dash-canvas#39 is merged and we can use an updated version of canvas. Although we could probably merge for now (since it's mostly just for demo purposes anyway) and then add in that fix at a later date.

@lundstrj

Copy link
Copy Markdown
Contributor

okay, cool. Someone will have to run black on this and then we'll merge then.

I suppose I could do that. unless... @AirballClaytonCalvin

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

Happy to 'run black on this'. Although not 100% sure what that means.

@sstripps1

Copy link
Copy Markdown
Contributor

@AirballClaytonCalvin I can walk you thru it 💯

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

@sstripps1 I ran Black and it made 1 minor change to the app.py file. However, when I run it locally after the update, I get a callback error in my browser.

'Callback error updating text-output.children'

I am struggling to troubleshoot it right now.

@AirballClaytonCalvin

Copy link
Copy Markdown
Contributor

💃

@AirballClaytonCalvinAirballClaytonCalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@sstripps1sstripps1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 good to merge

@AirballClaytonCalvin
AirballClaytonCalvin merged commit 639ebbb into masterMar 19, 2020
@AirballClaytonCalvin
AirballClaytonCalvin deleted the oss-canvas-text branch March 19, 2020 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ycaokris@lundstrj@sstripps1@AirballClaytonCalvin@christopherjeon