') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); add thumbnail_size property by emmanuelle · Pull Request #34 · plotly/dash-slicer · GitHub
Skip to content

add thumbnail_size property - #34

Merged
almarklein merged 7 commits into
mainfrom
thumbnail
Dec 8, 2020
Merged

add thumbnail_size property#34
almarklein merged 7 commits into
mainfrom
thumbnail

Conversation

@emmanuelle

@emmanuelleemmanuelle commented Dec 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

[Updated]

This PR introduces a thumbnail_size property of the slicer, in order to be able to choose the size of the low-resolution images uploaded and available clientside. It is an integer, or None, in which case the full resolution data is uploaded clientside (I implemented this by not attaching the server callback, which was an easy solution).

@emmanuelleemmanuelle changed the title add thumbnail_size property[WIP] add thumbnail_size propertyDec 3, 2020
@almarklein

almarklein commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

Also it could be a good idea to let thumbnail_size be a tuple instead of an integer.

I'm not sure if Pillow allows this. Pillow seems to consider the given size as a hint. Which is why we have get_thumbnail_size(). But we can try.

Another nice addition would be to select a better default size when the data is very anisotropic. I noticed too that with the xray app the low-res data is way too low-res :P

BTW: I suspect that we're using different versions of Black (CI runs the latest).

@emmanuelleemmanuelle changed the title [WIP] add thumbnail_size propertyadd thumbnail_size propertyDec 4, 2020
@emmanuelle

emmanuelle commented Dec 4, 2020

Copy link
Copy Markdown
ContributorAuthor

Ready for review. I tested this on the xray app of the gallery. Probably I should add more tests and an example :-).

almarklein
almarklein reviewed Dec 5, 2020
View reviewed changes
Comment threaddash_slicer/slicer.py Outdated
Comment on lines +33 to +35
thumbnail_size (int or None): linear size of low-resolution data to be
uploaded to the client. If ``None``, the full-resolution data are
uploaded client-side.

@almarkleinalmarkleinDec 5, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feeling a bit uncomfortable about the None which is often used to denote a default value. What about just thumbnail, which can be set to True/False, but also allowing an int with the size? Once we've fixed the anisotropy thing, the default size should be fine in nearly all cases.

Let's also mention the default size here.

almarklein
almarklein reviewed Dec 5, 2020
View reviewed changes
Comment threaddash_slicer/slicer.py Outdated
Comment on lines +150 to +151
@property
def thumbnail_size(self):

@almarkleinalmarkleinDec 5, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need a public prop for this. Or do you have a use-case in mind?

almarklein
almarklein reviewed Dec 5, 2020
View reviewed changes
Comment threaddash_slicer/slicer.py Outdated
Comment on lines +278 to +281
if self._thumbnail_size is None:
thumbnail_size = None
info["lowres_size"] = info["size"]
else:

@almarkleinalmarkleinDec 5, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a check here to make thumbnail_size None when the given size is larger than the image size?

@almarklein

almarklein commented Dec 5, 2020

Copy link
Copy Markdown
Collaborator

This is nice!

@emmanuelle

emmanuelle commented Dec 7, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review @almarklein !

@almarklein

almarklein commented Dec 8, 2020

Copy link
Copy Markdown
Collaborator

This PR looks good to go. Do you know what's up with the circleci build, @emmanuelle ?

@almarklein
almarklein merged commit 2c6eac5 into mainDec 8, 2020
@almarklein
almarklein deleted the thumbnail branch December 8, 2020 14:40
@almarkleinalmarklein mentioned this pull request Dec 11, 2020
Closed
16 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@almarkleinalmarkleinalmarklein left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmanuelle@almarklein