Skip to content

Support for anisotropic data. - #8

Merged
almarklein merged 2 commits into
mainfrom
world-coords
Nov 5, 2020
Merged

Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom
world-coords

Conversation

@almarklein

@almarkleinalmarklein commented Nov 4, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

rebased

This:

  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.

@almarkleinalmarklein mentioned this pull request Nov 4, 2020
Closed
16 tasks
almarklein
almarklein commented Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py Outdated
Comment on lines +31 to +35
slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)

@almarkleinalmarkleinNov 4, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)

@almarkleinalmarkleinNov 4, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha

@emmanuelleemmanuelleNov 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)

@emmanuelle

emmanuelle commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.

@almarklein

almarklein commented Nov 5, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!

almarklein
almarklein commented Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py
Comment on lines +23 to +25
reverse_y (bool): Whether to reverse the y-axis, so that the origin of
the slice is in the top-left, rather than bottom-left. Default True.
(This sets the figure's yaxes ``autorange`` to either "reversed" or True.)

@almarkleinalmarkleinNov 5, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.

@almarklein
almarklein merged commit 88e2e7b into mainNov 5, 2020
@almarklein
almarklein deleted the world-coords branch November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Support for anisotropic data. by almarklein · Pull Request #8 · plotly/dash-slicer · GitHub
Skip to content
Support for anisotropic data. - #8
Merged
almarklein merged 2 commits into
mainfrom 
world-coords
Nov 5, 2020
Merged
Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom 
world-coords
Conversation
@almarklein
@almarkleinalmarklein
commented
Nov 4, 2020•

edited

Loading

Copy link


Copy Markdown

Collaborator
rebased
This:
  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.
@almarkleinalmarklein
mentioned this pull request
Nov 4, 2020

Closed

16 tasks
almarklein
almarklein
commented
Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py
Outdated


Comment on lines

+31
 to 
+35

slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
 app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha
@emmanuelleemmanuelleNov 5, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)
@emmanuelle
emmanuelle
commented
Nov 5, 2020

Copy link


Copy Markdown

Contributor
Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.
@almarklein
almarklein
commented
Nov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!
almarklein
almarklein
commented
Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py

Comment on lines

+23
 to 
+25

 reverse_y (bool): Whether to reverse the y-axis, so that the origin of
 the slice is in the top-left, rather than bottom-left. Default True.
 (This sets the figure's yaxes ``autorange`` to either "reversed" or True.)
@almarkleinalmarkleinNov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.
@almarklein
almarklein
merged commit 88e2e7b
into
mainNov 5, 2020
@almarklein
almarklein
deleted the

world-coords

branch
November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support for anisotropic data. by almarklein · Pull Request #8 · plotly/dash-slicer · GitHub
Skip to content
Support for anisotropic data. - #8
Merged
almarklein merged 2 commits into
mainfrom 
world-coords
Nov 5, 2020
Merged
Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom 
world-coords
Conversation
@almarklein
@almarkleinalmarklein
commented
Nov 4, 2020•

edited

Loading

Copy link


Copy Markdown

Collaborator
rebased
This:
  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.
@almarkleinalmarklein
mentioned this pull request
Nov 4, 2020

Closed

16 tasks
almarklein
almarklein
commented
Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py
Outdated


Comment on lines

+31
 to 
+35

slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
 app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha
@emmanuelleemmanuelleNov 5, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)
@emmanuelle
emmanuelle
commented
Nov 5, 2020

Copy link


Copy Markdown

Contributor
Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.
@almarklein
almarklein
commented
Nov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!
almarklein
almarklein
commented
Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py

Comment on lines

+23
 to 
+25

 reverse_y (bool): Whether to reverse the y-axis, so that the origin of
 the slice is in the top-left, rather than bottom-left. Default True.
 (This sets the figure's yaxes ``autorange`` to either "reversed" or True.)
@almarkleinalmarkleinNov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.
@almarklein
almarklein
merged commit 88e2e7b
into
mainNov 5, 2020
@almarklein
almarklein
deleted the

world-coords

branch
November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support for anisotropic data. by almarklein · Pull Request #8 · plotly/dash-slicer · GitHub
Skip to content
Support for anisotropic data. - #8
Merged
almarklein merged 2 commits into
mainfrom 
world-coords
Nov 5, 2020
Merged
Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom 
world-coords
Conversation
@almarklein
@almarkleinalmarklein
commented
Nov 4, 2020•

edited

Loading

Copy link


Copy Markdown

Collaborator
rebased
This:
  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.
@almarkleinalmarklein
mentioned this pull request
Nov 4, 2020

Closed

16 tasks
almarklein
almarklein
commented
Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py
Outdated


Comment on lines

+31
 to 
+35

slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
 app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha
@emmanuelleemmanuelleNov 5, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)
@emmanuelle
emmanuelle
commented
Nov 5, 2020

Copy link


Copy Markdown

Contributor
Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.
@almarklein
almarklein
commented
Nov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!
almarklein
almarklein
commented
Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py

Comment on lines

+23
 to 
+25

 reverse_y (bool): Whether to reverse the y-axis, so that the origin of
 the slice is in the top-left, rather than bottom-left. Default True.
 (This sets the figure's yaxes ``autorange`` to either "reversed" or True.)
@almarkleinalmarkleinNov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.
@almarklein
almarklein
merged commit 88e2e7b
into
mainNov 5, 2020
@almarklein
almarklein
deleted the

world-coords

branch
November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Support for anisotropic data. by almarklein · Pull Request #8 · plotly/dash-slicer · GitHub
Skip to content
Support for anisotropic data. - #8
Merged
almarklein merged 2 commits into
mainfrom 
world-coords
Nov 5, 2020
Merged
Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom 
world-coords
Conversation
@almarklein
@almarkleinalmarklein
commented
Nov 4, 2020•

edited

Loading

Copy link


Copy Markdown

Collaborator
rebased
This:
  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.
@almarkleinalmarklein
mentioned this pull request
Nov 4, 2020

Closed

16 tasks
almarklein
almarklein
commented
Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py
Outdated


Comment on lines

+31
 to 
+35

slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
 app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha
@emmanuelleemmanuelleNov 5, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)
@emmanuelle
emmanuelle
commented
Nov 5, 2020

Copy link


Copy Markdown

Contributor
Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.
@almarklein
almarklein
commented
Nov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!
almarklein
almarklein
commented
Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py

Comment on lines

+23
 to 
+25

 reverse_y (bool): Whether to reverse the y-axis, so that the origin of
 the slice is in the top-left, rather than bottom-left. Default True.
 (This sets the figure's yaxes ``autorange`` to either "reversed" or True.)
@almarkleinalmarkleinNov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.
@almarklein
almarklein
merged commit 88e2e7b
into
mainNov 5, 2020
@almarklein
almarklein
deleted the

world-coords

branch
November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Support for anisotropic data. by almarklein · Pull Request #8 · plotly/dash-slicer · GitHub
Skip to content
Support for anisotropic data. - #8
Merged
almarklein merged 2 commits into
mainfrom 
world-coords
Nov 5, 2020
Merged
Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom 
world-coords
Conversation
@almarklein
@almarkleinalmarklein
commented
Nov 4, 2020•

edited

Loading

Copy link


Copy Markdown

Collaborator
rebased
This:
  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.
@almarkleinalmarklein
mentioned this pull request
Nov 4, 2020

Closed

16 tasks
almarklein
almarklein
commented
Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py
Outdated


Comment on lines

+31
 to 
+35

slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
 app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha
@emmanuelleemmanuelleNov 5, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)
@emmanuelle
emmanuelle
commented
Nov 5, 2020

Copy link


Copy Markdown

Contributor
Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.
@almarklein
almarklein
commented
Nov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!
almarklein
almarklein
commented
Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py

Comment on lines

+23
 to 
+25

 reverse_y (bool): Whether to reverse the y-axis, so that the origin of
 the slice is in the top-left, rather than bottom-left. Default True.
 (This sets the figure's yaxes ``autorange`` to either "reversed" or True.)
@almarkleinalmarkleinNov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.
@almarklein
almarklein
merged commit 88e2e7b
into
mainNov 5, 2020
@almarklein
almarklein
deleted the

world-coords

branch
November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Support for anisotropic data. by almarklein · Pull Request #8 · plotly/dash-slicer · GitHub
Skip to content
Support for anisotropic data. - #8
Merged
almarklein merged 2 commits into
mainfrom 
world-coords
Nov 5, 2020
Merged
Support for anisotropic data.#8
almarklein merged 2 commits into
mainfrom 
world-coords
Conversation
@almarklein
@almarkleinalmarklein
commented
Nov 4, 2020•

edited

Loading

Copy link


Copy Markdown

Collaborator
rebased
This:
  • Adds spacing and origin arguments to specify the position and scale of a volume.
  • Update things accordingly: everything lives in "scene-coordinates" now.
  • Updates the slicer_with_1_plus_2_views.py example to include one view with downsampled data.
  • Add reverse_y argument.
@almarkleinalmarklein
mentioned this pull request
Nov 4, 2020

Closed

16 tasks
almarklein
almarklein
commented
Nov 4, 2020
View reviewed changes
Comment threadexamples/slicer_with_1_plus_2_views.py
Outdated


Comment on lines

+31
 to 
+35

slicer1 = DashVolumeSlicer(app, vol1, axis=1, origin=origin, scene_id="myscene")
slicer2 = DashVolumeSlicer(app, vol1, axis=0, origin=origin, scene_id="myscene")
slicer3 = DashVolumeSlicer(
 app, vol2, axis=0, origin=origin, spacing=spacing, scene_id="myscene"
)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmanuelle see how we use different data in the 3d slicer, and connect it up by using a common scene_id :)
@almarkleinalmarkleinNov 4, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this example, haha
@emmanuelleemmanuelleNov 5, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool :-)
@emmanuelle
emmanuelle
commented
Nov 5, 2020

Copy link


Copy Markdown

Contributor
Thanks @almarklein ! Looks good to me. With this PR I think it's now possible to adapt https://github.com/plotly/dash-sample-apps/blob/master/apps/dash-covid-xray/app.py to use the slicer (the data are indeed anisotropic). Would you like to try it or would you prefer someone else to adapt the app so that you focus on development? As you wish, both are fine.
@almarklein
almarklein
commented
Nov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Yeah, I think adapting that example would be a really nice exercise to see how the API holds up, so I think I'll have a go myself!
almarklein
almarklein
commented
Nov 5, 2020
View reviewed changes
Comment threaddash_3d_viewer/slicer.py

Comment on lines

+23
 to 
+25

 reverse_y (bool): Whether to reverse the y-axis, so that the origin of
 the slice is in the top-left, rather than bottom-left. Default True.
 (This sets the figure's yaxes ``autorange`` to either "reversed" or True.)
@almarkleinalmarkleinNov 5, 2020

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this.
@almarklein
almarklein
merged commit 88e2e7b
into
mainNov 5, 2020
@almarklein
almarklein
deleted the

world-coords

branch
November 5, 2020 12:29
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@emmanuelleemmanuelleemmanuelle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@almarklein@emmanuelle