This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798

Merged
Marc-Andre-Rivet merged 5 commits into from
Jun 19, 2020
Merged

Issue 797 - Misaligned rows after callback #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87efcc0
Resize table on any prop change + testing
Jun 19, 2020
8a59c6b
handleResize on all prop change except if not fixed
Jun 19, 2020
01c834c
reduce coverage redundency (build is just too long.. and this should …
Jun 19, 2020
3f3cf33
changelog
Jun 19, 2020
c93050c
remove `global`
Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
- Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
- Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
- Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down
27 changes: 5 additions & 22 deletions src/dash-table/components/ControlledTable/index.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
this.updateUiViewport();

const {
style_as_list_view,
style_cell,
style_cell_conditional,
style_data,
style_data_conditional,
style_filter,
style_filter_conditional,
style_header,
style_header_conditional,
style_table
fixed_columns,
fixed_rows
} = this.props;

this.handleResizeIf(
style_as_list_view,
style_cell,
style_cell_conditional,
style_data,
style_data_conditional,
style_filter,
style_filter_conditional,
style_header,
style_header_conditional,
style_table
);
if (fixed_columns || fixed_rows) {
this.handleResizeIf(...R.values(this.props));

@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.

Better to be right slightly slower than to be wrong slightly faster..

}

this.handleDropdown();
this.adjustTooltipPosition();
Expand Down
155 changes: 114 additions & 41 deletions tests/selenium/test_sizing.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
columns=[
{"id": "_", "name": ["_", "_", "_"]},
{
"id": "a",
"name": [
"A-----------------VERY LONG",
"A-----------------VERY LONG",
"A-----------------VERY LONG",
],
},
{
"id": "b",
"name": [
"A-----------------VERY LONG",
"A-----------------VERY LONG",
"B-----------------VERY LONG",
],
},
{
"id": "c",
"name": [
"A-----------------VERY LONG---",
"B-----------------VERY LONG---------",
"C-----------------VERY LONG------------------",
],
},
],
data=[
{"_": 0, "a": 85, "b": 601, "c": 891},
{"_": 0, "a": 967, "b": 189, "c": 514},
{"_": 0, "a": 398, "b": 262, "c": 743},
{"_": 0, "a": 89, "b": 560, "c": 582},
{"_": 0, "a": 809, "b": 591, "c": 511},
],
style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
base_props = dict(
columns=[
{"id": "_", "name": ["_", "_", "_"]},
{
"id": "a",
"name": [
"A-----------------VERY LONG",
"A-----------------VERY LONG",
"A-----------------VERY LONG",
],
},
{
"id": "b",
"name": [
"A-----------------VERY LONG",
"A-----------------VERY LONG",
"B-----------------VERY LONG",
],
},
{
"id": "c",
"name": [
"A-----------------VERY LONG---",
"B-----------------VERY LONG---------",
"C-----------------VERY LONG------------------",
],
},
],
data=[
{"_": 0, "a": 85, "b": 601, "c": 891},
{"_": 0, "a": 967, "b": 189, "c": 514},
{"_": 0, "a": 398, "b": 262, "c": 743},
{"_": 0, "a": 89, "b": 560, "c": 582},
{"_": 0, "a": 809, "b": 591, "c": 511},
],
style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)

_fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

_fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

_merge_duplicate_headers = [True, False]

variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
for i in range(1, len(variations)):
table = test.driver.find_element_by_css_selector("#table{}".format(i))
cells_are_same_width(target, table)


@pytest.mark.parametrize(
"fixed_columns",
[
# dict(),
dict(fixed_columns=dict(headers=True)),
dict(fixed_columns=dict(headers=True, data=1)),
],
)
@pytest.mark.parametrize(
"fixed_rows",
[
# dict(),
dict(fixed_rows=dict(headers=True)),
dict(fixed_rows=dict(headers=True, data=1)),
],
)
@pytest.mark.parametrize(
"merge_duplicate_headers",
[dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
"callback_props",
[
dict(
data=[
{"_": 0, "a": 85, "b": 601, "c": 891},
{"_": 0, "a": 967, "b": 189, "c": 514},
{"_": 0, "a": 398, "b": 262, "c": 743},
{
"_": "SOME VERY LONG VALUE",
"a": "SOME VERY LONG VALUE 2",
"b": "SOME VERY LONG VALUE 3",
"c": "SOME VERY LONG VALUE 4",
},
{"_": 0, "a": 89, "b": 560, "c": 582},
{"_": 0, "a": 809, "b": 591, "c": 511},
]
),
dict(merge_duplicate_headers=True),
# dict(fixed_rows=dict(headers=True)),

@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.

# dict(fixed_columns=dict(headers=True)),
dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
],
)
def test_szng003_on_prop_change(
test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

table = DataTable(**props, id="table")

app = dash.Dash(__name__)
app.layout = Div([Button(id="btn", children=["Update"]), table])

@app.callback(
[Output("table", key) for key in callback_props.keys()],

@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉

[Input("btn", "n_clicks")],
prevent_initial_call=True,
)
def callback(n_clicks):
return [callback_props.get(key) for key in callback_props.keys()]

test.start_server(app)

target = test.driver.find_element_by_css_selector("#table")
cells_are_same_width(target, target)

test.driver.find_element_by_css_selector("#btn").click()
cells_are_same_width(target, target)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 797 - Misaligned rows after callback#798
 Merged

Marc-Andre-Rivet
merged 5 commits into

from

Jun 19, 2020
 Merged


Issue 797 - Misaligned rows after callback
#798
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
87efcc0

Resize table on any prop change + testing

Jun 19, 2020
8a59c6b

handleResize on all prop change except if not fixed

Jun 19, 2020
01c834c

reduce coverage redundency (build is just too long.. and this should …

Jun 19, 2020
3f3cf33

changelog

Jun 19, 2020
c93050c

remove `global`

Jun 19, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 5 additions & 1 deletion
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#798](https://github.com/plotly/dash-table/pull/798) Fix a bug where headers are not aligned with columns after an update [#797](https://github.com/plotly/dash-table/issues/797)

## [4.8.0] - 2020-06-17
### Added
- [#787](https://github.com/plotly/dash-table/pull/787) Add `cell_selectable` property to allow/disallow cell selection
Expand All@@ -14,7 +18,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### Fixed
- [#785](https://github.com/plotly/dash-table/pull/785) Fix a bug where the table does not refresh correctly if a property was previously missing
- [#793](https://github.com/plotly/dash-table/pull/793)
 - Fix a bug where headers aren't aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a bug where headers are not aligned with columns with fixed_rows [#777](https://github.com/plotly/dash-table/issues/777)
 - Fix a regression where headers don't scroll horizontally with fixed_rows [#780](https://github.com/plotly/dash-table/issues/780)

## [4.7.0] - 2020-05-05
Expand Down

27 changes: 5 additions & 22 deletions
src/dash-table/components/ControlledTable/index.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -151,30 +151,13 @@ export default class ControlledTable extends PureComponent<ControlledTableProps>
 this.updateUiViewport();

 const {
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 fixed_columns,
 fixed_rows
 } = this.props;

 this.handleResizeIf(
 style_as_list_view,
 style_cell,
 style_cell_conditional,
 style_data,
 style_data_conditional,
 style_filter,
 style_filter_conditional,
 style_header,
 style_header_conditional,
 style_table
 );
 if (fixed_columns || fixed_rows) {
 this.handleResizeIf(...R.values(this.props));
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't attempt resize if nothing is fixed. Otherwise, resize on any prop change. Most props can require a recalculation due to interactions with other props. Even active_cell could cause the border width to change through a conditional style, etc. This will have a performance impact as resizing will happen more often, but the bulk of the cost (relayout) would be happening anyway.
Better to be right slightly slower than to be wrong slightly faster..
 }

 this.handleDropdown();
 this.adjustTooltipPosition();
Expand Down

155 changes: 114 additions & 41 deletions
tests/selenium/test_sizing.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,50 @@
import dash
import pytest

from dash.dependencies import Input, Output
from dash.testing import wait
from dash_table import DataTable
from dash_html_components import Button, Div

base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
)


def cells_are_same_width(target, table):
 wait.until(lambda: abs(target.size["width"] - table.size["width"]) <= 1, 3)
Expand DownExpand Up@@ -174,49 +215,8 @@ def update_styles(n_clicks):


def test_szng002_percentages_result_in_same_widths(test):
 base_props = dict(
 columns=[
 {"id": "_", "name": ["_", "_", "_"]},
 {
 "id": "a",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 ],
 },
 {
 "id": "b",
 "name": [
 "A-----------------VERY LONG",
 "A-----------------VERY LONG",
 "B-----------------VERY LONG",
 ],
 },
 {
 "id": "c",
 "name": [
 "A-----------------VERY LONG---",
 "B-----------------VERY LONG---------",
 "C-----------------VERY LONG------------------",
 ],
 },
 ],
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ],
 style_table=dict(width=500, minWidth=500, maxWidth=500, paddingBottom=10),
 style_cell=dict(width="25%", minWidth="25%", maxWidth="25%"),
 )

 _fixed_columns = [dict(headers=True, data=1), dict(headers=True)]

 _fixed_rows = [dict(headers=True, data=1), dict(headers=True)]

 _merge_duplicate_headers = [True, False]

 variations = []
Expand DownExpand Up@@ -248,3 +248,76 @@ def test_szng002_percentages_result_in_same_widths(test):
 for i in range(1, len(variations)):
 table = test.driver.find_element_by_css_selector("#table{}".format(i))
 cells_are_same_width(target, table)


@pytest.mark.parametrize(
 "fixed_columns",
 [
 # dict(),
 dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "fixed_rows",
 [
 # dict(),
 dict(fixed_rows=dict(headers=True)),
 dict(fixed_rows=dict(headers=True, data=1)),
 ],
)
@pytest.mark.parametrize(
 "merge_duplicate_headers",
 [dict(merge_duplicate_headers=True), dict(merge_duplicate_headers=False)],
)
@pytest.mark.parametrize(
 "callback_props",
 [
 dict(
 data=[
 {"_": 0, "a": 85, "b": 601, "c": 891},
 {"_": 0, "a": 967, "b": 189, "c": 514},
 {"_": 0, "a": 398, "b": 262, "c": 743},
 {
 "_": "SOME VERY LONG VALUE",
 "a": "SOME VERY LONG VALUE 2",
 "b": "SOME VERY LONG VALUE 3",
 "c": "SOME VERY LONG VALUE 4",
 },
 {"_": 0, "a": 89, "b": 560, "c": 582},
 {"_": 0, "a": 809, "b": 591, "c": 511},
 ]
 ),
 dict(merge_duplicate_headers=True),
 # dict(fixed_rows=dict(headers=True)),
@Marc-Andre-RivetMarc-Andre-RivetJun 19, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out certain, more redundant, scenarios. With the above, this reduces the number of tests combinations from 126 to 40, which is more palatable in terms of CI time.
 # dict(fixed_columns=dict(headers=True)),
 dict(fixed_columns=dict(headers=True), fixed_rows=dict(headers=True)),
 dict(style_cell=dict(width=200, minWidth=200, maxWidth=200)),
 dict(style_table=dict(width=500, minWidth=500, maxWidth=500)),
 ],
)
def test_szng003_on_prop_change(
 test, fixed_columns, fixed_rows, merge_duplicate_headers, callback_props
):
 props = {**base_props, **fixed_columns, **fixed_rows, **merge_duplicate_headers}

 table = DataTable(**props, id="table")

 app = dash.Dash(__name__)
 app.layout = Div([Button(id="btn", children=["Update"]), table])

 @app.callback(
 [Output("table", key) for key in callback_props.keys()],
@alexcjohnsonalexcjohnsonJun 19, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever 🎉
 [Input("btn", "n_clicks")],
 prevent_initial_call=True,
 )
 def callback(n_clicks):
 return [callback_props.get(key) for key in callback_props.keys()]

 test.start_server(app)

 target = test.driver.find_element_by_css_selector("#table")
 cells_are_same_width(target, target)

 test.driver.find_element_by_css_selector("#btn").click()
 cells_are_same_width(target, target)