Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 72
Update table dependencies#814
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
a1863d7cef89fadb0a0118a4fd30b4268bfaf0c8f4af9a274c147d801cfa4b7bcd1ef453803139b0a5d5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -39,13 +39,21 @@ module.exports = (options = {}) => { | ||
| module: { | ||
| rules: [ | ||
| { | ||
| test: /demo[/\\]index.html?$/, | ||
| test: /demo[\\\/]index.html?$/, | ||
| loader: 'file-loader?name=index.[ext]' | ||
| }, | ||
| { | ||
| test: /\.csv$/, | ||
| loader: 'raw-loader' | ||
| }, | ||
| { | ||
| test: /\.ts(x?)$/, | ||
| include: /node_modules[\\\/](highlight[.]js)[\\\/]/, | ||
| use: [ | ||
| { loader: 'babel-loader', options: babel }, | ||
| { loader: 'ts-loader', options: ts }, | ||
| ] | ||
| }, | ||
| { | ||
| test: /\.ts(x?)$/, | ||
| exclude: /node_modules/, | ||
| @@ -55,6 +63,13 @@ module.exports = (options = {}) => { | ||
| { loader: 'webpack-preprocessor', options: JSON.stringify(preprocessor) } | ||
| ] | ||
| }, | ||
| { | ||
| test: /\.js$/, | ||
| include: /node_modules[\\\/](highlight[.]js)[\\\/]/, | ||
| use: [ | ||
| { loader: 'babel-loader', options: babel } | ||
| ] | ||
| }, | ||
rpkyle marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| { | ||
| test: /\.js$/, | ||
| exclude: /node_modules/, | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "tabWidth": 4, | ||
| "singleQuote": true, | ||
| "jsxSingleQuote": true, | ||
| "arrowParens": "avoid", | ||
| "bracketSpacing": false, | ||
| "trailingComma": "none" | ||
| } |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| const path = require('path'); | ||
| const baseConfig = require('./../.config/webpack/base.js')({ | ||
| ts: { | ||
| transpileOnly: true | ||
| }, | ||
| preprocessor: { | ||
| variables: { | ||
| mode: 'eager' | ||
| } | ||
| } | ||
| }); | ||
| module.exports = { | ||
| stories: ['./../tests/visual/percy-storybook/**/*.percy.tsx'], | ||
| webpackFinal: async (config, { configType }) => { | ||
| // jerry rig everything | ||
| config.resolve.alias.core = path.resolve(__dirname, './../src/core'), | ||
| config.resolve.alias['dash-table'] = path.resolve(__dirname, './../src/dash-table') | ||
| config.module = baseConfig.module; | ||
| return config; | ||
| } | ||
| }; | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Storybook 6 brings totally new configuration files and opinions. Making it work with our own needs.. Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Marc-Andre-Rivet For any package using Storybook >=6, I imagine we now have to add config.resolve.alias['dash-table']=path.resolve(__dirname,'./../src/dash-table')but specific to the path/package name? ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. But the table is the only project using storybook. | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.