Uh oh!
There was an error while loading. Please reload this page.
Issue 736 - Tooltip horizontal position incorrect - #817
Conversation
| ac = ActionChains(self.mixin.driver) | ||
| ac.move_to_element(self._get_cell_value()) | ||
| return ac.perform() | ||
There was a problem hiding this comment.
Additional table cell helper moving the mouse over it - and scrolling as required to make it visible. Has the nice side-effect of triggering the tooltip if there's one.
| .get_attribute("innerHTML") | ||
| ) | ||
There was a problem hiding this comment.
The beginnings of a table tooltip helper similar to the other helpers..
| def assert_aligned(cell, tooltip): | ||
| assert tooltip.location["x"] <= (cell.location["x"] + cell.size["width"]) | ||
| assert (tooltip.location["x"] + tooltip.size["width"]) >= cell.location["x"] |
There was a problem hiding this comment.
A tooltip should begin before or at the end of the cell and end after or at the beginning of the cell. More precise conditions are conditional on the tooltip size.
| cell = target.cell(0, len(columns) - 1) | ||
| cell.move_to() | ||
| assert_aligned(cell.get(), tooltip.get()) |
There was a problem hiding this comment.
Rewrite of the Cypress tests remove at https://github.com/plotly/dash-table/pull/817/files#diff-7dd15fcdd93b4d42f63039db0cb61101. Checks for more variations and start/middle/end of table cells - this test fails without the phantom-cell fix.
alexcjohnson
left a comment
There was a problem hiding this comment.
Nice fix and tests! 💃
But how did you end up with a conflict in a brand-new PR?
Marc-Andre-Rivet
commented
Aug 19, 2020
@alexcjohnson I think my local |
Closes#736
#722 introduced a tooltip regression causing the tooltip to be positioned with respect to the
phantom-cellused for consistent sizing instead of therealvisible cell.This PR fixes the above and adds new tests that validate the tooltip's position in more scenarios.