This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841

Merged
Marc-Andre-Rivet merged 14 commits into from
Oct 20, 2020
Merged

Issue 840 - Fix proptypes & syntax highlighting, and improve tests #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f980e4c
- fix proptypes
Oct 19, 2020
1f7ca98
changelog
Oct 19, 2020
a327fe8
changelog
Oct 19, 2020
78c4db3
check for errors only
Oct 19, 2020
99126ba
move tests/integration -> tests/selenium and standardize
Oct 19, 2020
d9aeb3c
update highlight.js usage
Oct 19, 2020
558d216
PreventUpdate instead of None
Oct 19, 2020
7584d3d
fix log error - assets/logo.png instead of external url
Oct 19, 2020
9e80289
log errors, check for empty array instead (to see error content in py…
Oct 20, 2020
ef60484
add highlights julia support
Oct 20, 2020
511a217
add syntax highlight test
Oct 20, 2020
d80ea9a
add plaintext
Oct 20, 2020
e6a4d47
changelog
Oct 20, 2020
9540802
latest highlight.js
Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions .circleci/config.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
npm run lint
when: always


"python-3.6":
docker:
- image: circleci/python:3.7.5-stretch-node-browsers

environment:
PERCY_ENABLED: True
PERCY_PROJECT: plotly/dash-table-python-v0

steps:
- checkout

- run:
name: Inject Percy Environment variables
command: |
echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

- run:
name: Install requirements
command: |
sudo pip install --upgrade virtualenv
python -m venv venv || virtualenv venv
. venv/bin/activate
pip install -r dev-requirements.txt --quiet
npm ci

- run:
name: Install dependencies (dash)
command: |
. venv/bin/activate
git clone --depth 1 git@github.com:plotly/dash.git dash-main
pip install -e ./dash-main[dev,testing] --quiet
cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

- run:
name: Install test requirements
command: |
. venv/bin/activate
npm run build
python setup.py sdist
cd dist
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

- run:
name: ⚙️ run integration test
command: |
. venv/bin/activate
pytest --junitxml=test-reports/dash.xml tests/integration
- store_artifacts:
path: test-reports
- store_test_results:
path: test-reports
- store_artifacts:
path: /tmp/dash_artifacts



workflows:
version: 2
build:
jobs:
- "python-3.6"
- "node"
- "server-test"
- "standalone-test"
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
- Fix prop-types regression causing console errors in browser devtools
- Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
"es-check": "^5.1.0",
"fast-isnumeric": "^1.1.4",
"file-loader": "^6.0.0",
"highlight.js": "^10.1.2",
"highlight.js": "^10.3.1",
"http-server": "^0.12.3",
"husky": "^4.2.5",
"less": "^3.12.2",
Expand Down
2 changes: 1 addition & 1 deletion src/dash-table/dash/DataTable.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
}),
PropTypes.arrayOf(
PropTypes.oneOfType([
PropTypes.nully,
PropTypes.oneOf([null]),
PropTypes.string,
PropTypes.exact({
delay: PropTypes.number,
Expand Down
6 changes: 5 additions & 1 deletion src/third-party/highlight.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';

@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?

@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.

@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871

import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down
91 changes: 0 additions & 91 deletions tests/integration/IntegrationTests.py
View file
Open in desktop

This file was deleted.

Empty file removedtests/integration/__init__.py
View file
Open in desktop
Empty file.
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 840 - Fix proptypes & syntax highlighting, and improve tests#841
 Merged

Marc-Andre-Rivet
merged 14 commits into

from

Oct 20, 2020
 Merged


Issue 840 - Fix proptypes & syntax highlighting, and improve tests
#841
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


14 commits


Select commit
Hold shift + click to select a range
f980e4c

- fix proptypes

Oct 19, 2020
1f7ca98

changelog

Oct 19, 2020
a327fe8

changelog

Oct 19, 2020
78c4db3

check for errors only

Oct 19, 2020
99126ba

move tests/integration -> tests/selenium and standardize

Oct 19, 2020
d9aeb3c

update highlight.js usage

Oct 19, 2020
558d216

PreventUpdate instead of None

Oct 19, 2020
7584d3d

fix log error - assets/logo.png instead of external url

Oct 19, 2020
9e80289

log errors, check for empty array instead (to see error content in py…

Oct 20, 2020
ef60484

add highlights julia support

Oct 20, 2020
511a217

add syntax highlight test

Oct 20, 2020
d80ea9a

add plaintext

Oct 20, 2020
e6a4d47

changelog

Oct 20, 2020
9540802

latest highlight.js

Oct 20, 2020

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


58 changes: 0 additions & 58 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -183,68 +183,10 @@ jobs:
 npm run lint
 when: always


 "python-3.6":
 docker:
 - image: circleci/python:3.7.5-stretch-node-browsers

 environment:
 PERCY_ENABLED: True
 PERCY_PROJECT: plotly/dash-table-python-v0

 steps:
 - checkout

 - run:
 name: Inject Percy Environment variables
 command: |
 echo 'export PERCY_TOKEN="$PERCY_PYTHON_TOKEN_V0"' >> $BASH_ENV

 - run:
 name: Install requirements
 command: |
 sudo pip install --upgrade virtualenv
 python -m venv venv || virtualenv venv
 . venv/bin/activate
 pip install -r dev-requirements.txt --quiet
 npm ci

 - run:
 name: Install dependencies (dash)
 command: |
 . venv/bin/activate
 git clone --depth 1 git@github.com:plotly/dash.git dash-main
 pip install -e ./dash-main[dev,testing] --quiet
 cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ../..

 - run:
 name: Install test requirements
 command: |
 . venv/bin/activate
 npm run build
 python setup.py sdist
 cd dist
 find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

 - run:
 name: ⚙️ run integration test
 command: |
 . venv/bin/activate
 pytest --junitxml=test-reports/dash.xml tests/integration
 - store_artifacts:
 path: test-reports
 - store_test_results:
 path: test-reports
 - store_artifacts:
 path: /tmp/dash_artifacts



workflows:
 version: 2
 build:
 jobs:
 - "python-3.6"
 - "node"
 - "server-test"
 - "standalone-test"
Expand Down

9 changes: 9 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,15 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Fixed
- [#841](https://github.com/plotly/dash-table/pull/841)
 - Fix prop-types regression causing console errors in browser devtools
 - Fix syntax highlighting regression for Markdown cells

### Added
- [#841](https://github.com/plotly/dash-table/pull/841) Add Julia syntax highlighting support for Markdown cells

## [4.10.1] - 2020-09-03
-Dash.jl Julia component generation

Expand Down

6 changes: 3 additions & 3 deletions
package-lock.json

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


2 changes: 1 addition & 1 deletion
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@
 "es-check": "^5.1.0",
 "fast-isnumeric": "^1.1.4",
 "file-loader": "^6.0.0",
 "highlight.js": "^10.1.2",
 "highlight.js": "^10.3.1",
 "http-server": "^0.12.3",
 "husky": "^4.2.5",
 "less": "^3.12.2",
Expand Down

2 changes: 1 addition & 1 deletion
src/dash-table/dash/DataTable.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -996,7 +996,7 @@ export const propTypes = {
 }),
 PropTypes.arrayOf(
 PropTypes.oneOfType([
 PropTypes.nully,
 PropTypes.oneOf([null]),
 PropTypes.string,
 PropTypes.exact({
 delay: PropTypes.number,
Expand Down

6 changes: 5 additions & 1 deletion
src/third-party/highlight.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
import highlightjs from 'highlight.js/lib/highlight';
import highlightjs from 'highlight.js/lib/core';
@alexcjohnsonalexcjohnsonOct 20, 2020

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to upgrade highlight in DCC too while this is front of mind?
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. And if tacking that on, might as well add Julia support.
@Marc-Andre-RivetMarc-Andre-RivetOct 20, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotly/dash-core-components#871
import 'highlight.js/styles/github.css';

import bash from 'highlight.js/lib/languages/bash';
import css from 'highlight.js/lib/languages/css';
import http from 'highlight.js/lib/languages/http';
import javascript from 'highlight.js/lib/languages/javascript';
import json from 'highlight.js/lib/languages/json';
import julia from 'highlight.js/lib/languages/julia';
import markdown from 'highlight.js/lib/languages/markdown';
import plaintext from 'highlight.js/lib/languages/plaintext';
import python from 'highlight.js/lib/languages/python';
import r from 'highlight.js/lib/languages/r';
import ruby from 'highlight.js/lib/languages/ruby';
Expand All@@ -20,7 +22,9 @@ highlightjs.registerLanguage('css', css);
highlightjs.registerLanguage('http', http);
highlightjs.registerLanguage('javascript', javascript);
highlightjs.registerLanguage('json', json);
highlightjs.registerLanguage('julia', julia);
highlightjs.registerLanguage('markdown', markdown);
highlightjs.registerLanguage('plaintext', plaintext);
highlightjs.registerLanguage('python', python);
highlightjs.registerLanguage('r', r);
highlightjs.registerLanguage('ruby', ruby);
Expand Down

91 changes: 0 additions & 91 deletions
tests/integration/IntegrationTests.py

View file


Open in desktop


This file was deleted.

Empty file removedtests/integration/__init__.py

View file


Open in desktop


Empty file.

Loading