Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Update to Webpack 5 - #875
Closed
Marc-Andre-Rivet wants to merge 58 commits into
Closed
Conversation
- update configuration from webpack 4 -> 5
Marc-Andre-Rivetforce-pushed
the
update-deps-20210306
branch
from
March 8, 2021 15:47
3db679e to
c3ba857CompareMarc-Andre-Rivetforce-pushed
the
update-deps-20210306
branch
from
March 9, 2021 12:51
ce2b3f3 to
245ba00Compare
added 11 commits
March 9, 2021 10:32
…flake and black; utils parametrization for frequent scenarios
- generalize utils and add new data mocks
- select column by id or index in tests
- some dropdown tests cypress -> selenium
added 28 commits
March 14, 2021 11:32
- add "invalid" filter check - additional filter tests cypress -> selenium
…nto update-deps-20210306
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on plotly/dash#1563
Updates the table "build" to use Webpack 5 and newer versions of the toolchain packages (e.g. babel, typescript, loaders).
These changes also cause problems that are more or less difficult to fix:
Storybook, which we use here to generate the Percy snapshots hooks into the webpack configuration and expects Webpack 4.x -- some changes in tooling is done here to make it work with webpack 5Cypresshas been in a derelict state for our purpose for quite a while and this Webpack 5 update is causing problems that can't be fixed (as far as I can tell) in the unit tests -- this PR moves the unit tests from using Cypress to another stack that has been around for a lot of time and is very stable.. Karma + Mocha, since the cypress test syntax already was compatible with Mocha, it left only the runner to be updated. For context, mocha tests are normally run directly in Node which won't do for our purposes, Karma is used, amongst other things, to load the tests into the browser to be run there. Additional context, Karma has been around for a very long time (it's ancient by web development standards, ~2012), this will hopefully provide more solid footing for the unit testsMore on
Cypress, back in 2018 I introduced Cypress into the table stack to run integration tests as our Selenium setup was less than ideal at the time, this has proven problematic ever since Cypress 4.x came out. Will look to rewrite the remaining Cypress integration tests as Selenium as part of this PRAll-in-all this PR proposes to update the table toolchain in depth as part of keeping up with our third party dependencies as the ever growing gap has now reached chasm proportions... one must not fear the reaper.