Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 72
Update toolchain#878
Uh oh!
There was an error while loading. Please reload this page.
Update toolchain #878
Changes from all commits
ab2de024c1b4df0fc57496a8b0a92063cc750b9a97993f653bce90edef389572840f030c60032c2899081f4d705873508f75b6ae121910c3381e49dc8985e36c086e34378ec0eef129bc7d7a5dc6ac5607bb2f85c37de12bdce3fb1f334e9721c3e84a64b1c1a6c639449245bfa79934File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,28 @@ | ||
| version: 2.1 | ||
| jobs: | ||
| percy-finalize: | ||
| docker: | ||
| - image: percyio/agent | ||
| steps: | ||
| - run: | ||
| name: Inject Percy Environment variables | ||
| command: | | ||
| echo 'export PERCY_TOKEN="$PERCY_TOKEN_E2E"' >> $BASH_ENV | ||
| - run: percy finalize --all | ||
| "server-test": | ||
| docker: | ||
| - image: circleci/python:3.7.9-node-browsers | ||
| - image: circleci/python:3.9.2-buster-node-browsers | ||
| environment: | ||
| PERCY_PARALLEL_TOTAL: -1 | ||
| - image: cypress/base:10 | ||
| parallelism: 4 | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Inject Percy Environment variables | ||
| command: | | ||
| echo 'export PERCY_TOKEN="$PERCY_TOKEN_E2E"' >> $BASH_ENV | ||
| - restore_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }} | ||
| - run: | ||
| @@ -24,18 +32,15 @@ jobs: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }} | ||
| paths: | ||
| - node_modules | ||
alexcjohnson marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| - run: | ||
| name: Install requirements | ||
| command: | | ||
| sudo pip install --upgrade virtualenv | ||
| python -m venv venv || virtualenv venv | ||
| python -m venv venv | ||
| . venv/bin/activate | ||
| pip install -r dev-requirements.txt --quiet | ||
| git clone --depth 1 git@github.com:plotly/dash.git dash-main | ||
| pip install -e ./dash-main[dev,testing] --quiet | ||
| cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ./../.. | ||
| - run: | ||
| name: Build | ||
| command: | | ||
| @@ -45,112 +50,63 @@ jobs: | ||
| python setup.py sdist | ||
| cd dist | ||
| find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd .. | ||
| - run: | ||
| name: Run tests | ||
| command: | | ||
| . venv/bin/activate | ||
| npm run test.server | ||
| - run: | ||
| name: 🦔 percy finalize | ||
| command: npx percy finalize --all | ||
| when: always | ||
| "standalone-test": | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These tests have been ported to test-server / Selenium Collaborator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @alexcjohnson I've tried but for some reason one of the test consistently fails with parallelism turned on. I've got no idea why. Can try and figure it out before we consider this PR ready.
| ||
| docker: | ||
| - image: circleci/python:3.6.7-node-browsers | ||
| - image: cypress/base:10 | ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }} | ||
| - run: | ||
| name: Install npm packages | ||
| command: npm ci | ||
| - run: | ||
| name: Cypress Install | ||
| command: | | ||
| $(npm bin)/cypress install | ||
| - save_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }} | ||
| paths: | ||
| - node_modules | ||
| - /home/circleci/.cache/Cypress | ||
| - run: | ||
| name: Run tests | ||
| command: | | ||
| rm -rf node_modules/cypress | ||
| npm i cypress@3.4.1 | ||
| npm run test.standalone | ||
| TESTFILES=$(circleci tests glob "tests/selenium/**/test_*.py" | circleci tests split --split-by=timings) | ||
| pytest --nopercyfinalize --junitxml=test-reports/junit_intg.xml ${TESTFILES} | ||
| - store_artifacts: | ||
| path: test-reports | ||
| - store_test_results: | ||
| path: test-reports | ||
| - store_artifacts: | ||
| path: /tmp/dash_artifacts | ||
| "unit-test": | ||
| docker: | ||
| - image: circleci/python:3.7.5-node-browsers | ||
| - image: cypress/base:10 | ||
| - image: circleci/python:3.9.2-buster-node-browsers | ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }} | ||
| - run: | ||
| name: Install npm packages | ||
| command: npm ci | ||
| - run: | ||
| name: Cypress Install | ||
| command: | | ||
| $(npm bin)/cypress install | ||
| - save_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}-{{ checksum ".circleci/config.yml" }} | ||
| paths: | ||
| - node_modules | ||
| - /home/circleci/.cache/Cypress | ||
| - run: | ||
| name: Install requirements | ||
| command: | | ||
| sudo pip install --upgrade virtualenv | ||
| python -m venv venv || virtualenv venv | ||
| python -m venv venv | ||
| . venv/bin/activate | ||
| pip install -r dev-requirements.txt --quiet | ||
| pip install --progress-bar off -e git+https://github.com/plotly/dash.git@dev#egg=dash[dev,testing] | ||
| - run: | ||
| name: Run tests | ||
| command: | | ||
| . venv/bin/activate | ||
| npm run build | ||
| npm run test.unit | ||
| "visual-test": | ||
| docker: | ||
| - image: circleci/node:10-browsers | ||
| - image: circleci/node:14-browsers | ||
| ||
| steps: | ||
| - checkout | ||
| - restore_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }} | ||
| - run: | ||
| name: Install package.json | ||
| command: npm ci | ||
| - save_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }} | ||
| paths: | ||
| - node_modules | ||
| - run: | ||
| name: Run build:js | ||
| command: npm run private::build:js | ||
| - run: | ||
| name: Run visual tests | ||
| command: npm run test.visual | ||
| @@ -159,34 +115,27 @@ jobs: | ||
| "node": | ||
| docker: | ||
| - image: circleci/python:3.7.5-node | ||
| - image: circleci/python:3.9.2-node | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Create virtual env | ||
| command: python -m venv || virtualenv venv | ||
| command: python -m venv venv | ||
| - restore_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }} | ||
| - run: | ||
| name: Install package.json | ||
| command: npm ci | ||
| - save_cache: | ||
| key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }} | ||
| paths: | ||
| - node_modules | ||
| - run: | ||
| name: Install requirements | ||
| command: | | ||
| . venv/bin/activate | ||
| pip install -r dev-requirements.txt --quiet | ||
| pip install --progress-bar off -e git+https://github.com/plotly/dash.git@dev#egg=dash[dev,testing] | ||
| - run: | ||
| name: Run eslint | ||
| command: | | ||
| @@ -200,6 +149,8 @@ workflows: | ||
| jobs: | ||
| - "node" | ||
| - "server-test" | ||
| - "standalone-test" | ||
| - "unit-test" | ||
| - "visual-test" | ||
| - percy-finalize: | ||
| requires: | ||
| - server-test | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -25,7 +25,6 @@ module.exports = (options = {}) => { | ||
| mode: mode, | ||
| output: { | ||
| path: path.resolve(__dirname, `./../../${dashLibraryName}`), | ||
| chunkFilename: '[name].js', | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed from Wepback4 -> 5 -- see | ||
| filename: '[name].js', | ||
| library: dashLibraryName, | ||
| libraryTarget: 'window' | ||
| @@ -40,15 +39,18 @@ module.exports = (options = {}) => { | ||
| rules: [ | ||
| { | ||
| test: /demo[\\\/]index.html?$/, | ||
| loader: 'file-loader?name=index.[ext]' | ||
| loader: 'file-loader', | ||
| options: { | ||
| name: 'index.[ext]' | ||
| } | ||
| }, | ||
| { | ||
| test: /\.csv$/, | ||
| loader: 'raw-loader' | ||
| }, | ||
| { | ||
| test: /\.ts(x?)$/, | ||
| include: /node_modules[\\\/](highlight[.]js)[\\\/]/, | ||
| include: /node_modules[\\\/](highlight[.]js|d3-format)[\\\/]/, | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
| ||
| use: [ | ||
| { loader: 'babel-loader', options: babel }, | ||
| { loader: 'ts-loader', options: ts }, | ||
| @@ -65,7 +67,7 @@ module.exports = (options = {}) => { | ||
| }, | ||
| { | ||
| test: /\.js$/, | ||
| include: /node_modules[\\\/](highlight[.]js)[\\\/]/, | ||
| include: /node_modules[\\\/](highlight[.]js|d3-format)[\\\/]/, | ||
| use: [ | ||
| { loader: 'babel-loader', options: babel } | ||
| ] | ||
| @@ -97,7 +99,6 @@ module.exports = (options = {}) => { | ||
| }, | ||
| resolve: { | ||
| alias: { | ||
| cypress: path.resolve('./tests/cypress/src'), | ||
| 'dash-table': path.resolve('./src/dash-table'), | ||
| demo: path.resolve('./demo'), | ||
| core: path.resolve('./src/core'), | ||
| @@ -108,7 +109,7 @@ module.exports = (options = {}) => { | ||
| optimization: { | ||
| splitChunks: { | ||
| chunks: 'async', | ||
| name: true, | ||
| name: '[name].js', | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed from Wepback4 -> 5 | ||
| cacheGroups: { | ||
| async: { | ||
| chunks: 'async', | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| { | ||
| "extends": [ | ||
| "plugin:@typescript-eslint/recommended", | ||
| "prettier" | ||
| ], | ||
| "plugins": [ | ||
| "@typescript-eslint" | ||
| ], | ||
| "parserOptions": { | ||
| "project": "./tsconfig.lint.json" | ||
| }, | ||
| "rules": { | ||
| "arrow-parens": [ | ||
| 2, | ||
| "as-needed" | ||
| ], | ||
| "comma-dangle": [ | ||
| 2, | ||
| "never" | ||
| ], | ||
| "no-unused-expressions": 2, | ||
| "no-unused-vars": 0, | ||
| "prefer-arrow-callback": 2, | ||
| "quote-props": [ | ||
| 2, | ||
| "as-needed" | ||
| ], | ||
| "quotes": [ | ||
| 2, | ||
| "single", | ||
| { "avoidEscape": true } | ||
| ], | ||
| "@typescript-eslint/ban-types": 0, | ||
| "@typescript-eslint/explicit-module-boundary-types": 0, | ||
| "@typescript-eslint/array-type": 0, | ||
| "@typescript-eslint/eofline": 0, | ||
| "@typescript-eslint/max-classes-per-file": 0, | ||
| "@typescript-eslint/max-line-length": 0, | ||
| "@typescript-eslint/member-access": 0, | ||
| "@typescript-eslint/member-ordering": 0, | ||
| "@typescript-eslint/no-conditional-assignment": 0, | ||
| "@typescript-eslint/no-empty": 0, | ||
| "@typescript-eslint/no-empty-function": 0, | ||
| "@typescript-eslint/no-empty-interface": 0, | ||
| "@typescript-eslint/no-explicit-any": 0, | ||
| "@typescript-eslint/no-unused-vars": [2, { "argsIgnorePattern": "_" }], | ||
| "@typescript-eslint/object-literal-sort-keys": 0, | ||
| "@typescript-eslint/object-literal-shorthand": 0, | ||
| "@typescript-eslint/ordered-imports": 0, | ||
| "@typescript-eslint/prefer-const": 0, | ||
| "@typescript-eslint/prefer-for-of": 0, | ||
| "@typescript-eslint/space-before-function-paren": [ | ||
| 0, | ||
| "always" | ||
| ], | ||
| "@typescript-eslint/unified-signatures": 0, | ||
| "@typescript-eslint/variable-name": 0 | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [flake8] | ||
| ignore = C901, E203, E266, E501, E731, W503 | ||
| ignore = C901, E203, E231, E266, E501, E731, W503 | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Flask / Black spacing and trailing | ||
| select = B,C,E,F,W,T4 | ||
| per-file-ignores = | ||
| tests/*: E722, F811 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -17,7 +17,6 @@ Project.toml | ||
| # testing | ||
| /coverage | ||
| /tests/cypress/screenshots/** | ||
| /storybook-static/** | ||
| # misc | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to use py3.9 as per https://github.com/plotly/dash-core/issues/203
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, can't use the new CircleCI
cimgbecauseCHROME_BINis missing and expected by Karma