Children array error by alexcjohnson · Pull Request #1026 · plotly/dash

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson · 2019-11-22T20:43:35Z

Trying to give a more helpful error message than users encounter today, like #1024, when forgetting to wrap children in an array inside components. Obviously if we ever do Components as Props that would need to be taken into account here - but I suspect that would be fine, each component would need to register internally which props can accept components.

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

I have added entry in the CHANGELOG.md

ie if you forget to make children an array, and just put it flat in component args

Marc-Andre-Rivet · 2019-11-26T13:35:37Z

+ if k != "children" and isinstance(v, Component):
+ raise TypeError(
+ "Component detected as a prop other than `children`\n" +
+ "Did you forget to wrap multiple `children` in an array?" +


Either a \n or whitespace after the end of the sentence

good call -> 4d96e0d

Marc-Andre-Rivet · 2019-11-26T22:39:31Z

Diff in https://percy.io/plotly/dash/builds/3264807/view/203019307/1280?mode=diff&browser=firefox&snapshot=203019307 looks related to async / the behavior is fine but without eager_loading=True the graph displays locally with a noticeable delay, after the 1 appears on the devtools icon -- the screenshot occurs before the graph renders.

The important information is what the devtools are displaying. We could update the test to wait for svg.main-svg to be present.. otherwise we may get unstable results if/when the CI environment is a bit slower and allows for the graph to display before the snapshot.

Marc-Andre-Rivet

💃

ohaibbq · 2020-05-06T00:17:53Z

Hey y'all,

We're running into this exception while trying to use multiple props as PropType.node. React's docs suggest that if you have multiple pieces of content to dynamically add to a component, you should use your own props scheme rather than props.children. i.e. props.leftChildren and props.rightChildren.

Was this diff supposed to intentionally disallow this case? If not, I think we should add a PropType check to ensure that the prop type for k is not a PropType.node before raising this error.

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

alexcjohnson added 2 commits November 22, 2019 13:45

give test_base_component tests standard ids
26cfd5a

check for components as args not in children
3d0d06e
ie if you forget to make children an array, and just put it flat in component args

alexcjohnson requested review from Marc-Andre-Rivet and byronz as code owners November 22, 2019 20:43

changelog for children array error message
53a82b8

Marc-Andre-Rivet added this to the Dash v1.7 milestone Nov 26, 2019

Marc-Andre-Rivet reviewed Nov 26, 2019
View reviewed changes

new line, new caps in children array error message
4d96e0d

Marc-Andre-Rivet mentioned this pull request Nov 26, 2019
Issue 1010 - Non-rendered async components using asyncDecorator lock renderer callbacks #1027
Merged

Merge branch 'dev' into children-array-error
08e3f22

wait for graph in devtools test
637042e

Marc-Andre-Rivet approved these changes Nov 27, 2019
View reviewed changes

alexcjohnson merged commit ffffce0 into devNov 27, 2019

alexcjohnson deleted the children-array-error branch November 27, 2019 15:20

Uh oh!

Uh oh!

Conversation

alexcjohnson commented Nov 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

optionals

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marc-Andre-Rivet commented Nov 26, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

Uh oh!

ohaibbq commented May 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

alexcjohnson commented Nov 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

optionals

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marc-Andre-Rivet commented Nov 26, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

Uh oh!

ohaibbq commented May 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

alexcjohnson commented Nov 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

optionals

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marc-Andre-Rivet commented Nov 26, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

Uh oh!

ohaibbq commented May 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

alexcjohnson commented Nov 22, 2019•
edited
Loading

Marc-Andre-Rivet commented Nov 26, 2019•
edited
Loading

alexcjohnson commented Nov 22, 2019•
edited
Loading

Marc-Andre-Rivet commented Nov 26, 2019•
edited
Loading

alexcjohnson commented Nov 22, 2019•
edited
Loading

Marc-Andre-Rivet commented Nov 26, 2019•
edited
Loading

alexcjohnson commented Nov 22, 2019•
edited
Loading

Marc-Andre-Rivet commented Nov 26, 2019•
edited
Loading

alexcjohnson commented Nov 22, 2019•
edited
Loading