Component nested artifacts + Test by Marc-Andre-Rivet · Pull Request #1203 · plotly/dash

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-Andre-Rivet · 2020-04-20T20:13:28Z

Based on the community PR #1125:

Adds sanity testing for component with nested (and standard non-nested) artifacts
Updates the R component generator to include all nested files in the target folder instead of only the files directly in the current folder
Allows component authors to use the same target name for both R and Python generation, whatever the artifacts folder structure
Replace dash-render-test-components.UncontrolledInput usage with dcc.Input

- fix lint errors

Marc-Andre-Rivet · 2020-04-20T20:15:02Z

+ if not os.path.exists(target_dirname):
+ os.makedirs(target_dirname)
+
+ shutil.copy(os.path.join(rel_dirname, filename), target_dirname)


So this is the real change - everything else is just for the nested/standard file structure test.
Instead of globing files w/o recursion, glob with recursion (using os.walk because glob.glob does not support the recursive named param in py27)

Marc-Andre-Rivet · 2020-04-20T20:15:40Z

+ dash_duo.start_server(app)
+
+ assert dash_duo.wait_for_element("#standard").text == "Standard"
+ assert dash_duo.wait_for_element("#nested").text == "Nested"


Check if both dummy standard and nested components load correctly

alexcjohnson · 2020-04-21T12:51:48Z

+ "private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc37} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
 "private::lint.renderer": "cd dash-renderer && npm run lint",
+ "private::test.setup-nested": "cd \\@plotly/dash-generator-test-component-nested && npm ci && npm run build && pip install -e .",
+ "private::test.setup-standard": "cd \\@plotly/dash-generator-test-component-standard && npm ci && npm run build && pip install -e .",


Is your plan - the reason these packages are up in @plotly rather than in tests - to publish them for use in the R (& Julia) tests?

No. Don't plan on publishing them at this point. I simply wanted to isolate them from other concerns. The package.json file contains "private": true which should prevent accidental publication. R/Julia tests would be expected to git clone and build the components atm.

…c.Input

alexcjohnson

💃 Thanks for 🔪 dash-renderer-test-components 🎉 🏆

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Marc-André Rivetand others added 9 commits April 16, 2020 16:52

Add standard and nested generated components for testing
b097968

Preserve folder structure in generated inst/deps
102fd0b

py27: can't use glob recursive=True
588619b

integration test for standard and nested components
000c9e3

lint
5f35d0b

Differentiate nested and standard component names
8470571

lint in all colors
f825b12

- pylint in py27: no ordering (contradicts rules for py37)
4f2e6da
- fix lint errors

Merge branch 'dev' into pr1125-tests
365e3da

Marc-Andre-Rivet commented Apr 20, 2020
View reviewed changes

Marc-Andre-Rivet changed the title ~~Pr1125 tests~~Component nested artifacts + TestApr 20, 2020

Marc-Andre-Rivet mentioned this pull request Apr 20, 2020
R component generation - support different package structures #1125
Closed

Marc-Andre-Rivet marked this pull request as ready for review April 20, 2020 20:29

Marc-Andre-Rivet requested review from alexcjohnson and rpkyle as code owners April 20, 2020 20:29

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread.pylintrc Outdated

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

Comment thread@plotly/dash-generator-test-component-standard/.Rhistory Outdated

Marc-André Rivet added 2 commits April 21, 2020 08:50

undo wrong-import-order
764339e

Merge branch 'pr1125-tests' of github.com:plotly/dash into pr1125-tests
2b42705

alexcjohnson reviewed Apr 21, 2020
View reviewed changes

ignore R env files
e5c4935

Marc-Andre-Rivet mentioned this pull request Apr 21, 2020
Nested and standard component folder structure test plotly/dashR#191
Merged

replace dash_renderer_test_components.UncontrolledInput usage with dc…
2fe6732
…c.Input

alexcjohnson approved these changes Apr 21, 2020
View reviewed changes

rel_path to project_shortname
ee1bbac

Marc-Andre-Rivet merged commit 65a1d5c into devApr 21, 2020

Marc-Andre-Rivet deleted the pr1125-tests branch April 21, 2020 21:31

Marc-Andre-Rivet added dash-type-bug labels Apr 21, 2020

rpkyle mentioned this pull request Apr 23, 2020
Make dash_bootstrap_components.themes available in Dash.jl plotly/Dash.jl#11
Closed

tcbegley mentioned this pull request Nov 7, 2020
Generate Julia components with nested structure #1453
Merged

Uh oh!

Uh oh!

Conversation

Marc-Andre-Rivet commented Apr 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marc-Andre-RivetApr 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Marc-Andre-Rivet commented Apr 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marc-Andre-RivetApr 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

Marc-Andre-Rivet commented Apr 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marc-Andre-RivetApr 21, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Marc-Andre-Rivet commented Apr 20, 2020•
edited
Loading

Marc-Andre-RivetApr 21, 2020•
edited
Loading

Marc-Andre-Rivet commented Apr 20, 2020•
edited
Loading

Marc-Andre-RivetApr 21, 2020•
edited
Loading

Marc-Andre-Rivet commented Apr 20, 2020•
edited
Loading

Marc-Andre-RivetApr 21, 2020•
edited
Loading

Marc-Andre-Rivet commented Apr 20, 2020•
edited
Loading

Marc-Andre-RivetApr 21, 2020•
edited
Loading