dedent error messages

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530

[chriddyp]

Our error messages are printed in the terminal & in the dash dev tools console. In both cases, we treat white space literally in order to display nice tracebacks. However, some of our error messages are indented. This PR dedents these error messages.

Example of behavior:

optionals

• I have added entry in the CHANGELOG.md

[alexcjohnson]

I'm puzzled as to why this is necessary - we tried to dedent all the Dash exceptions in the base class.

dash/dash/exceptions.py

Lines 4 to 6 in cd2ff7c

	classDashException(Exception):
	def__init__(self, msg=""):
	super(DashException, self).__init__(dedent(msg).strip())

If you manage to figure out the test failures, they seem to be the same as @almarklein sees in plotly/dash-core-components#905 - something broke in the dash-html-components build process? If nothing else I'll try and sort this out later this afternoon.

[alexcjohnson]

In the specific example you show above, dedent is not going to fix the problem because it will only remove a consistent number of spaces from each line, and the lines [0] Tab and [2] function have no indentation. This comes from when path is inserted in the string here:

dash/dash/_validate.py

Lines 180 to 184 in cd2ff7c

	The value in question is located at
	{} {} {}
	{},
	""".format(
	index_string, outer_type, outer_id, path

because path is a result of '\n'.join(...) in various places, meaning it has unindented lines within it.

Seems to me the solution is to indent subsequent lines of path, something like path.replace('\n', ' ' * 12 + '\n'), and use that pattern anywhere else we have multiline args interpolated in these messages.

[alexcjohnson]

superseded by #1530