Add an 'x' button to close the error messages box #1403 by AnnMarieW · Pull Request #1508 · plotly/dash

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

AnnMarieW · 2020-12-19T17:45:14Z

This is a potential solution for #1403
It works in my local environment, but needs better css for the x button

alexcjohnson · 2020-12-22T17:15:21Z

@AnnMarieW this works great! Re: styling, I'm thinking we can use a much lighter button right in the corner, something like this:

Which I got from applying the following styling in the devtools, along with replacing the SVG icon with just a unicode × (or in fact just the unicode character ×)

<div style="
position: absolute;
right: 0;
top: 0;
color: #ccc;
font-size: 20px;
cursor: pointer;
">×</div>

Also to make position: absolute; work on this element, you have to define position: relative; on the .dash-error-card__topbar parent.

And the close button will want some :hover css to make it appear clickable.

AnnMarieW · 2020-12-22T17:28:06Z

That looks so much better, Thanks!

The following commit includes your suggestions and adds a hover effect that makes the x darker. I think it looks nice :-)

alexcjohnson · 2020-12-26T23:41:24Z

+
+.dash-fe-error__icon-x:hover
+{
+ color:black;


That's probably a stronger effect than we want - really we just need enough to be able to see a change in the X. Closest analog I see is the grey debug menu buttons, which starts out about the same as #ccc (just a tiny bit tilted toward blue)
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 70 in e7f4984
background-color:#B9C2CE;
And on hover it gets just a bit darker
dash/dash-renderer/src/components/error/menu/DebugMenu.css
Line 84 in e7f4984
background-color:#a1a9b5;
I'm not sure where those exact colors came from, but we may be able to just copy them both.

I see, I'll make the change. Thanks!

alexcjohnson · 2021-01-06T17:07:57Z

+ className='dash-fe-error__icon-x'
+ onClick={() => clickHandler()}
+ >
+ x


Suggested change
x
×
This is the × character, which makes a nicer button than the letter x.

alexcjohnson · 2021-01-06T17:09:53Z

@@ -1,3 +1,3 @@
 <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 54 24">
-<path d="M18 2l18 18m0-18l-18 18" stroke-width="4" stroke="#fff"></path>
+<path d="M18 2l18 18m0-18l-18 18" stroke-width="6" stroke="#fff"></path>


Suggested change
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>
Not used in this PR anymore so let's put the original back.

alexcjohnson

Just two minor final edits then this is ready to go! 💃

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

Add an 'x' button to close the error messages popupplotly#1403
087aaaa

AnnMarieW requested review from Marc-Andre-Rivet, alexcjohnson and rpkyle as code owners December 19, 2020 17:45

ann-marie-ward added 3 commits December 22, 2020 11:31

Updated cssplotly#1403
b74ac86

One more css update to align the buttonplotly#1403
ebe50bb

One more css update to align the buttonplotly#1403
e53f278

alexcjohnson reviewed Dec 26, 2020
View reviewed changes

updated hover color
030f881

alexcjohnson reviewed Jan 6, 2021
View reviewed changes

alexcjohnson approved these changes Jan 6, 2021
View reviewed changes

ann-marie-wardand others added 3 commits January 6, 2021 10:44

x and officon update
a05b13f

Merge branch 'dev' into 1403-x-button-to-close-error-box
6cdb6da

update changelog forplotly#1505
beeee56

alexcjohnson mentioned this pull request Jan 6, 2021
Update component gen process for recent MDN changes plotly/dash-html-components#174
Merged

alexcjohnson merged commit 3402cb8 into plotly:devJan 7, 2021

AnnMarieW deleted the 1403-x-button-to-close-error-box branch January 7, 2021 15:01

dependabotBot mentioned this pull request Mar 12, 2021
Bump dash from 0.39.0 to 1.19.0 mstoelzle/solving-occlusion#28
Merged

	<pathd="M18 2l18 18m0-18l-18 18"stroke-width="6"stroke="#fff"></path>
	<pathd="M18 2l18 18m0-18l-18 18"stroke-width="4"stroke="#fff"></path>

Uh oh!

Uh oh!

Conversation

AnnMarieW commented Dec 19, 2020

Uh oh!

alexcjohnson commented Dec 22, 2020

Uh oh!

AnnMarieW commented Dec 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

AnnMarieW commented Dec 19, 2020

Uh oh!

alexcjohnson commented Dec 22, 2020

Uh oh!

AnnMarieW commented Dec 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

AnnMarieW commented Dec 19, 2020

Uh oh!

alexcjohnson commented Dec 22, 2020

Uh oh!

AnnMarieW commented Dec 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

AnnMarieW commented Dec 22, 2020•
edited
Loading

AnnMarieW commented Dec 22, 2020•
edited
Loading

AnnMarieW commented Dec 22, 2020•
edited
Loading

AnnMarieW commented Dec 22, 2020•
edited
Loading