') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Updating dashR component generation by HammadTheOne · Pull Request #1798 · plotly/dash · GitHub
Skip to content

Updating dashR component generation - #1798

Merged
alexcjohnson merged 7 commits into
devfrom
update-r-generation
Oct 14, 2021
Merged

Updating dashR component generation#1798
alexcjohnson merged 7 commits into
devfrom
update-r-generation

Conversation

@HammadTheOne

@HammadTheOneHammadTheOne commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

This PR adds a minor change to the dashR component generation by adding an export tag so component functions are automatically added to the NAMESPACE with devtools::document().

alexcjohnson
alexcjohnson reviewed Oct 8, 2021
View reviewed changes
Comment threadcomponents/dash-core-components/package-lock.json
"requires": true,
"packages": {
"": {
"name": "dash-core-components",

@alexcjohnsonalexcjohnsonOct 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably due to a minor NPM version difference between your env and whoever last updated this file (likely me)... not a big deal, but let's try not to commit changes like this.

@HammadTheOneHammadTheOneOct 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep the package name? For reference, my npm version is 7.15.1 (and node is 16.3.0).

@alexcjohnsonalexcjohnsonOct 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on 7.21.0, 16.8.0 - so yeah, I think this is a new addition to the package-lock format that we should keep.

@HammadTheOneHammadTheOneOct 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After upgrading to npm 8.0.0 the name key is now set. Fixed in 01c5803.

alexcjohnson
alexcjohnson reviewed Oct 8, 2021
View reviewed changes
Comment threadcomponents/dash-html-components/scripts/data/attributes.json Outdated
"form"
],
"description": "The URI of a program that processes the information submitted via the form."
"description": "The URI of a program that processes the information submitted via the form."

@alexcjohnsonalexcjohnsonOct 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that we get all this extra whitespace... there was a little bit of it before - like https://github.com/plotly/dash/pull/1798/files#diff-636f7fc815f56fa24377d9d5d7df894abf0ba39621713316f3af387bb5d70c13L310 - but we should really get rid of this, as it DOES make it into the final built components. For example here's height in Img.py right now:

 - height (string | number; optional):
Specifies the height of elements listed here. For all other
elements, use the CSS height property. Note: In some
instances, such as <div>, this is a legacy attribute, in which
case the CSS height property should be used instead.

@alexcjohnsonalexcjohnsonOct 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like here:

dash/components/dash-html-components/scripts/extract-attributes.js

Lines 71 to 75 in b32ac95

constdescription=$children.eq(2).text()
.replace(/\n/g,'')
// Fix irregular whitespace characters
.replace(' ',' ')
.trim();

IDK what replace(' ', ' ') is supposed to accomplish, but I suspect just turning it into .replace(/\s+/g, ' ') would do the trick

@HammadTheOneHammadTheOneOct 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it! 01c5803

@HammadTheOneHammadTheOne mentioned this pull request Oct 8, 2021
Merged
2 tasks
alexcjohnson
alexcjohnson approved these changes Oct 14, 2021
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Excellent!

@alexcjohnson
alexcjohnson merged commit 0299406 into devOct 14, 2021
@alexcjohnson
alexcjohnson deleted the update-r-generation branch October 14, 2021 15:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HammadTheOne@alexcjohnson