Skip to content

Fixes hash_function and error handler missing call for multi - #2922

Merged
T4rk1n merged 9 commits into
devfrom
fix/hash_function
Aug 28, 2024
Merged

Fixes hash_function and error handler missing call for multi#2922
T4rk1n merged 9 commits into
devfrom
fix/hash_function

Conversation

@T4rk1n

Copy link
Copy Markdown
Contributor

@gvwilsongvwilson added feature something new P2 considered for next cycle fix fixes something broken and removed feature something new labels Aug 13, 2024
@gvwilsongvwilson assigned marthacryan and unassigned T4rk1nAug 22, 2024
@gvwilson

Copy link
Copy Markdown
Contributor

@marthacryan can you please review?

@marthacryan

Copy link
Copy Markdown
Contributor

When I try to follow the link for #1885, it gives me a "Page not found" error. Is that because of permissions? Was it deleted?

@gvwilson

Copy link
Copy Markdown
Contributor

that is strange - @T4rk1n any ideas?

@marthacryan
marthacryan self-requested a review August 22, 2024 20:40

@marthacryanmarthacryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corebit-nl

corebit-nl commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

@T4rk1n , could you apply the try-except logic from https://github.com/plotly/dash/blob/dev/dash/long_callback/managers/__init__.py#L110 to https://github.com/plotly/dash/blob/dev/dash/long_callback/managers/__init__.py#L58 as well? In the current situation, long callbacks still fail for packed applications (eg. Pyinstaller). Fixing this would close Nuitka/Nuitka#2988 as well.

Edit: opened PR #3072 for this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixfixes something brokenP2considered for next cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] long_callback fails when bundling python code

4 participants

@T4rk1n@gvwilson@marthacryan@corebit-nl