Skip to content

Standalone dash renderer (for custom hooks) - March 1 - #367

Merged
valentijnnieman merged 37 commits into
masterfrom
standalone_dash-renderer
Feb 28, 2019
Merged

Standalone dash renderer (for custom hooks) - March 1#367
valentijnnieman merged 37 commits into
masterfrom
standalone_dash-renderer

Conversation

@valentijnnieman

@valentijnniemanvalentijnnieman commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

This enables the dash-renderer to be called as a standalone class, so that we can pass config objects to it.

Depends on this PR that enables dash-renderer to be a standalone class to be merged (also see this PR for an example of how to use a custom DashRenderer instance).

@valentijnniemanvalentijnnieman changed the title [WIP] Standalone dash renderer (for custom hooks)Standalone dash renderer (for custom hooks)Sep 5, 2018
@valentijnniemanvalentijnnieman changed the title Standalone dash renderer (for custom hooks)[WIP] Standalone dash renderer (for custom hooks)Sep 5, 2018
@valentijnniemanvalentijnnieman changed the title [WIP] Standalone dash renderer (for custom hooks)Standalone dash renderer (for custom hooks)Sep 5, 2018
Comment threaddash/dash.py
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py
Comment threadtests/test_integration.py Outdated
Comment threaddash/dash.py Outdated
@chriddyp

Copy link
Copy Markdown
Member

This side of the code is looking good to me! @T4rk1n could you take a look as well?

@T4rk1nT4rk1n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a couple minor changes.

Also before release, would we need to lock the version of dash-renderer in setup.py since the starting of the renderer has changed and now needs the new Renderer syntax ?

Comment threaddash/dash.py
Comment threaddash/dash.py Outdated
@Akronix

Copy link
Copy Markdown
Contributor

Hi. Can I ask how is the status of this? Is it in your roadmap or is there any tentative date for its release?

@chriddypchriddyp changed the title Standalone dash renderer (for custom hooks)Standalone dash renderer (for custom hooks) - March 1Jan 10, 2019
Comment threaddash/dash.py Outdated
Comment threaddash/dash.py Outdated
Comment threadrequirements.txt Outdated
Comment threadtests/test_integration.py Outdated

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think we're home free! Thanks for the changes this morning @valentijnnieman!
💃
The conflicts in requirements can be resolved in favor of the current master:
-e git://github.com/plotly/dash-renderer.git@master#egg=dash_renderer
if the renderer PR is merged first so that's on master.

@valentijnnieman
valentijnnieman merged commit f22973d into masterFeb 28, 2019
@alexcjohnson
alexcjohnson deleted the standalone_dash-renderer branch March 1, 2019 03:13
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@valentijnnieman@chriddyp@Akronix@alexcjohnson@T4rk1n@Marc-Andre-Rivet