Skip to content

Bugfix: datepicker updatemode="bothdates" not always respected - #3811

Merged
KoolADE85 merged 4 commits into
devfrom
bugfix/3425-datepicker-bothdates
Jun 30, 2026
Merged

Bugfix: datepicker updatemode="bothdates" not always respected#3811
KoolADE85 merged 4 commits into
devfrom
bugfix/3425-datepicker-bothdates

Conversation

@KoolADE85

@KoolADE85KoolADE85 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes a bug in DatePickerRange when updatemode="bothdates".

To reproduce:

  1. Create a DatePickerRange attached to a callback:
dcc.DatePickerRange(
start_date=date(2021, 1, 1),
end_date=date(2021, 1, 31),
updatemode="bothdates",
id="dpr",
),
  1. Start a new date selection by changing the dates
  2. Observe that the callback fires before both dates are selected (updatemode not respected)

Fixes#3425

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md

@KoolADE85KoolADE85 changed the title Bugfix:3425 datepicker bothdatesBugfix: datepicker updatemode="bothdates" not always respectedJun 10, 2026
KoolADE85
KoolADE85 commented Jun 10, 2026
View reviewed changes
Comment threadcomponents/dash-core-components/tests/integration/calendar/test_portal.py

action = ActionChains(dash_dcc.driver)
action.move_to_element_with_offset(popover, 10, 10).click().perform()
action.move_by_offset(10, 10).click().perform()

@KoolADE85KoolADE85Jun 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the bug - this just addresses a flaky test when run locally.

@camdecostercamdecoster self-assigned this Jun 25, 2026
camdecoster
camdecoster approved these changes Jun 30, 2026
View reviewed changes

@camdecostercamdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a demo app and the update fixed the issue.

@sonarqubecloud

sonarqubecloudBot commented Jun 30, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KoolADE85
KoolADE85 merged commit 27c7f7f into devJun 30, 2026
35 checks passed
@elklaassen

elklaassen commented Jul 1, 2026

Copy link
Copy Markdown

Great, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecostercamdecostercamdecoster approved these changes
@T4rk1nT4rk1nAwaiting requested review from T4rk1n
@ndreznndreznAwaiting requested review from ndrezn

Assignees

@KoolADE85KoolADE85

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] DatePickerRange updatemode not respected

3 participants

@KoolADE85@elklaassen@camdecoster