Skip to content

Better handling for user-defined error conditions in debug mode - #116

Merged
rpkyle merged 6 commits into
devfrom
115-handle-stop-errors
Sep 6, 2019
Merged

Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom
115-handle-stop-errors

Conversation

@rpkyle

@rpkylerpkyle commented Aug 13, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.

 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:

 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.

This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.

The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:

Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are

dashR/R/utils.R

Lines 698 to 707 in b170cfa

if (!is.null(e$call[[1]]))
errorCall<-e$call[[1]]
else {
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]]
}

dashR/R/utils.R

Lines 738 to 747 in b170cfa

if (is.function(currentCall[[1]])) {
identical(deparse(errorCall), deparse(currentCall[[1]]))
} elseif (currentCall[[1]] =="stop") {
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
identical(deparse(errorCall), deparse(currentCall))
}
else {
FALSE
}

dashR/R/utils.R

Lines 762 to 770 in b170cfa

# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s",
deparse(functionsAsList[[length(functionsAsList)]]),
conditionMessage(e)))
stack_message<- stackTraceToHTML(functionsAsList,
deparse(functionsAsList[[length(functionsAsList)]]),
conditionMessage(e))

Closes#115.

@rpkylerpkyle self-assigned this Aug 13, 2019
@rpkylerpkyle added the bug label Aug 13, 2019
@rpkyle
rpkyle changed the base branch from master to 112-prune-errorsAugust 13, 2019 15:26
@rpkyle

rpkyle commented Aug 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@alexcjohnson Any comments on this one?

@rpkyle

rpkyle commented Aug 23, 2019

Copy link
Copy Markdown
ContributorAuthor

As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.

@rpkyle
rpkyle changed the base branch from 112-prune-errors to devSeptember 3, 2019 19:07
@rpkyle

rpkyle commented Sep 6, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.

fixed in 1029ec4

@alexcjohnson

alexcjohnson
alexcjohnson approved these changes Sep 6, 2019
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rpkyle
rpkyle merged commit 29a3042 into devSep 6, 2019
@rpkyle
rpkyle deleted the 115-handle-stop-errors branch September 6, 2019 20:36
@rpkylerpkyle mentioned this pull request Sep 11, 2019
Closed
@rpkylerpkyle mentioned this pull request Jan 3, 2020
Merged
rpkyle added a commit that referenced this pull request Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Better handling for user-defined error conditions in debug mode by rpkyle · Pull Request #116 · plotly/dashR · GitHub
Skip to content
Better handling for user-defined error conditions in debug mode - #116
Merged
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Sep 6, 2019
Merged
Better handling for user-defined error conditions in debug mode#116
rpkyle merged 6 commits into
devfrom 
115-handle-stop-errors
Conversation
@rpkyle
@rpkylerpkyle
commented
Aug 13, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
As noted in #115, getStackTrace behaves a bit unexpectedly when a user defined error is encountered within a callback while in debug mode, e.g.
 if (city == "Winnipeg")
stop(simpleError("Winnipeg?"))

ought to produce the following console text while sending a traceback up to the dev tools UI:
 ### DashR Traceback (most recent/innermost call last) ###
1: getStackTrace
2: do.call
3: <anonymous> function(city, tempscale)
4: stop
in debug mode, catching error as warning ...
warning: Execution error in stop: Winnipeg? from NULL

However, the traceback was not provided previously in such cases, and a JS error could be thrown in the browser instead, halting app execution.
This PR proposes to address the problem by introducing conditional logic to identify calls of class simpleError, and to deparse the calls so that they may be treated as strings when constructing the stack_message object.
The problem is that stop is a symbol in R, and attempting to naively treat it as a string may throw the following error:
Error in sprintf(template, header, throwing_call, error_message, formattedStack) : invalid type of argument[2]: 'symbol'

which can prevent the traceback from being returned. The key additions are
dashR/R/utils.R

Lines 698 to 707
in
b170cfa
if (!is.null(e$call[[1]])) 
errorCall<-e$call[[1]] 
else { 
# attempt to capture the error or warning if thrown by
# simpleError or simpleWarning (which may arise for user-defined errors)
#
# the first matching call in the reversed stack will always be
# getStackTrace, so we select the second match instead
errorCall<-reverseStack[grepl(x=reverseStack, "simpleError|simpleWarning")][[2]] 
 } 
dashR/R/utils.R

Lines 738 to 747
in
b170cfa
if (is.function(currentCall[[1]])) { 
 identical(deparse(errorCall), deparse(currentCall[[1]])) 
 } elseif (currentCall[[1]] =="stop") { 
# handle case where function developer deliberately invokes a stop
# condition and halts function execution
 identical(deparse(errorCall), deparse(currentCall)) 
 } 
else { 
FALSE
 } 
dashR/R/utils.R

Lines 762 to 770
in
b170cfa
# use deparse in case the call throwing the error is a symbol,
# since this cannot be "printed" without deparsing the call
 warning(call.=FALSE, immediate.=TRUE, sprintf("Execution error in %s: %s", 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e))) 
stack_message<- stackTraceToHTML(functionsAsList, 
 deparse(functionsAsList[[length(functionsAsList)]]), 
 conditionMessage(e)) 
Closes#115.
@rpkylerpkyle
self-assigned this
Aug 13, 2019
@rpkylerpkyle
added
the 
bug

label
Aug 13, 2019
@rpkyle
rpkyle
changed the base branch from
master
to
112-prune-errorsAugust 13, 2019 15:26
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson Any comments on this one?
@rpkyle
rpkyle
commented
Aug 23, 2019

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
@rpkyle
rpkyle
changed the base branch from
112-prune-errors
to
devSeptember 3, 2019 19:07
@rpkyle
rpkyle
commented
Sep 6, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As discussed this morning, I'll implement a basic test which incorporates a stop error to demonstrate what this resolves.
fixed in 1029ec4
@alexcjohnson
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
merged commit 29a3042
into
devSep 6, 2019
@rpkyle
rpkyle
deleted the

115-handle-stop-errors

branch
September 6, 2019 20:36
@rpkylerpkyle
mentioned this pull request
Sep 11, 2019

Closed

@rpkylerpkyle
mentioned this pull request
Jan 3, 2020
 Merged

rpkyle added a commit
that referenced
this pull request
Jan 4, 2020
@rpkyle
Dash for R v0.2.0 (#162)
f6c13a9
* Provide support for no_update in Dash for R (#111)
* Use dev_tools_prune_errors instead of pruned_errors (#113)
* Better handling for user-defined error conditions in debug mode (#116)
* Provide support for multiple outputs (#119)
* Provide support for hot reloading in Dash for R (#127)
* Implement support for clientside callbacks in Dash for R (#130)
* Add line number context to stack traces when srcrefs are available (#133)
* Update dash-renderer to 1.2.2 and fix dev tools UI display of stack traces (#137)
* Support for meta tags in Dash for R (#142)
* Fixes for hot reloading interval handling and refreshing apps within viewer pane (#148)
* Support for asynchronous loading/compression in Dash for R (#157)
* Support returning asset URLs via public method within Dash class (#160)
* Minor fix for get_asset_url + docs, add url_base_pathname (#161)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

bug

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@rpkyle@alexcjohnson