Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33
Dash R Core Package Unification#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
32ba6bbe7c523ef28adcee6fcb6eccce6ab2b282684946ae6ea39c8afae8c793e266c92ee8b56bd6080bef6a5c7227df5837607840ed9eb6028a5e14662f93b6a47369977a3ff02b125d8534f4d66d720ace5af1bf0dc697a8942b6601411c7ee6655b9f9600427f28ec1ab35fb42f18File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Diff view
Diff view
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -7,3 +7,5 @@ todo\.txt | ||
| .github | ||
| tests/integration | ||
| tests/circleci | ||
| gulp-assets | ||
| node_modules | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| { | ||
| "extends": ["eslint:recommended", "prettier"], | ||
| "parser": "babel-eslint", | ||
| "parserOptions": { | ||
| "ecmaVersion": 6, | ||
| "sourceType": "module", | ||
| "ecmaFeatures": { | ||
| "arrowFunctions": true, | ||
| "blockBindings": true, | ||
| "classes": true, | ||
| "defaultParams": true, | ||
| "destructuring": true, | ||
| "forOf": true, | ||
| "generators": true, | ||
| "modules": true, | ||
| "templateStrings": true, | ||
| "jsx": true | ||
| } | ||
| }, | ||
| "env": { | ||
| "browser": true, | ||
| "es6": true, | ||
| "jasmine": true, | ||
| "jest": true, | ||
| "node": true | ||
| }, | ||
| "globals": { | ||
| "jest": true | ||
| }, | ||
| "plugins": [ | ||
| "react", | ||
| "import" | ||
| ], | ||
| "rules": { | ||
| "accessor-pairs": ["error"], | ||
| "block-scoped-var": ["error"], | ||
| "consistent-return": ["error"], | ||
| "curly": ["error", "all"], | ||
| "default-case": ["error"], | ||
| "dot-location": ["off"], | ||
| "dot-notation": ["error"], | ||
| "eqeqeq": ["error"], | ||
| "guard-for-in": ["off"], | ||
| "import/export": "error", | ||
| "import/named": ["off"], | ||
| "import/namespace": ["off"], | ||
| "import/no-duplicates": ["error"], | ||
| "import/no-named-as-default": ["error"], | ||
| "import/no-unresolved": ["off"], | ||
| "new-cap": ["error", { | ||
| "capIsNewExceptionPattern": "Immutable\\.*" | ||
| }], | ||
| "no-alert": ["off"], | ||
| "no-caller": ["error"], | ||
| "no-case-declarations": ["error"], | ||
| "no-console": ["error"], | ||
| "no-div-regex": ["error"], | ||
| "no-dupe-keys": ["error"], | ||
| "no-else-return": ["error"], | ||
| "no-empty-pattern": ["error"], | ||
| "no-eq-null": ["error"], | ||
| "no-eval": ["error"], | ||
| "no-extend-native": ["error"], | ||
| "no-extra-bind": ["error"], | ||
| "no-extra-boolean-cast": ["error"], | ||
| "no-inline-comments": ["off"], | ||
| "no-implicit-coercion": ["error"], | ||
| "no-implied-eval": ["error"], | ||
| "no-inner-declarations": ["off"], | ||
| "no-invalid-this": ["error"], | ||
| "no-iterator": ["error"], | ||
| "no-labels": ["error"], | ||
| "no-lone-blocks": ["error"], | ||
| "no-loop-func": ["error"], | ||
| "no-multi-str": ["error"], | ||
| "no-native-reassign": ["error"], | ||
| "no-new": ["error"], | ||
| "no-new-func": ["error"], | ||
| "no-new-wrappers": ["error"], | ||
| "no-param-reassign": ["off"], | ||
| "no-process-env": ["warn"], | ||
| "no-proto": ["error"], | ||
| "no-redeclare": ["error"], | ||
| "no-return-assign": ["error"], | ||
| "no-script-url": ["error"], | ||
| "no-self-compare": ["error"], | ||
| "no-sequences": ["error"], | ||
| "no-shadow": ["off"], | ||
| "no-throw-literal": ["error"], | ||
| "no-unused-expressions": ["error"], | ||
| "no-use-before-define": ["error", "nofunc"], | ||
| "no-useless-call": ["error"], | ||
| "no-useless-concat": ["error"], | ||
| "no-with": ["error"], | ||
| "prefer-const": ["error"], | ||
| "radix": ["error"], | ||
| "react/jsx-no-duplicate-props": ["error"], | ||
| "react/jsx-no-undef": ["error"], | ||
| "react/jsx-uses-react": ["error"], | ||
| "react/jsx-uses-vars": ["error"], | ||
| "react/no-did-update-set-state": ["error"], | ||
| "react/no-direct-mutation-state": ["error"], | ||
| "react/no-is-mounted": ["error"], | ||
| "react/no-unknown-property": ["error"], | ||
| "react/prefer-es6-class": ["error", "always"], | ||
| "react/prop-types": "error", | ||
| "valid-jsdoc": ["off"], | ||
| "yoda": ["error"], | ||
| "spaced-comment": ["error", "always", { | ||
| "block": { | ||
| "exceptions": ["*"] | ||
| } | ||
| }], | ||
| "no-unused-vars": ["error", { | ||
| "args": "after-used", | ||
| "argsIgnorePattern": "^_", | ||
| "caughtErrorsIgnorePattern": "^e$" | ||
| }], | ||
| "no-magic-numbers": ["error", { | ||
| "ignoreArrayIndexes": true, | ||
| "ignore": [-1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 100, 10, 16, 0.5, 25] | ||
| }], | ||
| "no-underscore-dangle": ["off"], | ||
| "no-useless-escape": ["off"] | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -3,6 +3,9 @@ | ||
| .RData | ||
| .DS_Store | ||
| dash-core-components/ | ||
| dash-html-components/ | ||
| dash-table/ | ||
| node_modules/ | ||
| python/ | ||
| todo.txt | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "tabWidth": 4, | ||
| "singleQuote": true, | ||
| "bracketSpacing": false, | ||
| "trailingComma": "es5" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,11 @@ | ||
| Package: dash | ||
| Title: An Interface to the Dash Ecosystem for Authoring Reactive Web Applications | ||
| Version: 0.9.1 | ||
| Authors@R: c(person("Chris", "Parmer", role = c("aut"), email = "chris@plotly.com"), person("Ryan Patrick", "Kyle", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5829-9867"), email = "ryan@plotly.com"), person("Carson", "Sievert", role = c("aut"), comment = c(ORCID = "0000-0002-4958-2844")), person("Hammad", "Khan", role = c("aut"), comment = c(ORCID = "0000-0003-2479-9841"), email = "hammadkhan@plotly.com"), person(family = "Plotly Technologies", role = "cph")) | ||
| Version: 1.0.0 | ||
| Authors@R: c(person("Chris", "Parmer", role = c("aut"), email = "chris@plotly.com"), person("Ryan Patrick", "Kyle", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5829-9867"), email = "ryan@plotly.com"), person("Carson", "Sievert", role = c("aut"), comment = c(ORCID = "0000-0002-4958-2844")), person("Hammad", "Khan", role = c("aut"), comment = c(ORCID = "0000-0003-2479-9841"), email = "hammadkhan@plotly.com"), person(family = "Plotly Technologies", role = "cph")) | ||
| Description: A framework for building analytical web applications, Dash offers a pleasant and productive development experience. No JavaScript required. | ||
| Depends: | ||
| R (>= 3.0.2) | ||
| Imports: | ||
| dashHtmlComponents (== 1.1.1), | ||
| dashCoreComponents (== 1.13.0), | ||
| dashTable (== 4.11.0), | ||
Comment on lines
-9
to
-11
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎉 | ||
| R6, | ||
| fiery (> 1.0.0), | ||
| routr (> 0.2.0), | ||
| @@ -25,17 +22,6 @@ Imports: | ||
| glue | ||
| Suggests: | ||
| testthat | ||
| Collate: | ||
| 'utils.R' | ||
| 'dependencies.R' | ||
| 'dash-package.R' | ||
| 'dash.R' | ||
| 'imports.R' | ||
| 'print.R' | ||
| 'internal.R' | ||
Comment on lines
-28
to
-35
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did this get removed when you re-ran ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did remove this manually. Ideally what I would expect to happen is that all the new Do you think there's a better way around it than simply removing it? I didn't notice any issues arising from removing it myself. Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HammadTheOne I think it's safe to remove it. If the tests pass, and the package functionality remains as before, I'm OK if we 🔪 this block. | ||
| Remotes: plotly/dash-html-components@7209e0a, | ||
| plotly/dash-core-components@91a424e, | ||
| plotly/dash-table@aa519b7 | ||
| License: MIT + file LICENSE | ||
| Encoding: UTF-8 | ||
| LazyData: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -10,8 +10,6 @@ export(dashNoUpdate) | ||
| export(input) | ||
| export(output) | ||
| export(state) | ||
| import(dashCoreComponents) | ||
| import(dashHtmlComponents) | ||
| importFrom(R6,R6Class) | ||
rpkyle marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| importFrom(assertthat,assert_that) | ||
| importFrom(base64enc,base64encode) | ||
| @@ -34,3 +32,172 @@ importFrom(routr,ressource_route) | ||
| importFrom(stats,setNames) | ||
| importFrom(tools,file_ext) | ||
| importFrom(utils,getFromNamespace) | ||
| # dashCoreComponents exports appended by `npm unify` command: do not edit by hand | ||
| export(dccChecklist) | ||
| export(dccClipboard) | ||
| export(dccConfirmDialog) | ||
| export(dccConfirmDialogProvider) | ||
| export(dccDatePickerRange) | ||
| export(dccDatePickerSingle) | ||
| export(dccDownload) | ||
| export(dccDropdown) | ||
| export(dccGraph) | ||
| export(dccInput) | ||
| export(dccInterval) | ||
| export(dccLink) | ||
| export(dccLoading) | ||
| export(dccLocation) | ||
| export(dccLogoutButton) | ||
| export(dccMarkdown) | ||
| export(dccRadioItems) | ||
| export(dccRangeSlider) | ||
| export(dccSlider) | ||
| export(dccStore) | ||
| export(dccTab) | ||
| export(dccTabs) | ||
| export(dccTextarea) | ||
| export(dccUpload) | ||
| # dashHtmlComponents exports appended by `npm unify` command: do not edit by hand | ||
| export(htmlA) | ||
| export(htmlAbbr) | ||
| export(htmlAcronym) | ||
| export(htmlAddress) | ||
| export(htmlArea) | ||
| export(htmlArticle) | ||
| export(htmlAside) | ||
| export(htmlAudio) | ||
| export(htmlB) | ||
| export(htmlBase) | ||
| export(htmlBasefont) | ||
| export(htmlBdi) | ||
| export(htmlBdo) | ||
| export(htmlBig) | ||
| export(htmlBlink) | ||
| export(htmlBlockquote) | ||
| export(htmlBr) | ||
| export(htmlButton) | ||
| export(htmlCanvas) | ||
| export(htmlCaption) | ||
| export(htmlCenter) | ||
| export(htmlCite) | ||
| export(htmlCode) | ||
| export(htmlCol) | ||
| export(htmlColgroup) | ||
| export(htmlCommand) | ||
| export(htmlContent) | ||
| export(htmlData) | ||
| export(htmlDatalist) | ||
| export(htmlDd) | ||
| export(htmlDel) | ||
| export(htmlDetails) | ||
| export(htmlDfn) | ||
| export(htmlDialog) | ||
| export(htmlDiv) | ||
| export(htmlDl) | ||
| export(htmlDt) | ||
| export(htmlElement) | ||
| export(htmlEm) | ||
| export(htmlEmbed) | ||
| export(htmlFieldset) | ||
| export(htmlFigcaption) | ||
| export(htmlFigure) | ||
| export(htmlFont) | ||
| export(htmlFooter) | ||
| export(htmlForm) | ||
| export(htmlFrame) | ||
| export(htmlFrameset) | ||
| export(htmlH1) | ||
| export(htmlH2) | ||
| export(htmlH3) | ||
| export(htmlH4) | ||
| export(htmlH5) | ||
| export(htmlH6) | ||
| export(htmlHeader) | ||
| export(htmlHgroup) | ||
| export(htmlHr) | ||
| export(htmlI) | ||
| export(htmlIframe) | ||
| export(htmlImg) | ||
| export(htmlIns) | ||
| export(htmlIsindex) | ||
| export(htmlKbd) | ||
| export(htmlKeygen) | ||
| export(htmlLabel) | ||
| export(htmlLegend) | ||
| export(htmlLi) | ||
| export(htmlLink) | ||
| export(htmlListing) | ||
| export(htmlMain) | ||
| export(htmlMapEl) | ||
| export(htmlMark) | ||
| export(htmlMarquee) | ||
| export(htmlMeta) | ||
| export(htmlMeter) | ||
| export(htmlMulticol) | ||
| export(htmlNav) | ||
| export(htmlNextid) | ||
| export(htmlNobr) | ||
| export(htmlNoscript) | ||
| export(htmlObjectEl) | ||
| export(htmlOl) | ||
| export(htmlOptgroup) | ||
| export(htmlOption) | ||
| export(htmlOutput) | ||
| export(htmlP) | ||
| export(htmlParam) | ||
| export(htmlPicture) | ||
| export(htmlPlaintext) | ||
| export(htmlPre) | ||
| export(htmlProgress) | ||
| export(htmlQ) | ||
| export(htmlRb) | ||
| export(htmlRp) | ||
| export(htmlRt) | ||
| export(htmlRtc) | ||
| export(htmlRuby) | ||
| export(htmlS) | ||
| export(htmlSamp) | ||
| export(htmlScript) | ||
| export(htmlSection) | ||
| export(htmlSelect) | ||
| export(htmlShadow) | ||
| export(htmlSlot) | ||
| export(htmlSmall) | ||
| export(htmlSource) | ||
| export(htmlSpacer) | ||
| export(htmlSpan) | ||
| export(htmlStrike) | ||
| export(htmlStrong) | ||
| export(htmlSub) | ||
| export(htmlSummary) | ||
| export(htmlSup) | ||
| export(htmlTable) | ||
| export(htmlTbody) | ||
| export(htmlTd) | ||
| export(htmlTemplate) | ||
| export(htmlTextarea) | ||
| export(htmlTfoot) | ||
| export(htmlTh) | ||
| export(htmlThead) | ||
| export(htmlTime) | ||
| export(htmlTitle) | ||
| export(htmlTr) | ||
| export(htmlTrack) | ||
| export(htmlU) | ||
| export(htmlUl) | ||
| export(htmlVar) | ||
| export(htmlVideo) | ||
| export(htmlWbr) | ||
| export(htmlXmp) | ||
| # dashTable exports appended by `npm unify` command: do not edit by hand | ||
| export(dashDataTable) | ||
| export(df_to_list) | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨