Skip to content

Remove run_heroku() and inspect environment vars for setting host and port - #75

Merged
rpkyle merged 3 commits into
0.0.7-devfrom
0.0.4-issue73
Apr 18, 2019
Merged

Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom
0.0.4-issue73

Conversation

@rpkyle

@rpkylerpkyle commented Mar 31, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR proposes to

  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port

Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():

dashR/R/dash.R

Lines 414 to 418 in 3ff3c62

run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) {
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port)
self$server$ignite(block=block, showcase=showcase, ...)
},

...and the second is run_heroku():

dashR/R/dash.R

Lines 419 to 423 in 3ff3c62

run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) {
self$server$host<-host
self$server$port<- as.numeric(port)
self$run_server(...)
}

These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.

Closes#73.

@rpkylerpkyle self-assigned this Mar 31, 2019
@rpkyle
rpkyle requested a review from TahiriNadiaMarch 31, 2019 04:44
@rpkyle

rpkyle commented Mar 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂

alexcjohnson
alexcjohnson reviewed Apr 1, 2019
View reviewed changes
Comment threadR/dash.R Outdated
showcase = FALSE,
...) {
if (!is.null(host)) self$server$host <- host
if (!is.null(port)) self$server$port <- as.numeric(port)

@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?

@rpkylerpkyleApr 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.

@rpkylerpkyleApr 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204

@alexcjohnson

alexcjohnson commented Apr 1, 2019

Copy link
Copy Markdown
Collaborator

Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.

@TahiriNadia

TahiriNadia commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

I will check if this version is working

@TahiriNadia

TahiriNadia commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

Pipeline:

  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R

Locally is working

S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia

TahiriNadia commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

In Heroku server no error message appears (immediately),
after 5 minutes one message appear on the browser

This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia

TahiriNadia commented Apr 1, 2019

Copy link
Copy Markdown
Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle

rpkyle commented Apr 1, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

In Heroku server no error message appears (immediately),
after 5 minutes one message appear on the browser

This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?

You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.

@TahiriNadia

TahiriNadia commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

I will check

@TahiriNadia

TahiriNadia commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

The error persists:
I tried many steps

2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle changed the base branch from master to 0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle removed the request for review from TahiriNadiaApril 15, 2019 15:52
@rpkyle

rpkyle commented Apr 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.

In Python, we use port 8050 by default:

https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427

...and host is set to 127.0.0.1:

https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481

Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):

app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle

rpkyle commented Apr 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.

I think we're ready to merge, if you're willing to give me the 💃.

alexcjohnson
alexcjohnson approved these changes Apr 18, 2019
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@rpkyle

rpkyle commented Apr 18, 2019

Copy link
Copy Markdown
ContributorAuthor

https://github.com/plotly/streambed/issues/12797

@rpkyle
rpkyle merged commit fcb0972 into 0.0.7-devApr 18, 2019
@rpkylerpkyle mentioned this pull request Jun 18, 2019
Closed
@rpkyle
rpkyle deleted the 0.0.4-issue73 branch November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove run_heroku() and inspect environment vars for setting host and port by rpkyle · Pull Request #75 · plotly/dashR · GitHub
Skip to content
Remove run_heroku() and inspect environment vars for setting host and port - #75
Merged
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Apr 18, 2019
Merged
Remove run_heroku() and inspect environment vars for setting host and port#75
rpkyle merged 3 commits into
0.0.7-devfrom 
0.0.4-issue73
Conversation
@rpkyle
@rpkylerpkyle
commented
Mar 31, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR proposes to
  • 🔪 the run_heroku() method
  • modify run_server() to inspect local environment variables if host and port are not provided
  • use defaults of 127.0.0.1 for host and 8050 (rather than 8080) for port
Currently, DashR provides two separate methods for launching the fiery server and serving up a Dash app. The first is run_server():
dashR/R/dash.R

Lines 414 to 418
in
3ff3c62
run_server=function(host=NULL, port=NULL, block=TRUE, showcase=FALSE, ...) { 
if (!is.null(host)) self$server$host<-host
if (!is.null(port)) self$server$port<- as.numeric(port) 
self$server$ignite(block=block, showcase=showcase, ...) 
 }, 
...and the second is run_heroku():
dashR/R/dash.R

Lines 419 to 423
in
3ff3c62
run_heroku=function(host="0.0.0.0", port= Sys.getenv('PORT', 8080), ...) { 
self$server$host<-host
self$server$port<- as.numeric(port) 
self$run_server(...) 
 } 
These differ predominantly in the way they set and handle default host and port variables. It would be preferable to condense these into a single method called run_server(), and attempt to query DASH_HOST and DASH_PORT environment variables when host and port information is not supplied.
Closes#73.
@rpkylerpkyle
self-assigned this
Mar 31, 2019
@rpkyle
rpkyle
requested a review
from TahiriNadiaMarch 31, 2019 04:44
@rpkyle
rpkyle
commented
Mar 31, 2019

Copy link


Copy Markdown

ContributorAuthor
@TahiriNadia If you could take a look at this one too, would be grateful. Thanks 🙂
alexcjohnson
alexcjohnson
reviewed
Apr 1, 2019
View reviewed changes
Comment threadR/dash.R
Outdated

 showcase = FALSE, 
 ...) {
 if (!is.null(host)) self$server$host <- host
 if (!is.null(port)) self$server$port <- as.numeric(port)
@alexcjohnsonalexcjohnsonApr 1, 2019

Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want these is.null checks?
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left them in, but the effect of passing NULL here would just be to use port 8080 instead of 8050 (as this is the fiery default), while the host would still be 127.0.0.1. Makes sense to 🔪 these.
@rpkylerpkyleApr 1, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 5b28204
@alexcjohnson
alexcjohnson
commented
Apr 1, 2019

Copy link


Copy Markdown

Collaborator
Awesome! Looks good to me, but I'll let @TahiriNadia give the 💃 after verifying that this works as expected both locally and on Heroku.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check if this version is working
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
Pipeline:
  • remove dashR pkg + dashR lib
  • install dashR branch 5b28204
  • 🚚 mv app$run_heroku() by app$run_server() in run.R
Locally is working
S-Wu:dash-docs nadia_tahiri$ Rscript run.R
Fire started at 127.0.0.1:8050
start: 127.0.0.1:8050
...

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
> heroku logs

2019-04-01T20:10:25.452541+00:00 app[web.1]: > app$run_server()
2019-04-01T20:10:25.515999+00:00 app[web.1]: Fire started at 127.0.0.1:8050
2019-04-01T20:10:26.602545+00:00 app[web.1]: start: 127.0.0.1:8050
2019-04-01T20:10:30.469773+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash-renderer/dash_renderer.min.js.map" host=dashr-docs.herokuapp.com request_id=a8230022-0da7-4847-9bc7-73b1c96820ae fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:10:30.473017+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/_dash-component-suites/dash_core_components/dash_core_components.min.js.map" host=dashr-docs.herokuapp.com request_id=5a8095d7-270c-43d9-a088-38e1f61fa3d1 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.886412+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=a1790cc2-50b0-44f2-9f11-0807009bd591 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:11.884021+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=POST path="/_dash-update-component" host=dashr-docs.herokuapp.com request_id=3f0b875c-ab3e-4e66-b150-bc2838e6af9c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:16.229703+00:00 heroku[router]: at=error code=H20 desc="App boot timeout" method=GET path="/" host=dashr-docs.herokuapp.com request_id=cba7063c-89f7-480b-beab-09cb23a0a706 fwd="24.202.75.172" dyno= connect=service= status=503 bytes= protocol=http
2019-04-01T20:11:20.931513+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-01T20:11:20.931578+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-01T20:11:20.950343+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2019-04-01T20:11:21.015119+00:00 heroku[web.1]: Process exited with status 22
2019-04-01T20:11:31.988400+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-01T20:11:33.618435+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=1abe08b3-e30a-4b31-a628-39aa4657575c fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:11:34.058077+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=0d7ee789-66d6-4097-9b92-98f12d658f04 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:22.892810+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=2414a237-a4aa-4461-84fe-21b19c895298 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http
2019-04-01T20:12:23.185788+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=7d197b27-42d4-4401-a264-eff0bdb5aaf0 fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=http

@rpkyle
rpkyle
commented
Apr 1, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
In Heroku server no error message appears (immediately),

after 5 minutes one message appear on the browser
This page isn’t working dashr-docs.herokuapp.com didn’t send any data.
ERR_EMPTY_RESPONSE

@TahiriNadia Thanks for testing this. Can I ask whether you set the environment variable DASH_HOST to 0.0.0.0? Is Heroku running on port 8080 (the old default) or 8050 (the new default)?
You may also wish to set DASH_PORT to 8080 (or whatever the config requires) here.
@TahiriNadia
TahiriNadia
commented
Apr 1, 2019

Copy link


Copy Markdown

Contributor
I will check
@TahiriNadia
TahiriNadia
commented
Apr 2, 2019

Copy link


Copy Markdown

Contributor
The error persists:

I tried many steps
2019-04-02T14:11:17.678196+00:00 app[web.1]: > app$run_server()
2019-04-02T14:11:17.815038+00:00 app[web.1]: Fire started at 127.0.0.1:8080
2019-04-02T14:11:19.008400+00:00 app[web.1]: start: 127.0.0.1:8080
2019-04-02T14:12:08.104520+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORTwithin 60 seconds of launch
2019-04-02T14:12:08.104621+00:00 heroku[web.1]: Stopping process with SIGKILL
2019-04-02T14:12:08.248115+00:00 heroku[web.1]: Process exited with status 137
2019-04-02T14:12:08.267595+00:00 heroku[web.1]: State changed from starting to crashed
2019-04-02T14:13:47.159854+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=449cf20d-062c-40f2-820b-d186bd8068ab fwd="24.202.75.172" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.170666+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=dashr-docs.herokuapp.com request_id=036f4f35-facf-4063-b2d3-19e7b71cd7f5 fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https
2019-04-02T15:10:41.622385+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=dashr-docs.herokuapp.com request_id=632c5951-3cf5-4012-9722-45fae29e305e fwd="142.137.142.251" dyno= connect= service= status=503 bytes= protocol=https

@rpkyle
rpkyle
changed the base branch from
master
to
0.0.7-devApril 10, 2019 01:02
@rpkyle
rpkyle
removed the request for review
from TahiriNadiaApril 15, 2019 15:52
@rpkyle
rpkyle
commented
Apr 18, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
An important change as a result of merging this PR: for parity with Python, app developers will now need to explicitly supply arguments when deploying to Heroku.
In Python, we use port 8050 by default:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1426-L1427
...and host is set to 127.0.0.1:
https://github.com/plotly/dash/blob/ac10b2df1e49a153de00fc78b07242f439bb0b99/dash/dash.py#L1481
Heroku deployments will likely now require explicit host and port settings in run_server (in lieu of using run_heroku):
app$run_server(host = "0.0.0.0", port = Sys.getenv('PORT'))

@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
@alexcjohnson I just tested this locally and with the DashR docs, and it's working as intended.
I think we're ready to merge, if you're willing to give me the 💃.
alexcjohnson
alexcjohnson
approved these changes
Apr 18, 2019
View reviewed changes
@alexcjohnsonalexcjohnson
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃
@rpkyle
rpkyle
commented
Apr 18, 2019

Copy link


Copy Markdown

ContributorAuthor
https://github.com/plotly/streambed/issues/12797
@rpkyle
rpkyle
merged commit fcb0972
into
0.0.7-devApr 18, 2019
@rpkylerpkyle
mentioned this pull request
Jun 18, 2019

Closed

@rpkyle
rpkyle
deleted the

0.0.4-issue73

branch
November 4, 2019 17:53
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

@rpkylerpkyle

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@rpkyle@alexcjohnson@TahiriNadia