SQLTable: add row filters

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)

[n-riesco]

• Replaced fixed-data-table with react-data-grid

• Implemented row filters

Closes#351

---

@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?

@jackparmer Would you take this PR for a spin and see if you'd like to change anything?

[jackparmer]

@n-riesco I'm having trouble running the artifact. Could you share a screencast?

[n-riesco]

@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message (click on the header to toggle the row filter) to the top? were you using a phone?

[jackparmer]

Thanks! I think this looks good.

[shannonlal]

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

[shannonlal]

@n-riesco Looks good as well 💃

[n-riesco]

@shannonlal

Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation

This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

[jackparmer]

I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.

I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.

[n-riesco]

Jack, as usual, your collections of links are gold! :)